From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from IMSVA.IN.MEGATRENDS.COM (IMSVA.IN.MEGATRENDS.COM [14.98.235.2]) by mx.groups.io with SMTP id smtpd.web10.63197.1597744346388054842 for ; Tue, 18 Aug 2020 02:52:27 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=SPF record not found (domain: amiindia.co.in, ip: 14.98.235.2, mailfrom: sivaramann@amiindia.co.in) Received: from IMSVA.IN.MEGATRENDS.COM (IMSVA.IN.MEGATRENDS.COM [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A1BF682076; Tue, 18 Aug 2020 15:31:08 +0530 (IST) Received: from IMSVA.IN.MEGATRENDS.COM (IMSVA.IN.MEGATRENDS.COM [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D52F682074; Tue, 18 Aug 2020 15:31:06 +0530 (IST) Received: from webmail.amiindia.co.in (venus2.in.megatrends.com [10.0.0.7]) by IMSVA.IN.MEGATRENDS.COM (Postfix) with ESMTPS; Tue, 18 Aug 2020 15:31:06 +0530 (IST) Received: from VENUS1.in.megatrends.com ([fe80::951:7975:6ecf:eae5]) by Venus2.in.megatrends.com ([fe80::2002:4a07:4f17:c09b%14]) with mapi id 14.03.0248.002; Tue, 18 Aug 2020 15:22:19 +0530 From: "Sivaraman Nainar" To: "Bi, Dandan" , "Wu, Jiaxin" , "Rabeda, Maciej" CC: "devel@edk2.groups.io" Subject: Re: reg: Wifi Connection Manager Setup Page Issues Thread-Topic: reg: Wifi Connection Manager Setup Page Issues Thread-Index: AdYk5UJpOlhlXrj0Tfq+Jy2vYp6FkwFyhOyAAMNZC6AR4hMSQA== Date: Tue, 18 Aug 2020 09:52:17 +0000 Message-ID: References: <160CEEA2C84817A9.8752@groups.io> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.0.3.190] MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-TM-AS-Product-Ver: IMSVA-9.1.0.1817-8.6.0.1013-25610.006 X-TM-AS-Result: No--21.386-5.0-31-10 X-imss-scan-details: No--21.386-5.0-31-10 X-TMASE-Version: IMSVA-9.1.0.1817-8.6.1013-25610.006 X-TMASE-Result: 10--21.385800-10.000000 X-TMASE-MatchedRID: vWvnoyq7eMxbJCKOm3VRCZkd+ko3VgxlI/FKU8SVjIC5saWC3JfK8n/i nirn0Q3sjlL/hujrw1tLIfps09VJ26Gnvnr+szpSe7ijHq7g9oaygaZY7yrHztz+FvoB0agSwvA LCKDrhS70l4sFbmQmBzotmeAoRcF1ChdI4sLlrjhOC1465WFnqF1o7wPE6VhYEQ4/n0S4Q03eD4 7jpUTMZTUpT+bgN3auuLHENGl+3A8QOcMSo0926pQSL3wNKmMr35dD76rzBfeDXQncoUN4hUIaN 3m1uYXoVM0f8gR0I2YqsMfMfrOZRdGOcAfHKa6uG6JsN5XWpsY9dagwNh/l7IzA079RgsgXof6O BWdOtPnhNZ+5vozIwPbta0OAYFzyBnIRIVcCWN+eRemS03ylhT3dkYB9k1zVbMUurPGRdMqXCA+ rJzwCssYpXvVe6w2Vqugjp/x3OwmX10IS8HM4/x+ZGcvxEG4E/fZeS/lDEATPi27s6VEdRunb9Z CRNMIy0Dg2p0ztpjRNq5/Y+tFvW6kHfh7O2L+7fkiy7TTogYauBGQ0NzLWHMjukRawXnTsNpFiF MKX8NHYb1619zjryrFPNlLHkDO07Y2RdA2mSwmqamOTUCsCM/DckdCjrjTF6P2jQ8ymte/Jj6pw ifw6c3//aC4gn5TY/Sl5cYQQGW+YcCnZQnz5PErRZP/NcCCSkDNs4OMoXxKahG/i8Ja1Y/DwDyV 4OCc/W01/W0YcEw4zvWHRIxWXwncbVuybnN+MzcoP6tZuq3FJPus6r/YfunzDEt5GzT5uAIc8nt Q21XloNkfLUlnow4DcpVWyPxAMPZmbnY2qDImbKItl61J/yZUdXE/WGn0FHwAqApZ40aEzWh4d/ b1Ci9bkrsq6X+UeRRgndEtDQrKHoNL/MmFsOSJkKlWEieL1SX8RX41wiufNBVJ81KhJbzZFEgw6 u+Np X-TMASE-SNAP-Result: 1.821001.0001-0-1-12:0,22:0,33:0,34:0-0 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_B4DE137BDB63634BAC03BD9DE765F19702B4B3A00AVENUS1inmegat_" --_000_B4DE137BDB63634BAC03BD9DE765F19702B4B3A00AVENUS1inmegat_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hello Dandan: Attached patch resolve the Issue. Can you please provide your comments. Left base folder: E:\Work\NWStack\EDK2Tickets\WifiPassword\MOD Right base folder: E:\Work\NWStack\EDK2Tickets\WifiPassword\ORG *** WifiConnectionMgrHiiConfigAccess.c 2020-08-18 10:21:27.0000= 00000 +05-30 --- WifiConnectionMgrHiiConfigAccess.c 2020-05-07 22:54:46.0= 00000000 +05-30 *************** *** 365,378 **** Hii form. **/ EFI_STATUS WifiMgrRefreshNetworkList ( IN WIFI_MGR_PRIVATE_DATA *Private, ! OUT WIFI_MANAGER_IFR_NVDATA *IfrNvData, ! OUT WIFI_MGR_NETWORK_PROFILE *ProfileData ) { EFI_STATUS Status; EFI_TPL OldTpl; UINT32 AvailableCount; EFI_STRING_ID PortPromptToken; --- 365,377 ---- Hii form. **/ EFI_STATUS WifiMgrRefreshNetworkList ( IN WIFI_MGR_PRIVATE_DATA *Private, ! OUT WIFI_MANAGER_IFR_NVDATA *IfrNvData ) { EFI_STATUS Status; EFI_TPL OldTpl; UINT32 AvailableCount; EFI_STRING_ID PortPromptToken; *************** *** 663,675 **** FreePool (CipherListDisplay); } HiiFreeOpCodeHandle (StartOpCodeHandle); HiiFreeOpCodeHandle (EndOpCodeHandle); - ProfileData->SecurityType=3D Profile->SecurityType; DEBUG ((DEBUG_INFO, "[WiFi Connection Manager] Network List is Refresh= ed!\n")); return Status; } /** Refresh the hidden network list configured by user. --- 662,673 ---- *************** *** 1330,1342 **** EFI_INPUT_KEY Key; UINTN BufferSize; WIFI_MGR_PRIVATE_DATA *Private; WIFI_MANAGER_IFR_NVDATA *IfrNvData; EFI_DEVICE_PATH_PROTOCOL *FilePath; WIFI_MGR_NETWORK_PROFILE *Profile; - WIFI_MGR_NETWORK_PROFILE *ProfileData; WIFI_MGR_NETWORK_PROFILE *ProfileToConnect; WIFI_HIDDEN_NETWORK_DATA *HiddenNetwork; UINTN TempDataSize; VOID *TempData; LIST_ENTRY *Entry; UINT32 Index; --- 1328,1339 ---- *************** *** 1877,1891 **** } else if (Action =3D=3D EFI_BROWSER_ACTION_RETRIEVE) { switch (QuestionId) { case KEY_REFRESH_NETWORK_LIST: ! ProfileData =3D Private->CurrentNic->CurrentOperateNetwork; ! WifiMgrRefreshNetworkList (Private, IfrNvData,ProfileData); ! IfrNvData->SecurityType =3D ProfileData->SecurityType; break; default: break; } } --- 1874,1886 ---- } else if (Action =3D=3D EFI_BROWSER_ACTION_RETRIEVE) { switch (QuestionId) { case KEY_REFRESH_NETWORK_LIST: ! WifiMgrRefreshNetworkList (Private, IfrNvData); break; default: break; } } *** WifiConnectionMgrHiiConfigAccess.h 2020-08-18 10:19:37.0000= 00000 +05-30 --- WifiConnectionMgrHiiConfigAccess.h 2020-05-07 22:54:46.0= 00000000 +05-30 *************** *** 232,242 **** Hii form. **/ EFI_STATUS WifiMgrRefreshNetworkList ( IN WIFI_MGR_PRIVATE_DATA *Private, ! OUT WIFI_MANAGER_IFR_NVDATA *IfrNvData, ! OUT WIFI_MGR_NETWORK_PROFILE *ProfileData ); #endif --- 232,241 ---- Hii form. **/ EFI_STATUS WifiMgrRefreshNetworkList ( IN WIFI_MGR_PRIVATE_DATA *Private, ! OUT WIFI_MANAGER_IFR_NVDATA *IfrNvData ); #endif -Siva From: Bi, Dandan [mailto:dandan.bi@intel.com] Sent: Tuesday, May 19, 2020 2:42 PM To: Sivaraman Nainar; Wu, Jiaxin; Rabeda, Maciej Cc: devel@edk2.groups.io Subject: RE: reg: Wifi Connection Manager Setup Page Issues Hi Could you try to call WifiMgrDxeHiiConfigAccessCallback() in EFI_BROWSER_A= CTION_RETRIEVE? Thanks/Dandan From: Sivaraman Nainar > Sent: Friday, May 15, 2020 7:55 PM To: Wu, Jiaxin >; Rabeda, = Maciej = >; Bi, Dandan > Cc: devel@edk2.groups.io; Sivaraman Nainar > Subject: RE: reg: Wifi Connection Manager Setup Page Issues Hello Jiaxin / Dandan: Could you please provide your comments. -Siva From: devel@edk2.groups.io [mailto:devel@edk2= .groups.io] On Behalf Of Sivaraman Nainar Sent: Friday, May 8, 2020 8:34 AM To: devel@edk2.groups.io Cc: jiaxin.wu@intel.com; Rabeda, Maciej Subject: [edk2-devel] reg: Wifi Connection Manager Setup Page Issues Hello, Getting an issue in Wifi Connection Manager Setup page when UEFI Spec 2.8 = BrowserCallback specific changes integrated in Setup Browser. According to UEFI Spec 2.8, Browser Callback is allowed to call only from = Driver's ConfigAccess protocol and via ConfigAccess->Callback() it allowed = for all type of actions except EFI_BROWSER_ACTION_FORM_OPEN. WifiMgrDxeHiiConfigAccessCallback() is the callback function of WifiConnec= tionMgr. In this callback Security Type IfrData is updated on action EFI_BR= OWSER_ACTION_FORM_OPEN. When the setup browser is not invoking the WifiMgr= DxeHiiConfigAccessCallback in EFI_BROWSER_ACTION_FORM_OPEN action the contr= ol value not updated hence the browser does not show the Security Password = control. The VFR suppress the Password control and shows the control only w= hen SecurityType is SECURITY_TYPE_WPA2_PERSONAL. Would you please feedback how this can be addressed? -Siva This e-mail is intended for the use of the addressee only and may contain = privileged, confidential, or proprietary information that is exempt from di= sclosure under law. If you have received this message in error, please info= rm us promptly by reply e-mail, then delete the e-mail and destroy any prin= ted copy. Thank you. --_000_B4DE137BDB63634BAC03BD9DE765F19702B4B3A00AVENUS1inmegat_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hello Dandan:

Attached patch resolv= e the Issue. Can you please provide your comments.

Left base f= older: E:\Work\NWStack\EDK2Tickets\WifiPassword\MOD

Right base = folder: E:\Work\NWStack\EDK2Tickets\WifiPassword\ORG

*** WifiCon= nectionMgrHiiConfigAccess.c        =     2020-08-18 10:21:27.000000000 +05-30

--- WifiCon= nectionMgrHiiConfigAccess.c        =        2020-05-07 22:54:46.000000000 +05-= 30

***********= ****

*** 365,378= ****

  = ;             &= nbsp;           &nbs= p;       Hii form.

 

  = ;**/

  EFI_= STATUS

  Wifi= MgrRefreshNetworkList (

  = ;  IN    WIFI_MGR_PRIVATE_DATA    &= nbsp; *Private,

! &nbs= p; OUT   WIFI_MANAGER_IFR_NVDATA    *IfrNvData,

! &nbs= p; OUT   WIFI_MGR_NETWORK_PROFILE   *ProfileData

  = ;  )

  {

  = ;  EFI_STATUS         &nb= sp;            =    Status;

  = ;  EFI_TPL          =             &nb= sp;     OldTpl;

  = ;  UINT32          &= nbsp;           &nbs= p;      AvailableCount;

  = ;  EFI_STRING_ID         =              Po= rtPromptToken;

--- 365,377= ----

  = ;            &n= bsp;            = ;        Hii form.

 

  = ;**/

  EFI_= STATUS

  Wifi= MgrRefreshNetworkList (

  = ;  IN    WIFI_MGR_PRIVATE_DATA    &= nbsp; *Private,

! &nbs= p; OUT   WIFI_MANAGER_IFR_NVDATA    *IfrNvData

  = ;  )

  {

  = ;  EFI_STATUS         &nb= sp;            =    Status;

  = ;  EFI_TPL          =             &nb= sp;     OldTpl;

  = ;  UINT32          &= nbsp;           &nbs= p;      AvailableCount;

  = ;  EFI_STRING_ID         =              Po= rtPromptToken;

***********= ****

*** 663,675= ****

  = ;    FreePool (CipherListDisplay);

  = ;  }

 

  = ;  HiiFreeOpCodeHandle (StartOpCodeHandle);

  = ;  HiiFreeOpCodeHandle (EndOpCodeHandle);

 

- &nbs= p; ProfileData->SecurityType=3D Profile->SecurityType;

  = ;  DEBUG ((DEBUG_INFO, "[WiFi Connection Manager] Network List is= Refreshed!\n"));

  = ;  return Status;

  }

 

  = ;/**

  = ;  Refresh the hidden network list configured by user.

--- 662,673= ----

***********= ****

*** 1330,13= 42 ****

  = ;  EFI_INPUT_KEY         =              Ke= y;

  = ;  UINTN          &n= bsp;            = ;       BufferSize;

  = ;  WIFI_MGR_PRIVATE_DATA       &nbs= p;      *Private;

  = ;  WIFI_MANAGER_IFR_NVDATA       &n= bsp;    *IfrNvData;

  = ;  EFI_DEVICE_PATH_PROTOCOL       &= nbsp;   *FilePath;

  = ;  WIFI_MGR_NETWORK_PROFILE       &= nbsp;   *Profile;

- &nbs= p; WIFI_MGR_NETWORK_PROFILE        =             &nb= sp;          *ProfileData;

  = ;  WIFI_MGR_NETWORK_PROFILE       &= nbsp;   *ProfileToConnect;

  = ;  WIFI_HIDDEN_NETWORK_DATA       &= nbsp;   *HiddenNetwork;

  = ;  UINTN          &n= bsp;            = ;       TempDataSize;

  = ;  VOID          &nb= sp;            =         *TempData;

  = ;  LIST_ENTRY         &nb= sp;            =    *Entry;

  = ;  UINT32          &= nbsp;           &nbs= p;      Index;

--- 1328,13= 39 ----

***********= ****

*** 1877,18= 91 ****

  = ;  } else if (Action =3D=3D EFI_BROWSER_ACTION_RETRIEVE) {<= /span>

 

  = ;    switch (QuestionId) {

 

  = ;    case KEY_REFRESH_NETWORK_LIST:

 

! &nbs= p;      ProfileData =3D Private->CurrentNic->= ;CurrentOperateNetwork;

! &nbs= p;      WifiMgrRefreshNetworkList (Private, IfrNvD= ata,ProfileData);

! &nbs= p;      IfrNvData->SecurityType =3D ProfileData= ->SecurityType;

  = ;      break;

 

  = ;    default:

  = ;      break;

  = ;    }

  = ;  }

--- 1874,18= 86 ----

  = ;  } else if (Action =3D=3D EFI_BROWSER_ACTION_RETRIEVE) {<= /span>

 

  = ;    switch (QuestionId) {

 

  = ;    case KEY_REFRESH_NETWORK_LIST:

 

! &nbs= p;     WifiMgrRefreshNetworkList (Private, IfrNvData);<= o:p>

  = ;      break;

 

  = ;    default:

  = ;      break;

  = ;    }

  = ;  }

*** WifiCon= nectionMgrHiiConfigAccess.h        =     2020-08-18 10:19:37.000000000 +05-30

--- WifiCon= nectionMgrHiiConfigAccess.h        =        2020-05-07 22:54:46.000000000 +05-= 30

***********= ****

*** 232,242= ****

  = ;            &n= bsp;            = ;         Hii form.

 

  = ;**/

  EFI_= STATUS

  Wifi= MgrRefreshNetworkList (

  = ;  IN    WIFI_MGR_PRIVATE_DATA    &= nbsp;   *Private,

! &nbs= p; OUT   WIFI_MANAGER_IFR_NVDATA      *I= frNvData,

! &nbs= p; OUT   WIFI_MGR_NETWORK_PROFILE     *Profil= eData

  = ;  );

 

  = ;#endif

--- 232,241= ----

  = ;            &n= bsp;            = ;         Hii form.

 

  = ;**/

  EFI_= STATUS

  Wifi= MgrRefreshNetworkList (

  = ;  IN    WIFI_MGR_PRIVATE_DATA    &= nbsp;   *Private,

! &nbs= p; OUT   WIFI_MANAGER_IFR_NVDATA      *I= frNvData

  = ;  );

 

  = ;#endif

 

 

-Siva

From: Bi, Dandan [mailto:dandan.bi@intel.com]
Sent: Tuesday, May 19, 2020 2:42 PM
To: Sivaraman Nainar; Wu, Jiaxin; Rabeda, Maciej
Cc: devel@edk2.groups.io
Subject: RE: reg: Wifi Connection Manager Setup Page Issues

 

Hi

Could you try to call WifiMgrDxeHiiConfigAccessCall= back() in EFI_BROWSER_ACTION_RETRIEVE?

 

Thanks/Dandan

From: Sivaraman Nainar <sivaramann@amiindia.co.in>
Sent: Friday, May 15, 2020 7:55 PM
To: Wu, Jiaxin <jiaxin.wu= @intel.com>; Rabeda, Maciej <maciej.rabeda@linux.intel.com>; Bi, Dandan <dandan.bi@intel.com>
Cc: devel@edk2.groups.io; Sivaraman Nainar <sivara= mann@amiindia.co.in>
Subject: RE: reg: Wifi Connection Manager Setup Page Issues

 

Hello Jiaxin / Dandan= :

Could you please prov= ide your comments.

-Siva

 

Hello,

Getting an issue in Wifi Connection Manager Setup p= age when UEFI Spec 2.8 BrowserCallback specific changes integrated in Setup= Browser.

According to UEFI Spec 2.8, Browser Callback is all= owed to call only from Driver's ConfigAccess protocol and via ConfigAccess-= >Callback() it allowed for all type of actions except EFI_BROWSER_ACTION= _FORM_OPEN.

WifiMgrDxeHiiConfigAccessCallback() is the callback= function of WifiConnectionMgr. In this callback Security Type IfrData is u= pdated on action EFI_BROWSER_ACTION_FORM_OPEN.  When the setup browser= is not invoking the WifiMgrDxeHiiConfigAccessCallback in EFI_BROWSER_ACTION_FORM_OPEN action the control value not updated henc= e the browser does not show the Security Password control. The VFR suppress= the Password control and shows the control only when SecurityType is SECURITY_TYPE_WPA2_PERSONAL.

Would you please feedback how this can be addressed?

-Siva

This e-mail is intended for the use of the addressee only = and may contain privileged, confidential, or proprietary information that i= s exempt from disclosure under law. If you have received this message in error, please inform us promptly by reply e-mail, then de= lete the e-mail and destroy any printed copy. Thank you.

--_000_B4DE137BDB63634BAC03BD9DE765F19702B4B3A00AVENUS1inmegat_--