public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* reg: [edk2-devel] [PATCH] Adding the MAC in the HTTP Boot Title
@ 2020-12-09  6:36 Sivaraman Nainar
  2020-12-09 16:01 ` Maciej Rabeda
  0 siblings, 1 reply; 2+ messages in thread
From: Sivaraman Nainar @ 2020-12-09  6:36 UTC (permalink / raw)
  To: devel@edk2.groups.io, Rabeda, Maciej

[-- Attachment #1: Type: text/plain, Size: 1106 bytes --]

Hello all:

Here with added the patch for displaying the MAC Address along with the HTTP Boot Option Title. Please review and comment.

---
 NetworkPkg/HttpBootDxe/HttpBootConfig.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/NetworkPkg/HttpBootDxe/HttpBootConfig.c b/NetworkPkg/HttpBootDxe/HttpBootConfig.c
index 646c907b12..677d913a09 100644
--- a/NetworkPkg/HttpBootDxe/HttpBootConfig.c
+++ b/NetworkPkg/HttpBootDxe/HttpBootConfig.c
@@ -629,6 +629,18 @@ HttpBootConfigFormInit (
       NULL
       );

+    OldMenuString = HiiGetString (
+                          CallbackInfo->RegisteredHandle,
+                          STRING_TOKEN (STR_HTTP_BOOT_CONFIG_FORM_TITLE),
+                          NULL
+                          );
+        UnicodeSPrint (MenuString, 128, L"MAC:%s-%s", MacString,OldMenuString);
+        HiiSetString (
+          CallbackInfo->RegisteredHandle,
+          STRING_TOKEN (STR_HTTP_BOOT_CONFIG_FORM_TITLE),
+          MenuString,
+          NULL
+          );
     FreePool (MacString);
     FreePool (OldMenuString);

[-- Attachment #2: Type: text/html, Size: 4752 bytes --]

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: reg: [edk2-devel] [PATCH] Adding the MAC in the HTTP Boot Title
  2020-12-09  6:36 reg: [edk2-devel] [PATCH] Adding the MAC in the HTTP Boot Title Sivaraman Nainar
@ 2020-12-09 16:01 ` Maciej Rabeda
  0 siblings, 0 replies; 2+ messages in thread
From: Maciej Rabeda @ 2020-12-09 16:01 UTC (permalink / raw)
  To: Sivaraman Nainar, devel@edk2.groups.io

[-- Attachment #1: Type: text/plain, Size: 1403 bytes --]

Please provide a patch in the way described in the process.
Formal: 
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process
Informal: 
https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers

Thanks,
Maciej

On 09-Dec-20 07:36, Sivaraman Nainar wrote:
>
> Hello all:
>
> Here with added the patch for displaying the MAC Address along with 
> the HTTP Boot Option Title. Please review and comment.
>
> ---
>  NetworkPkg/HttpBootDxe/HttpBootConfig.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/NetworkPkg/HttpBootDxe/HttpBootConfig.c 
> b/NetworkPkg/HttpBootDxe/HttpBootConfig.c
> index 646c907b12..677d913a09 100644
> --- a/NetworkPkg/HttpBootDxe/HttpBootConfig.c
> +++ b/NetworkPkg/HttpBootDxe/HttpBootConfig.c
> @@ -629,6 +629,18 @@ HttpBootConfigFormInit (
>        NULL
>        );
>
> +    OldMenuString = HiiGetString (
> + CallbackInfo->RegisteredHandle,
> + STRING_TOKEN (STR_HTTP_BOOT_CONFIG_FORM_TITLE),
> + NULL
> +                          );
> +        UnicodeSPrint (MenuString, 128, L"MAC:%s-%s", 
> MacString,OldMenuString);
> +        HiiSetString (
> + CallbackInfo->RegisteredHandle,
> +          STRING_TOKEN (STR_HTTP_BOOT_CONFIG_FORM_TITLE),
> +          MenuString,
> +          NULL
> +          );
>      FreePool (MacString);
>      FreePool (OldMenuString);
>


[-- Attachment #2: Type: text/html, Size: 5312 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-12-09 16:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-09  6:36 reg: [edk2-devel] [PATCH] Adding the MAC in the HTTP Boot Title Sivaraman Nainar
2020-12-09 16:01 ` Maciej Rabeda

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox