From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Vivek Kumar Gautam <Vivek.Gautam@arm.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "ardb+tianocore@kernel.org" <ardb+tianocore@kernel.org>,
Pierre Gondois <Pierre.Gondois@arm.com>, nd <nd@arm.com>
Subject: Re: [edk2-platforms][PATCH V1 1/1] Revert "Platform/Sgi: Fix missing FdtLib instance issue"
Date: Wed, 11 Jan 2023 10:33:45 +0000 [thread overview]
Message-ID: <B53A7F1F-31CD-438A-8F44-95F97D80D13B@arm.com> (raw)
In-Reply-To: <20230111101342.3936253-1-vivek.gautam@arm.com>
Hi Vivek,
Thank you for this fix.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
On 11/01/2023, 10:13, "Vivek Gautam" <vivek.gautam@arm.com> wrote:
This reverts commit eb3950b842d3f335671600fdfa9b58c482886c79.
This commit referenced the change (9ad168c9e0 StandaloneMmPkg:
Include libfdt in the StMM) in edk2 as the dependency to add FdtLib
instance. However, as this change is not yet upstreamed, it was
incorrect to introduce this dependency and refer to the change in
the commit message. So reverting this patch.
Signed-off-by: Vivek Gautam <vivek.gautam@arm.com>
---
Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc | 1 -
1 file changed, 1 deletion(-)
Apologies, this was a mistake on my part. I used a bunch of commits
on edk2 that were not upstreamed and based the patch on them. This
led me to believe that there is a build break and so posted the
commit eb3950b842d3f335671600fdfa9b58c482886c79 for review.
diff --git a/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc b/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc
index 01f0a7657c51..ae0ff7247a6a 100644
--- a/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc
+++ b/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc
@@ -38,7 +38,6 @@
ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf
StandaloneMmMmuLib|ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf
ArmSvcLib|ArmPkg/Library/ArmSvcLib/ArmSvcLib.inf
- FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf
CacheMaintenanceLib|ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheMaintenanceLib.inf
PeCoffExtraActionLib|StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/StandaloneMmPeCoffExtraActionLib.inf
--
2.25.1
next prev parent reply other threads:[~2023-01-11 10:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 10:13 [edk2-platforms][PATCH V1 1/1] Revert "Platform/Sgi: Fix missing FdtLib instance issue" Vivek Kumar Gautam
2023-01-11 10:33 ` Sami Mujawar [this message]
2023-01-11 11:19 ` Vivek Kumar Gautam
2023-04-27 11:35 ` [edk2-devel] " Sami Mujawar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B53A7F1F-31CD-438A-8F44-95F97D80D13B@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox