From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-in25.apple.com (mail-out25.apple.com [17.171.2.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1479220945B75 for ; Thu, 21 Sep 2017 12:12:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; d=apple.com; s=mailout2048s; c=relaxed/simple; q=dns/txt; i=@apple.com; t=1506021327; h=From:Sender:Reply-To:Subject:Date:Message-id:To:Cc:MIME-version:Content-type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-reply-to:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=1REFUUd8iHNh3cxmQn4JYk7ep/g8M0crIdsTxzikQ+8=; b=CuJ/U/70z3u/7htZCm0A8omYRaEaK0NsOr8MoFCnkLq1+lLbxnR1ZQWqcy4yHaPL oz4ZlTH01eGwGUFEoK8CSPTtUG0/gi8aW54HOmxpd2LCjJ2w1coopmS3AmGuCGiD tAKJspSJ8FQQP5RlxfHzVnUvyEfEz5A7xpc8q0lBa5aWOu7qyyz5PNEDLSuPULi7 +xxVmJ1GOV7unPXQpW1rCes5bmKoDE+cHNH5CubO5tkfhGwdJZyIpi4OrvZEX8SB gRYeRXPUYuQOhwJ9/0NR2yZgGfDqdiYO4LJZBTpuHHhWY+zoV44mbm31vJcULqTW DGjiu34DJbHwTfJn+PGc8g==; Received: from relay22.apple.com (relay22.apple.com [17.171.128.103]) (using TLS with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mail-in25.apple.com (Apple Secure Mail Relay) with SMTP id AE.62.05744.FCF04C95; Thu, 21 Sep 2017 12:15:27 -0700 (PDT) X-AuditID: 11ab0219-8e5ff70000001670-cc-59c40fcf537b Received: from ma1-mmpp-sz11.apple.com (ma1-mmpp-sz11.apple.com [17.171.128.33]) by relay22.apple.com (Apple SCV relay) with SMTP id 8C.8D.07334.FCF04C95; Thu, 21 Sep 2017 12:15:27 -0700 (PDT) MIME-version: 1.0 Received: from [17.234.203.71] by ma1-mmpp-sz11.apple.com (Oracle Communications Messaging Server 8.0.1.3.20170825 64bit (built Aug 25 2017)) with ESMTPSA id <0OWN004WQ9HONZB0@ma1-mmpp-sz11.apple.com>; Thu, 21 Sep 2017 12:15:27 -0700 (PDT) Sender: afish@apple.com From: Andrew Fish Message-id: Date: Thu, 21 Sep 2017 12:15:23 -0700 In-reply-to: Cc: Leif Lindholm , nd , Ard Biesheuvel , "edk2-devel@lists.01.org" , Thomas Panakamattam Abraham , Arvind Chauhan To: Evan Lloyd References: <20170921162345.11724-1-evan.lloyd@arm.com> <20170921175602.2rjg3osgzll5dlhr@bivouac.eciton.net> X-Mailer: Apple Mail (2.3273) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrKLMWRmVeSWpSXmKPExsUiuLohXfc8/5FIgxuXRSz+f9jNaPG6ezar xZ5DR5kteloELD7t3sNicWZ5D7PF1/5PTA7sHmvmrWH0uHNtD5tH9+x/LAHMUVw2Kak5mWWp Rfp2CVwZN1YsZC940MtYMe1cL3sD47qaLkZODgkBE4mtV1tYuxi5OIQE1jNJ9H/8wwqTeH/9 OTtE4hCjxKPeDiaQBK+AoMSPyfdYQGxmgTCJ/wvXMEIUfWWUmPzwARtIQlhAXOLdmU3MIDab gLLEivkf2CGabSQmblzGDlHjJbHhbx/YIBYBVYmXJ2aBxTkFkiUObjzOAjKUWaCVSeLv/Qaw zSJAg6au+QR10lFGiT9Ht7NB3CorcWv2JWaQhITAGTaJDw8es09gFJqF5NxZSM6FsLUkvj9q BYpzANnyEgfPy0KENSWe3fvEDmFrSzx5d4F1ASPbKkbh3MTMHN3MPCNTvcSCgpxUveT83E2M 4HhiktzB+PW14SFGAQ5GJR5eg4OHI4VYE8uKK3MPMUpzsCiJ8+7/dzBSSCA9sSQ1OzW1ILUo vqg0J7X4ECMTB6dUA+NpsZtLOqzvlYU931UReudpUMO0u/bHVkj+U5MIzuqb5Mb+JD0uv+6u zsnjgp3Nm+7dP5Dv9UJj3qHAfpGOnc7Jr88fuDtnxhfJKsn4iumhYZ0TT0UbFE989aFwZ/JH u++9YSY8iuETLt4X3hseGckhlFDy2tEp/EX+iebZn2IOKOiKT7i7570SS3FGoqEWc1FxIgBg IYhLiAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrBLMWRmVeSWpSXmKPExsUiuLpBUfc8/5FIg6m9/Bb/P+xmtHjdPZvV Ys+ho8wWPS0CFp9272GxOLO8h9nia/8nJgd2jzXz1jB63Lm2h82je/Y/lgDmKC6blNSczLLU In27BK6MGysWshc86GWsmHaul72BcV1NFyMnh4SAicT768/Zuxi5OIQEDjFKPOrtYAJJ8AoI SvyYfI8FxGYWCJP4v3ANI0TRV0aJyQ8fsIEkhAXEJd6d2cQMYrMJKEusmP+BHaLZRmLixmXs EDVeEhv+9oENYhFQlXh5YhZYnFMgWeLgxuMsIEOZBVqZJP7ebwDbLAI0aOqaT1AnHWWU+HN0 OxvErbISt2ZfYp7AyD8LyYWzkFwIYWtJfH/UChTnALLlJQ6el4UIa0o8u/eJHcLWlnjy7gLr Aka2VYyCRak5iZVGRnqJBQU5qXrJ+bmbGCHhn76D8chNs0OMAhyMSjy8N/YdjhRiTSwrrswF hhMHs5II70SGI5FCvCmJlVWpRfnxRaU5qcWHGKU5WJTEeYVnHowUEkhPLEnNTk0tSC2CyTJx cEo1MDIed+hf9HNJ3bm2FX2dL5QPBF7/9KdF9/FURaW3+d//p/zPWv/hkV3w6e0lJSL913Z5 mAr/d534voqJafHUnObFotMqtj4/fuyycv6WDO19afvWfreIbNl/+u35pfMlzu3w267itHD+ jsKo6L9+9cJL895smvphzfxnfvuOxO6YcK6tIMxOcdJhJZbijERDLeai4kQAM5R0IHsCAAA= X-Content-Filtered-By: Mailman/MimeDel 2.1.22 Subject: Re: [PATCH 0/4] [PATCH 0/5] Add HardwareInterrupt2 for ARM X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Sep 2017 19:12:21 -0000 Content-Type: text/plain; CHARSET=US-ASCII Content-Transfer-Encoding: 7BIT > On Sep 21, 2017, at 11:39 AM, Evan Lloyd wrote: > > > >> -----Original Message----- >> From: Leif Lindholm [mailto:leif.lindholm@linaro.org ] >> Sent: 21 September 2017 18:56 >> To: Evan Lloyd > >> Cc: edk2-devel@lists.01.org ; Ard Biesheuvel >; >> Matteo Carlini >; nd >; Arvind >> Chauhan >; Daniil Egranov >> >; Thomas Panakamattam Abraham >> > >> Subject: Re: [PATCH 0/4] [PATCH 0/5] Add HardwareInterrupt2 for ARM >> >> On Thu, Sep 21, 2017 at 05:23:40PM +0100, evan.lloyd@arm.com wrote: >>> From: EvanLloyd >>> >>> This v4 series of patches corrects a problem detected on the ARM Juno >>> platform that is actually generic (at least to ARM GIC platforms). >>> The HardwareInterrupt protocol had no means of handling >>> characteristics like Edge/Level triggered and polarity. >>> >>> A new HardwareInterrupt2 protocol (provided by Ard) is added, and code >>> changed to utilise the new capabilities. >>> >>> The code is available for examination on Github at: >>> https://github.com/EvanLloyd/tianocore/tree/376_irqtype_v4 >>> >>> v4 responds to further comments from maintainers, being mainly >>> cosmetic changes. >>> >>> Note: Significant defects exist in the (original) Watchdog handling, >>> and a new patch will follow. >> >> If you let me move that | before pushing, I'm happy with this set. > > [[Evan Lloyd]] Very well, if you really feel that strongly. > How come you have a code style rooted in the 1960s before you were born, while I've move forward to at least the 1990s. Shouldn't I be the surly, hide-bound, old, luddite dinosaur? > Yikes. There is actually no scientific data that one coding standard is better than another. The data does show having a consistent coding style is what has value. I wrote the original coding standard a long time ago.... I remember I was a 4 space indent person, and as a compromise we moved to 2 space indent. It drove me crazy for about 2 weeks and then my brain flipped over and now I prefer 2 spaces, and 4 spaces look strange. Same kind of thing happened when Apple flipped the scroll direction. Folks went crazy, but after a while your brain gets accustomed to the new normal. Thanks, Andrew Fish >> >> Arvind, Daniil, Thomas - any comments? >> >> / >> Leif >> >>> Ard Biesheuvel (3): >>> EmbeddedPkg: Introduce HardwareInterrupt2 protocol >>> ArmPkg/ArmGicDxe: Expose HardwareInterrupt2 protocol >>> ArmPkg/GenericWatchdogDxe: Set Watchdog interrupt type >>> >>> Evan Lloyd (1): >>> ArmPkg: Tidy GIC code before changes. >>> >>> EmbeddedPkg/EmbeddedPkg.dec | 1 + >>> ArmPkg/Drivers/ArmGic/ArmGicDxe.inf | 3 +- >>> ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf | 6 +- >>> ArmPkg/Drivers/ArmGic/ArmGicDxe.h | 31 ++- >>> ArmPkg/Include/Library/ArmGicLib.h | 34 +-- >>> EmbeddedPkg/Include/Protocol/HardwareInterrupt2.h | 182 >> ++++++++++++++++ >>> ArmPkg/Drivers/ArmGic/ArmGicCommonDxe.c | 76 +++++-- >>> ArmPkg/Drivers/ArmGic/ArmGicLib.c | 73 +++++-- >>> ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c | 195 >> ++++++++++++++--- >>> ArmPkg/Drivers/ArmGic/GicV3/ArmGicV3Dxe.c | 218 >> +++++++++++++++++--- >>> ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.c | 146 >> +++++++------ >>> 11 files changed, 779 insertions(+), 186 deletions(-) create mode >>> 100644 EmbeddedPkg/Include/Protocol/HardwareInterrupt2.h >>> >>> -- >>> Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") >>> > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel