Re: [edk2-devel][edk2-staging/EdkRepo][PATCH] EdkRepo: Support uninstalling packages with '_' in their name.

["Nate DeSimone" <nathaniel.l.desimone@intel.com>]

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

On 11/13/19, 3:10 PM, "Desimone, Ashley E" <ashley.e.desimone@intel.com> wrote:

    pip does not support '_' in package names and converts them to
    '-' after installing the wheel. In order to uninstall affected
    packages the '_' needs to be converted to a '-' when calculating
    the package name.
    
    Signed-off-by: Ashley E Desimone <ashley.e.desimone@intel.com>
    Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
    Cc: Puja Pandya <puja.pandya@intel.com>
    ---
     edkrepo_installer/EdkRepoInstaller/InstallWorker.cs | 5 ++++-
     1 file changed, 4 insertions(+), 1 deletion(-)
    
    diff --git a/edkrepo_installer/EdkRepoInstaller/InstallWorker.cs b/edkrepo_installer/EdkRepoInstaller/InstallWorker.cs
    index effc3c4..5a358f9 100644
    --- a/edkrepo_installer/EdkRepoInstaller/InstallWorker.cs
    +++ b/edkrepo_installer/EdkRepoInstaller/InstallWorker.cs
    @@ -622,7 +622,10 @@ namespace TianoCore.EdkRepoInstaller
                     {
                         if (Wheel.UninstallAllOtherCopies)
                         {
    -                        ExclusivePackages.Add(new Tuple<string, PythonVersion>(Wheel.Package.Name, PyInstance.Version));
    +                        //
    +                        // pip doesn't understand the difference between '_' and '-'
    +                        //
    +                        ExclusivePackages.Add(new Tuple<string, PythonVersion>(Wheel.Package.Name.Replace('_', '-'), PyInstance.Version));
                         }
                     }
                 }
    -- 
    2.16.2.windows.1