From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from rn-mailsvcp-ppex-lapp15.apple.com (rn-mailsvcp-ppex-lapp15.apple.com [17.179.253.34]) by mx.groups.io with SMTP id smtpd.web12.468.1636481618757383085 for ; Tue, 09 Nov 2021 10:13:38 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@apple.com header.s=20180706 header.b=hIi2IVVi; spf=pass (domain: apple.com, ip: 17.179.253.34, mailfrom: afish@apple.com) Received: from pps.filterd (rn-mailsvcp-ppex-lapp15.rno.apple.com [127.0.0.1]) by rn-mailsvcp-ppex-lapp15.rno.apple.com (8.16.1.2/8.16.1.2) with SMTP id 1A9I8nvc032233; Tue, 9 Nov 2021 10:13:36 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=apple.com; h=from : message-id : content-type : mime-version : subject : date : in-reply-to : cc : to : references; s=20180706; bh=sImYBcoukDHrET5XxsjuoKaOv+QZTy/htvU234n1Eic=; b=hIi2IVViPotz7hs4WKHQz+tABAeOF59QbxAN9UvQss6HC5yt3rrZM4aJ/Sx9hEetWV5T WCTql1zvWy/tN+Hc7hfjZGyM6o7hS5AExBNy+PGixEsiqlKD+rD3Xc9tgJcQD7KVI8EM PumckMLzWbxJH41imy6Tsc8U3Wifyuzonm0xKUjc3X0hTQEko3jCe2lFgI2PDBfZ4ABE HWNUJSiEay1g9KMT0M0g7QHBsZ5EzqqAVa/c5I0Z36j38I29tDlyX/VQOMeo1DCKSiDK fn96nmi7CFaa2aebZH5J95H9liBMwOxOEKfC5JH6EwzbecQRs4LWPD114Npbwb14bIT6 /g== Received: from rn-mailsvcp-mta-lapp01.rno.apple.com (rn-mailsvcp-mta-lapp01.rno.apple.com [10.225.203.149]) by rn-mailsvcp-ppex-lapp15.rno.apple.com with ESMTP id 3c5q9crp1g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Tue, 09 Nov 2021 10:13:36 -0800 Received: from rn-mailsvcp-mmp-lapp03.rno.apple.com (rn-mailsvcp-mmp-lapp03.rno.apple.com [17.179.253.16]) by rn-mailsvcp-mta-lapp01.rno.apple.com (Oracle Communications Messaging Server 8.1.0.12.20210903 64bit (built Sep 3 2021)) with ESMTPS id <0R2B00CM6HAK64I0@rn-mailsvcp-mta-lapp01.rno.apple.com>; Tue, 09 Nov 2021 10:13:32 -0800 (PST) Received: from process_milters-daemon.rn-mailsvcp-mmp-lapp03.rno.apple.com by rn-mailsvcp-mmp-lapp03.rno.apple.com (Oracle Communications Messaging Server 8.1.0.12.20210903 64bit (built Sep 3 2021)) id <0R2B00I00H2Y0V00@rn-mailsvcp-mmp-lapp03.rno.apple.com>; Tue, 09 Nov 2021 10:13:32 -0800 (PST) X-Va-A: X-Va-T-CD: 70a38c3f5b1d46c4b8dccb3b011be358 X-Va-E-CD: 574fda742400e238a02c5048d028c5dd X-Va-R-CD: b4e96f8f3d52136df210f2e6a101920e X-Va-CD: 0 X-Va-ID: 1a502da2-b92a-4124-8d56-980e711d3657 X-V-A: X-V-T-CD: 70a38c3f5b1d46c4b8dccb3b011be358 X-V-E-CD: 574fda742400e238a02c5048d028c5dd X-V-R-CD: b4e96f8f3d52136df210f2e6a101920e X-V-CD: 0 X-V-ID: 31261bf5-fea1-4f6d-aefd-12e8ffde633b X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.790 definitions=2021-11-09_04:2021-11-08,2021-11-09 signatures=0 Received: from smtpclient.apple (unknown [17.235.8.214]) by rn-mailsvcp-mmp-lapp03.rno.apple.com (Oracle Communications Messaging Server 8.1.0.12.20210903 64bit (built Sep 3 2021)) with ESMTPSA id <0R2B00CBOHAJ7C00@rn-mailsvcp-mmp-lapp03.rno.apple.com>; Tue, 09 Nov 2021 10:13:32 -0800 (PST) From: "Andrew Fish" Message-id: MIME-version: 1.0 (Mac OS X Mail 15.0 \(3693.20.0.1.32\)) Subject: Re: [edk2-devel] Progress on getting Uncrustify working for EDK2? Date: Tue, 09 Nov 2021 10:13:30 -0800 In-reply-to: Cc: Leif Lindholm , Gerd Hoffmann , =?utf-8?Q?Marvin_H=C3=A4user?= , Michael Kubacki , "mikuback@linux.microsoft.com" , "rebecca@nuviainc.com" , Bret Barkelew To: edk2-devel-groups-io , Mike Kinney References: <2679bfa3-b4ec-d8e9-7e56-54ebe42d9001@posteo.de> <9fe0f984-db9d-9aec-0b44-5d30791a2855@linux.microsoft.com> <20211007104813.wa4rmfsqgcpvnzwt@leviathan> <07d5c8bc-40b2-4e99-3b3d-4c8ac4e14220@posteo.de> <438B4D66-2CFB-45E3-AF75-42342F0B1E67@apple.com> <20211109084002.wywzc5cnwhhlzktc@sirius.home.kraxel.org> <20211109123630.j7ropheao337m7rf@leviathan> X-Mailer: Apple Mail (2.3693.20.0.1.32) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.790 definitions=2021-11-09_05:2021-11-08,2021-11-09 signatures=0 Content-type: multipart/alternative; boundary="Apple-Mail=_03DC7C1F-670F-4885-90DE-E5E1C71BBD4B" --Apple-Mail=_03DC7C1F-670F-4885-90DE-E5E1C71BBD4B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Mike, My main concern is there is an easy path for the developers. I don=E2=80=99= t want to have developers have to learn new development technologies just t= o run a =E2=80=9Crequired=E2=80=9D tool. I=E2=80=99m not as concerned on ho= w we do it. Hosting binaries from a webpage that auto picks what to downloa= d would be fine with me.=20 I think the important thing is we make this walkup an use, and we write up = the instructions not assuming =E2=80=9Cother knowledge=E2=80=9D.=20 My use case is probably uncommon. We don=E2=80=99t use brew, but there is a= n internal brew we can use. So we generally just install build tools into o= ur repo. We are more flexible on personal productivity tools so I=E2=80=99= d probably consider switching to Visual Studio Code, especially if there wa= s an Extension in the Marketplace I could just click on to configure Code f= or edk2 development. On the other hand nothing inspires hate like asking pe= ople to switch their editor, so I don=E2=80=99t think we can depend on Code= as the solution.=20 Thanks, Andrew Fish > On Nov 9, 2021, at 7:08 AM, Michael D Kinney = wrote: >=20 > Submodule within which repo? What would be the proposed location? >=20 > Would a fork of uncrustify maintained as a repo under TianoCore work as w= ell? >=20 > There are CI checks (including extensive unit tests) and release generati= on that are built into uncrustify repo and I do not know if those will be f= unctional if it is maintained as a submodule. >=20 > Thanks, >=20 > Mike >=20 >> -----Original Message----- >> From: Leif Lindholm > >> Sent: Tuesday, November 9, 2021 4:37 AM >> To: Gerd Hoffmann > >> Cc: devel@edk2.groups.io ; Kinney, Michael = D >; Andrew = Fish >; Marvin H=C3=A4user >> >; Michael Kubacki >; mikuback@= linux.microsoft.com ; rebecca@nuviainc= .com ; >> Bret Barkelew > >> Subject: Re: [edk2-devel] Progress on getting Uncrustify working for EDK= 2? >>=20 >> On Tue, Nov 09, 2021 at 09:40:02 +0100, Gerd Hoffmann wrote: >>> Hi, >>>=20 >>>> 3. Require use of uncrustify tool before submitting patch review ema= ils or PRs. >>>> * The required version would be a formally released version fro= m the fork maintained by Michael Kubacki until >> the changes can be upstreamed. >>>> * https://dev.azure.com/projectmu/Uncrustify >>>=20 >>> Can we please *first* get the changes merged to upstream uncrustify? >>>=20 >>> That'll make the whole process much less painful because the usual >>> software repositories (linux distro packages, macos homebrew, ...) >>> can be used to install uncrustify then, and it's also less confusing if >>> developers don't have to juggle with different uncrustify variants >>> (upstream vs. edk2). >>=20 >> Whilst I agree in principle... >>=20 >> This means postponing automated coding style changes until 2023 >> (Debian stable), 2025 (Ubuntu LTS), ??? (RHEL10), or even later >> ... and I'd rather not. >>=20 >> I like Marvin's suggestion of a submodule. Which we could drop once >> no longer needed. >>=20 >> / >> Leif >=20 >=20 >=20 --Apple-Mail=_03DC7C1F-670F-4885-90DE-E5E1C71BBD4B Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 Mike,

My main concern is there is an easy path fo= r the developers. I don=E2=80=99t want to have developers have to learn new= development technologies just to run a =E2=80=9Crequired=E2=80=9D tool. I= =E2=80=99m not as concerned on how we do it. Hosting binaries from a webpag= e that auto picks what to download would be fine with me. 

I think the important thing = is we make this walkup an use, and we write up the instructions not assumin= g =E2=80=9Cother knowledge=E2=80=9D. 

My use case is probably uncommon. We don=E2=80= =99t use brew, but there is an internal brew we can use. So we generally ju= st install build tools into our repo. We  are more flexible on persona= l productivity tools so I=E2=80=99d probably consider switching to Visual S= tudio Code, especially if there was an Extension in the Marketplace I could= just click on to configure Code for edk2 development. On the other hand no= thing inspires hate like asking people to switch their editor, so I don=E2= =80=99t think we can depend on Code as the solution. 

Thanks,
Andrew Fish

On Nov 9, 2021, = at 7:08 AM, Michael D Kinney <michael.d.kinney@intel.com> wrote:

Submodule within which repo?  What would be the proposed loc= ation?

Would a fork of uncrustify maintained as a repo unde= r TianoCore work as well?

There are CI checks (including ex= tensive unit tests) and release generation that are built into uncrustify r= epo and I do not know if those will be functional if it is maintained as a = submodule.

Thanks,

Mike

-----Original Message-----
From: Leif Lindholm <= ;leif@nuviainc.com><= br class=3D"">Sent: Tuesday, November 9, 2021 4:37 AM
To: Ger= d Hoffmann <kraxel@redha= t.com>
Cc: = devel@edk2.groups= .io; Kinney, Michael D <michael.d.kinney@intel.com>; Andrew Fish <afish@apple.com>; Marvin H=C3=A4= user
<mha= euser@posteo.de>; Michael Kubacki <Michael.Kubacki@microsoft.com>; mikuback@linux.microsoft.com; rebecca@nuviainc.com;
Bret Barkelew <Bret.Barkelew@microso= ft.com>
Subject: Re: [edk2-devel] Progress on getting = Uncrustify working for EDK2?

On Tue, Nov 09, 2= 021 at 09:40:02 +0100, Gerd Hoffmann wrote:
 Hi,

 3.  Require use of uncrustify tool before = submitting patch review emails or PRs.
   &nbs= p;*   The required version would be a formally released version &= nbsp;from the fork maintained by Michael Kubacki until
the changes can be upstreamed.
  = ;  *   https://dev.azure.com/projectmu/Uncrustify

Can we please *first* get the changes mer= ged to upstream uncrustify?

That'll make the w= hole process much less painful because the usual
software rep= ositories (linux distro packages, macos homebrew, ...)
can be= used to install uncrustify then, and it's also less confusing if
developers don't have to juggle with different uncrustify variants(upstream vs. edk2).

= Whilst I agree in principle...

This means post= poning automated coding style changes until 2023
(Debian stab= le), 2025 (Ubuntu LTS), ??? (RHEL10), or even later
... and I= 'd rather not.

I like Marvin's suggestion of a= submodule. Which we could drop once
no longer needed.

/
   Leif



--Apple-Mail=_03DC7C1F-670F-4885-90DE-E5E1C71BBD4B--