From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 370CF1A1E3E for ; Thu, 29 Sep 2016 18:41:23 -0700 (PDT) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP; 29 Sep 2016 18:41:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,417,1473145200"; d="scan'208";a="15250681" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga004.jf.intel.com with ESMTP; 29 Sep 2016 18:41:22 -0700 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 29 Sep 2016 18:41:22 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 29 Sep 2016 18:41:22 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.101]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.118]) with mapi id 14.03.0248.002; Fri, 30 Sep 2016 09:41:19 +0800 From: "Wu, Hao A" To: "Gao, Liming" , "edk2-devel@lists.01.org" Thread-Topic: [Patch] BaseTools Build: Fix build break for clean target in Linux Thread-Index: AQHSGmCHsSRH7r4MBk+ZwuS+I2FxXKCRQggQ Date: Fri, 30 Sep 2016 01:41:20 +0000 Message-ID: References: <1475160458-16540-1-git-send-email-liming.gao@intel.com> In-Reply-To: <1475160458-16540-1-git-send-email-liming.gao@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] BaseTools Build: Fix build break for clean target in Linux X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Sep 2016 01:41:23 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The patch is good to me. Reviewed-by: Hao Wu Best Regards, Hao Wu > -----Original Message----- > From: Gao, Liming > Sent: Thursday, September 29, 2016 10:48 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A > Subject: [Patch] BaseTools Build: Fix build break for clean target in Lin= ux >=20 > From: Hao Wu >=20 > In Linux, Command needs to be String instead of list when Command run > as shell with True. >=20 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Liming Gao > --- > BaseTools/Source/Python/build/build.py | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/BaseTools/Source/Python/build/build.py > b/BaseTools/Source/Python/build/build.py > index b003c67..f17b55c 100644 > --- a/BaseTools/Source/Python/build/build.py > +++ b/BaseTools/Source/Python/build/build.py > @@ -265,10 +265,10 @@ def LaunchCommand(Command, WorkingDir): > # It could be a string or sequence. We find that if command is a str= ing in > following Popen(), > # ubuntu may fail with an error message that the command is not foun= d. > # So here we may need convert command from string to list instance. > - if not isinstance(Command, list): > - if platform.system() !=3D 'Windows': > + if platform.system() !=3D 'Windows': > + if not isinstance(Command, list): > Command =3D Command.split() > - Command =3D ' '.join(Command) > + Command =3D ' '.join(Command) >=20 > Proc =3D None > EndOfProcedure =3D None > -- > 2.8.0.windows.1