From: "Wu, Hao A" <hao.a.wu@intel.com>
To: Gary Lin <glin@suse.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Fan, Jeff" <jeff.fan@intel.com>
Subject: Re: [PATCH 31/33] SourceLevelDebugPkg: Fix typos in comments
Date: Wed, 19 Oct 2016 07:46:42 +0000 [thread overview]
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A092F2C3BDC@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20161019070138.16424-32-glin@suse.com>
Reviewed-by: Hao Wu <hao.a.wu@intel.com>
Best Regards,
Hao Wu
> -----Original Message-----
> From: Gary Lin [mailto:glin@suse.com]
> Sent: Wednesday, October 19, 2016 3:02 PM
> To: edk2-devel@lists.01.org
> Cc: Fan, Jeff; Wu, Hao A
> Subject: [PATCH 31/33] SourceLevelDebugPkg: Fix typos in comments
>
> - descrption -> description
> - Libary -> Library
> - funciton -> function
> - paramter -> parameter
> - triggerred -> triggered
> - hanlde -> handle
>
> Cc: Jeff Fan <jeff.fan@intel.com>
> Cc: Hao Wu <hao.a.wu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Gary Lin <glin@suse.com>
> ---
> SourceLevelDebugPkg/Include/Library/DebugCommunicationLib.h
> | 8 ++++----
>
> SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgent/SecPeiDebugAg
> entLib.c | 6 +++---
>
> SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgent/SecPeiDebugAg
> entLib.h | 4 ++--
>
> SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCom
> municationLibSerialPort.c | 4 ++--
>
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb/DebugCommunica
> tionLibUsb.c | 4 ++--
>
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunic
> ationLibUsb3Common.c | 6 +++---
> 6 files changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/SourceLevelDebugPkg/Include/Library/DebugCommunicationLib.h
> b/SourceLevelDebugPkg/Include/Library/DebugCommunicationLib.h
> index 0c1a7b0..b204284 100644
> --- a/SourceLevelDebugPkg/Include/Library/DebugCommunicationLib.h
> +++ b/SourceLevelDebugPkg/Include/Library/DebugCommunicationLib.h
> @@ -20,10 +20,10 @@ typedef VOID * DEBUG_PORT_HANDLE;
> /**
> Caller provided function to be invoked at the end of DebugPortInitialize().
>
> - Refer to the descrption for DebugPortInitialize() for more details.
> + Refer to the description for DebugPortInitialize() for more details.
>
> @param[in] Context The first input argument of DebugPortInitialize().
> - @param[in] DebugPortHandle Debug port handle created by Debug
> Communication Libary.
> + @param[in] DebugPortHandle Debug port handle created by Debug
> Communication Library.
>
> **/
> typedef
> @@ -41,9 +41,9 @@ VOID
> stack, this function must work on the mode that doesn't return to the caller,
> then
> the caller needs to wrap up all rest of logic after DebugPortInitialize() into
> one
> function and pass it into DebugPortInitialize(). DebugPortInitialize() is
> - responsible to invoke the passing-in funciton at the end of
> DebugPortInitialize().
> + responsible to invoke the passing-in function at the end of
> DebugPortInitialize().
>
> - If the paramter Function is not NULL, Debug Communication Libary instance
> will
> + If the parameter Function is not NULL, Debug Communication Library
> instance will
> invoke it by passing in the Context to be the first parameter. Debug
> Communication
> Library instance could create one debug port handle to be the second
> parameter
> passing into the Function. Debug Communication Library instance also could
> pass
> diff --git
> a/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgent/SecPeiDebug
> AgentLib.c
> b/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgent/SecPeiDebug
> AgentLib.c
> index faec574..128c69f 100644
> ---
> a/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgent/SecPeiDebug
> AgentLib.c
> +++
> b/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgent/SecPeiDebug
> AgentLib.c
> @@ -343,7 +343,7 @@ DebugAgentCallbackMemoryDiscoveredPpi (
> function and pass it into InitializeDebugAgent(). InitializeDebugAgent() is
> responsible to invoke the passing-in function at the end of
> InitializeDebugAgent().
>
> - If the parameter Function is not NULL, Debug Agent Libary instance will
> invoke it by
> + If the parameter Function is not NULL, Debug Agent Library instance will
> invoke it by
> passing in the Context to be its parameter.
>
> If Function() is NULL, Debug Agent Library instance will return after setup
> debug
> @@ -648,10 +648,10 @@ InitializeDebugAgent (
> /**
> Caller provided function to be invoked at the end of DebugPortInitialize().
>
> - Refer to the descrption for DebugPortInitialize() for more details.
> + Refer to the description for DebugPortInitialize() for more details.
>
> @param[in] Context The first input argument of DebugPortInitialize().
> - @param[in] DebugPortHandle Debug port handle created by Debug
> Communication Libary.
> + @param[in] DebugPortHandle Debug port handle created by Debug
> Communication Library.
>
> **/
> VOID
> diff --git
> a/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgent/SecPeiDebug
> AgentLib.h
> b/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgent/SecPeiDebug
> AgentLib.h
> index a0687fa..300bc35 100644
> ---
> a/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgent/SecPeiDebug
> AgentLib.h
> +++
> b/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgent/SecPeiDebug
> AgentLib.h
> @@ -30,10 +30,10 @@ typedef struct {
> /**
> Caller provided function to be invoked at the end of DebugPortInitialize().
>
> - Refer to the descrption for DebugPortInitialize() for more details.
> + Refer to the description for DebugPortInitialize() for more details.
>
> @param[in] Context The first input argument of DebugPortInitialize().
> - @param[in] DebugPortHandle Debug port handle created by Debug
> Communication Libary.
> + @param[in] DebugPortHandle Debug port handle created by Debug
> Communication Library.
>
> **/
> VOID
> diff --git
> a/SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCo
> mmunicationLibSerialPort.c
> b/SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCo
> mmunicationLibSerialPort.c
> index 388286b..6a854ff 100644
> ---
> a/SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCo
> mmunicationLibSerialPort.c
> +++
> b/SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCo
> mmunicationLibSerialPort.c
> @@ -26,9 +26,9 @@
> stack, this function must work on the mode that doesn't return to the caller,
> then
> the caller needs to wrap up all rest of logic after DebugPortInitialize() into
> one
> function and pass it into DebugPortInitialize(). DebugPortInitialize() is
> - responsible to invoke the passing-in funciton at the end of
> DebugPortInitialize().
> + responsible to invoke the passing-in function at the end of
> DebugPortInitialize().
>
> - If the paramter Function is not NULL, Debug Communication Libary instance
> will
> + If the parameter Function is not NULL, Debug Communication Library
> instance will
> invoke it by passing in the Context to be the first parameter. Debug
> Communication
> Library instance could create one debug port handle to be the second
> parameter
> passing into the Function. Debug Communication Library instance also could
> pass
> diff --git
> a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb/DebugCommuni
> cationLibUsb.c
> b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb/DebugCommuni
> cationLibUsb.c
> index a08a260..d7829c2 100644
> ---
> a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb/DebugCommuni
> cationLibUsb.c
> +++
> b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb/DebugCommuni
> cationLibUsb.c
> @@ -511,7 +511,7 @@ UsbDebugPortControlTransfer (
> Check if it needs to re-initialize usb debug port hardware.
>
> During different phases switch, such as SEC to PEI or PEI to DXE or DXE to
> SMM, we should check
> - whether the usb debug port hardware configuration is changed. Such case
> can be triggerred by
> + whether the usb debug port hardware configuration is changed. Such case
> can be triggered by
> Pci bus resource allocation and so on.
>
> @param Handle Debug port handle.
> @@ -1007,7 +1007,7 @@ DebugPortPollBuffer (
> /**
> Initialize the debug port.
>
> - If Function is not NULL, Debug Communication Libary will call this function
> + If Function is not NULL, Debug Communication Library will call this function
> by passing in the Context to be the first parameter. If needed, Debug
> Communication
> Library will create one debug port handle to be the second argument passing
> in
> calling the Function, otherwise it will pass NULL to be the second argument of
> diff --git
> a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
> icationLibUsb3Common.c
> b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
> icationLibUsb3Common.c
> index 7c62bda..04e25e3 100644
> ---
> a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
> icationLibUsb3Common.c
> +++
> b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
> icationLibUsb3Common.c
> @@ -300,7 +300,7 @@ Done:
> Check if it needs to re-initialize usb debug port hardware.
>
> During different phases switch, such as SEC to PEI or PEI to DXE or DXE to
> SMM, we should check
> - whether the usb debug port hardware configuration is changed. Such case
> can be triggerred by
> + whether the usb debug port hardware configuration is changed. Such case
> can be triggered by
> Pci bus resource allocation and so on.
>
> @param Handle Debug port handle.
> @@ -989,7 +989,7 @@ DebugPortPollBuffer (
> /**
> Initialize the debug port.
>
> - If Function is not NULL, Debug Communication Libary will call this function
> + If Function is not NULL, Debug Communication Library will call this function
> by passing in the Context to be the first parameter. If needed, Debug
> Communication
> Library will create one debug port handle to be the second argument passing
> in
> calling the Function, otherwise it will pass NULL to be the second argument of
> @@ -997,7 +997,7 @@ DebugPortPollBuffer (
>
> If Function is NULL, and Context is not NULL, the Debug Communication
> Library could
> a) Return the same handle as passed in (as Context parameter).
> - b) Ignore the input Context parameter and create new hanlde to be
> returned.
> + b) Ignore the input Context parameter and create new handle to be
> returned.
>
> If parameter Function is NULL and Context is NULL, Debug Communication
> Library could
> created a new handle if needed and return it, otherwise it will return NULL.
> --
> 2.10.1
next prev parent reply other threads:[~2016-10-19 7:46 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 7:01 [PATCH 00/33] Fix typos in comments and variables Gary Lin
2016-10-19 7:01 ` [PATCH 01/33] ArmPkg: Fix typos in comments Gary Lin
2016-10-19 15:09 ` Ard Biesheuvel
2016-10-19 15:15 ` Laszlo Ersek
2016-10-19 15:33 ` Leif Lindholm
2016-10-19 7:01 ` [PATCH 02/33] BaseTools: Fix typos in comments and variables Gary Lin
2016-10-19 7:30 ` Gao, Liming
2016-10-19 7:36 ` Zhu, Yonghong
2016-10-19 7:01 ` [PATCH 03/33] CorebootPayloadPkg: Fix typos in comments Gary Lin
2016-10-26 18:50 ` Ma, Maurice
2016-10-19 7:01 ` [PATCH 04/33] CorebootModulePkg: " Gary Lin
2016-10-26 18:41 ` Ma, Maurice
2016-10-19 7:01 ` [PATCH 05/33] CryptoPkg: " Gary Lin
2016-10-26 3:00 ` Long, Qin
2016-10-19 7:01 ` [PATCH 06/33] DuetPkg: " Gary Lin
2016-10-19 7:46 ` Ni, Ruiyu
2016-10-19 7:01 ` [PATCH 07/33] EdkCompatibilityPkg: " Gary Lin
2016-10-19 8:19 ` Gao, Liming
2016-10-19 7:01 ` [PATCH 08/33] EmulatorPkg: Fix typos in comments and variables Gary Lin
2016-10-19 20:37 ` Jordan Justen
2016-10-20 8:16 ` Laszlo Ersek
2016-10-19 7:01 ` [PATCH 09/33] EmbeddedPkg: Fix typos in comments Gary Lin
2016-10-19 15:09 ` Ard Biesheuvel
2016-10-19 7:01 ` [PATCH 10/33] IntelFrameworkModulePkg: " Gary Lin
2016-10-20 1:08 ` Fan, Jeff
2016-10-19 7:01 ` [PATCH 11/33] IntelFrameworkPkg: " Gary Lin
2016-10-20 1:08 ` Fan, Jeff
2016-10-19 7:01 ` [PATCH 12/33] IntelFspPkg: " Gary Lin
2016-10-19 7:06 ` Yao, Jiewen
2016-10-19 7:01 ` [PATCH 13/33] IntelFspWrapperPkg: " Gary Lin
2016-10-19 7:08 ` Yao, Jiewen
2016-10-19 7:01 ` [PATCH 14/33] IntelFsp2Pkg: " Gary Lin
2016-10-19 7:06 ` Yao, Jiewen
2016-10-19 7:12 ` Mudusuru, Giri P
2016-10-19 7:01 ` [PATCH 15/33] IntelFsp2WrapperPkg: Fix a typo in the comment Gary Lin
2016-10-19 7:07 ` Yao, Jiewen
2016-10-19 7:11 ` Mudusuru, Giri P
2016-10-19 7:01 ` [PATCH 16/33] MdeModulePkg: BootManagerMenuApp: Fix typos in comments Gary Lin
2016-10-19 8:20 ` Tian, Feng
2016-10-19 7:01 ` [PATCH 17/33] MdeModulePkg/Bus: " Gary Lin
2016-10-19 7:01 ` [PATCH 18/33] MdeModulePkg/Core: " Gary Lin
2016-10-19 8:20 ` Tian, Feng
2016-10-19 7:01 ` [PATCH 19/33] MdeModulePkg/Include: " Gary Lin
2016-10-19 7:01 ` [PATCH 20/33] MdeModulePkg/Library: Fix typos in comments and variables Gary Lin
2016-10-19 7:01 ` [PATCH 21/33] MdeModulePkg/Universal: Fix typos in comments Gary Lin
2016-10-19 7:01 ` [PATCH 22/33] MdePkg: " Gary Lin
2016-10-19 8:21 ` Gao, Liming
2016-10-19 7:01 ` [PATCH 23/33] NetworkPkg: " Gary Lin
2016-10-19 7:21 ` Fu, Siyuan
2016-10-26 0:53 ` Fu, Siyuan
2016-10-19 7:01 ` [PATCH 24/33] Nt32Pkg: Fix typos in comments and variables Gary Lin
2016-10-19 7:50 ` Ni, Ruiyu
2016-10-19 7:01 ` [PATCH 25/33] OptionRomPkg: Fix typos in comments Gary Lin
2016-10-19 7:51 ` Ni, Ruiyu
2016-10-19 7:01 ` [PATCH 26/33] OvmfPkg: " Gary Lin
2016-10-19 7:01 ` [PATCH 27/33] QuarkPlatformPkg: " Gary Lin
2016-10-25 20:53 ` Kinney, Michael D
2016-10-19 7:01 ` [PATCH 28/33] QuarkSocPkg: " Gary Lin
2016-10-25 21:00 ` Kinney, Michael D
2016-10-19 7:01 ` [PATCH 29/33] SecurityPkg: " Gary Lin
2016-10-27 1:29 ` Zhang, Chao B
2016-11-14 3:12 ` Zhang, Chao B
2016-11-14 4:03 ` Gary Lin
2016-11-14 6:24 ` Gao, Liming
2016-11-14 8:30 ` Gary Lin
2016-10-19 7:01 ` [PATCH 30/33] ShellPkg: Fix typos in comments and variables Gary Lin
2016-10-19 7:51 ` Ni, Ruiyu
2016-10-19 20:29 ` Carsey, Jaben
2016-10-20 1:55 ` Gary Lin
2016-10-19 7:01 ` [PATCH 31/33] SourceLevelDebugPkg: Fix typos in comments Gary Lin
2016-10-19 7:46 ` Wu, Hao A [this message]
2016-10-19 7:01 ` [PATCH 32/33] UefiCpuPkg: " Gary Lin
2016-10-20 1:58 ` Fan, Jeff
2016-10-20 2:08 ` Gary Lin
2016-10-20 2:45 ` Fan, Jeff
2016-10-19 7:01 ` [PATCH 33/33] Vlv2TbltDevicePkg: " Gary Lin
2016-10-24 1:33 ` Wei, David
2016-10-19 7:28 ` [PATCH 00/33] Fix typos in comments and variables Zeng, Star
2016-10-19 14:50 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B80AF82E9BFB8E4FBD8C89DA810C6A092F2C3BDC@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox