Re: [PATCH 0/6] Refine code logics to prevent possible mis-reports by static code checkers

["Wu, Hao A" <hao.a.wu@intel.com>]

Hi Heyi,

For the warnings reported by the static checkers you mentioned, could you
help to analyze those issues and find out if there are real issues exist?

If there are real code issues, I think you can report them to Bugzilla
with the appropriate classification (e.g. Security or Not Security
Related).

Thanks in advance.

Best Regards,
Hao Wu

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Heyi
> Guo
> Sent: Sunday, December 18, 2016 11:04 AM
> To: Wu, Hao A; edk2-devel@lists.01.org
> Cc: Ye, Ting; Gao, Liming; Wu, Jiaxin; Yao, Jiewen; Kinney, Michael D; Fu, Siyuan
> Subject: Re: [edk2] [PATCH 0/6] Refine code logics to prevent possible mis-
> reports by static code checkers
> 
> Hi Hao,
> 
> May I ask which static code checkers you are using?
> 
> We are using Coverity and Fortify checkers, and there are hundreds of
> warnings reported. Do you have a plan to analyze and fix (some may be
> not real errors) the warnings from these two checkers?
> 
> Thanks and regards,
> 
> Heyi
> 
> 在 12/14/2016 7:26 PM, Hao Wu 写道:
> > The series refines the loop logic (e.g. for, while) of some functions to
> > be more straightforward. This will help to prevent some possible
> > mis-reports by static code checkers
> >
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Fu Siyuan <siyuan.fu@intel.com>
> > Cc: Ye Ting <ting.ye@intel.com>
> > Cc: Wu Jiaxin <jiaxin.wu@intel.com>
> >
> > Hao Wu (6):
> >    MdePkg/BaseLib: Refine (Ascii)StrnLenS functions logic
> >    MdePkg/BaseLib: Add an additional check within (Ascii)StrnCmp
> >    MdePkg/MemoryLib: Refine InternalMemSetMem16|32|64 functions logic
> >    MdeModulePkg/DxeNetLib: Rewrite NetblockChecksum function logic
> >    MdeModulePkg/UefiPxeBcDxe: Refine the CvtNum function logic
> >    NetworkPkg: Refine UintnToAscDecWithFormat functions logic
> >
> >   MdeModulePkg/Library/DxeNetLib/NetBuffer.c             | 16 ++++++++--------
> >   .../Universal/Network/UefiPxeBcDxe/PxeBcSupport.c      |  5 ++---
> >   MdePkg/Library/BaseLib/SafeString.c                    | 16 ++++++++++++----
> >   MdePkg/Library/BaseLib/String.c                        |  4 +++-
> >   MdePkg/Library/BaseMemoryLib/MemLibGeneric.c           | 18 +++++++++--
> -------
> >   MdePkg/Library/PeiMemoryLib/MemLibGeneric.c            | 18 +++++++++----
> -----
> >   MdePkg/Library/UefiMemoryLib/MemLibGeneric.c           | 18 +++++++++---
> ------
> >   NetworkPkg/HttpBootDxe/HttpBootSupport.c               |  5 ++---
> >   NetworkPkg/UefiPxeBcDxe/PxeBcSupport.c                 |  5 ++---
> >   9 files changed, 56 insertions(+), 49 deletions(-)
> >
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel