From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH] MdeModulePkg/NonDiscoverable: Compare SIZE_4GB with address type
Date: Wed, 11 Jan 2017 02:08:49 +0000 [thread overview]
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A0931C6AA3F@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5B87AE3E@SHSMSX104.ccr.corp.intel.com>
Got it, I will update the codes before check in. Thanks for the feedback.
Best Regards,
Hao Wu
> -----Original Message-----
> From: Ni, Ruiyu
> Sent: Wednesday, January 11, 2017 10:05 AM
> To: Wu, Hao A; edk2-devel@lists.01.org
> Cc: Wu, Hao A; Ard Biesheuvel
> Subject: RE: [edk2] [PATCH] MdeModulePkg/NonDiscoverable: Compare
> SIZE_4GB with address type
>
> One minor comments: put one space after (EFI_PHYSICAL_ADDRESS) and
> (UINTN) as below.
> > + (EFI_PHYSICAL_ADDRESS) (UINTN) HostAddress + *NumberOfBytes >
> SIZE_4GB
>
> Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
>
>
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> > Hao Wu
> > Sent: Wednesday, January 11, 2017 10:01 AM
> > To: edk2-devel@lists.01.org
> > Cc: Wu, Hao A <hao.a.wu@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>; Ard
> > Biesheuvel <ard.biesheuvel@linaro.org>
> > Subject: [edk2] [PATCH] MdeModulePkg/NonDiscoverable: Compare
> > SIZE_4GB with address type
> >
> > Refine the codes to compare the definition 'SIZE_4GB' with type
> > EFI_PHYSICAL_ADDRESS.
> >
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Hao Wu <hao.a.wu@intel.com>
> > ---
> > .../Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c |
> > 4 ++--
> > .../NonDiscoverableDeviceRegistrationLib.c | 2 +-
> > 2 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git
> > a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverable
> > PciDeviceIo.c
> > b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverable
> > PciDeviceIo.c
> > index b07c129..c836ad6 100644
> > ---
> > a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverable
> > PciDeviceIo.c
> > +++
> > b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverable
> > Pc
> > +++ iDeviceIo.c
> > @@ -598,7 +598,7 @@ CoherentPciIoMap (
> > //
> > Dev = NON_DISCOVERABLE_PCI_DEVICE_FROM_PCI_IO(This);
> > if ((Dev->Attributes & EFI_PCI_IO_ATTRIBUTE_DUAL_ADDRESS_CYCLE) ==
> > 0 &&
> > - (UINTN)HostAddress + *NumberOfBytes > SIZE_4GB) {
> > + (EFI_PHYSICAL_ADDRESS)(UINTN)HostAddress + *NumberOfBytes >
> > + SIZE_4GB) {
> >
> > //
> > // Bounce buffering is not possible for consistent mappings @@ -1006,7
> > +1006,7 @@ NonCoherentPciIoMap (
> > // a bounce buffer and copy over the data in case HostAddress >= 4 GB.
> > //
> > Bounce = ((Dev->Attributes &
> > EFI_PCI_IO_ATTRIBUTE_DUAL_ADDRESS_CYCLE) == 0 &&
> > - (UINTN)HostAddress + *NumberOfBytes > SIZE_4GB);
> > + (EFI_PHYSICAL_ADDRESS)(UINTN)HostAddress + *NumberOfBytes >
> > + SIZE_4GB);
> >
> > if (!Bounce) {
> > switch (Operation) {
> > diff --git
> > a/MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDisco
> > verableDeviceRegistrationLib.c
> > b/MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDisco
> > verableDeviceRegistrationLib.c
> > index 6f46dfa..4180b0a 100644
> > ---
> > a/MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDisco
> > verableDeviceRegistrationLib.c
> > +++
> > b/MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDisco
> > +++ verableDeviceRegistrationLib.c
> > @@ -163,7 +163,7 @@ RegisterNonDiscoverableMmioDevice (
> > Desc->AddrLen = Size;
> > Desc->AddrRangeMax = Base + Size - 1;
> > Desc->ResType = ACPI_ADDRESS_SPACE_TYPE_MEM;
> > - Desc->AddrSpaceGranularity = (Base + Size > SIZE_4GB) ? 64 : 32;
> > + Desc->AddrSpaceGranularity = ((EFI_PHYSICAL_ADDRESS) Base + Size >
> > + SIZE_4GB) ? 64 : 32;
> > Desc->AddrTranslationOffset = 0;
> > }
> > VA_END (Args);
> > --
> > 1.9.5.msysgit.0
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2017-01-11 2:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-11 2:01 [PATCH] MdeModulePkg/NonDiscoverable: Compare SIZE_4GB with address type Hao Wu
2017-01-11 2:05 ` Ni, Ruiyu
2017-01-11 2:08 ` Wu, Hao A [this message]
2017-01-11 7:55 ` Ard Biesheuvel
2017-01-11 10:59 ` Wu, Hao A
2017-01-11 20:14 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B80AF82E9BFB8E4FBD8C89DA810C6A0931C6AA3F@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox