From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 51B7D803D6 for ; Sun, 19 Mar 2017 19:34:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1489977269; x=1521513269; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=MCeMbT+b6PHvvCSHs99iK1jSWbsVCa8OLswddTqqSDE=; b=GjN/k2a3o+cxbX99e30ZxectlEUlWzI/aCn3hX6YZSAeK9K+9YpDLxxG BwKwJHBhRGPMQ2uTWjCAW1VkEnR9dw==; Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Mar 2017 19:34:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,191,1486454400"; d="scan'208";a="946070715" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga003.jf.intel.com with ESMTP; 19 Mar 2017 19:34:27 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 19 Mar 2017 19:34:28 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.59]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.177]) with mapi id 14.03.0248.002; Mon, 20 Mar 2017 10:34:19 +0800 From: "Wu, Hao A" To: "Tian, Feng" , "Zeng, Star" , Laszlo Ersek , edk2-devel-01 CC: Ard Biesheuvel , Leif Lindholm Thread-Topic: [PATCH v2 03/12] MdeModulePkg/RamDiskDxe: fix C string literal catenation in info messages Thread-Index: AQHSn1+8VDm0DQMWZ0mVmWh3L5zIo6GcexYAgAACzQCAAIgwUA== Date: Mon, 20 Mar 2017 02:34:19 +0000 Message-ID: References: <20170317204731.31488-1-lersek@redhat.com> <20170317204731.31488-4-lersek@redhat.com> <0C09AFA07DD0434D9E2A0C6AEB0483103B835B1D@shsmsx102.ccr.corp.intel.com> <7F1BAD85ADEA444D97065A60D2E97EE5699BBA08@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <7F1BAD85ADEA444D97065A60D2E97EE5699BBA08@SHSMSX101.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2 03/12] MdeModulePkg/RamDiskDxe: fix C string literal catenation in info messages X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Mar 2017 02:34:29 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Hao Wu Best Regards, Hao Wu > -----Original Message----- > From: Tian, Feng > Sent: Monday, March 20, 2017 10:26 AM > To: Zeng, Star; Laszlo Ersek; edk2-devel-01 > Cc: Ard Biesheuvel; Wu, Hao A; Leif Lindholm; Tian, Feng > Subject: RE: [PATCH v2 03/12] MdeModulePkg/RamDiskDxe: fix C string liter= al > catenation in info messages >=20 > Ok to me as well. >=20 > Reviewed-by: Feng Tian >=20 > Thanks > Feng >=20 > -----Original Message----- > From: Zeng, Star > Sent: Monday, March 20, 2017 10:16 AM > To: Laszlo Ersek ; edk2-devel-01 > Cc: Ard Biesheuvel ; Tian, Feng > ; Wu, Hao A ; Leif Lindholm > ; Zeng, Star > Subject: RE: [PATCH v2 03/12] MdeModulePkg/RamDiskDxe: fix C string liter= al > catenation in info messages >=20 > I am ok with this patch. >=20 > Feng and Hao, do you have any comments? >=20 > Thanks, > Star > -----Original Message----- > From: Laszlo Ersek [mailto:lersek@redhat.com] > Sent: Saturday, March 18, 2017 4:47 AM > To: edk2-devel-01 > Cc: Ard Biesheuvel ; Tian, Feng > ; Wu, Hao A ; Leif Lindholm > ; Zeng, Star > Subject: [PATCH v2 03/12] MdeModulePkg/RamDiskDxe: fix C string literal > catenation in info messages >=20 > RamDiskDxe installs the RamDiskAcpiCheck() Ready To Boot callback functio= n. > If EFI_ACPI_TABLE_PROTOCOL and/or EFI_ACPI_SDT_PROTOCOL are not found, > then informational messages are logged, and the RAM disks are not publish= ed > to the (nonexistent) NFIT table. >=20 > The logic is fine, but the info messages are not concatenated correctly f= rom > multiple string literals -- the second parts are passed as (unused) argum= ents to > DEBUG(). Fix the typos. >=20 > Cc: Ard Biesheuvel > Cc: Feng Tian > Cc: Hao Wu > Cc: Leif Lindholm > Cc: Star Zeng > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek > --- > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c > b/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c > index d1dd13a8197b..b2bafc58bb71 100644 > --- a/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c > +++ b/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c > @@ -74,7 +74,7 @@ RamDiskAcpiCheck ( > if (EFI_ERROR (Status)) { > DEBUG (( > EFI_D_INFO, > - "RamDiskAcpiCheck: Cannot locate the EFI ACPI Table Protocol,", > + "RamDiskAcpiCheck: Cannot locate the EFI ACPI Table Protocol, " > "unable to publish RAM disks to NFIT.\n" > )); > return; > @@ -91,7 +91,7 @@ RamDiskAcpiCheck ( > if (EFI_ERROR (Status)) { > DEBUG (( > EFI_D_INFO, > - "RamDiskAcpiCheck: Cannot locate the EFI ACPI Sdt Protocol,", > + "RamDiskAcpiCheck: Cannot locate the EFI ACPI Sdt Protocol, " > "unable to publish RAM disks to NFIT.\n" > )); > mAcpiTableProtocol =3D NULL; > -- > 2.9.3 >=20