Re: [PATCH] MdeModulePkg/BootManagerMenu: Add assertion to indicate no DIV by 0

["Wu, Hao A" <hao.a.wu@intel.com>]

Reviewed-by: Hao Wu <hao.a.wu@intel.com>


Best Regards,
Hao Wu


> -----Original Message-----
> From: Ni, Ruiyu
> Sent: Tuesday, April 11, 2017 10:22 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A
> Subject: [PATCH] MdeModulePkg/BootManagerMenu: Add assertion to indicate
> no DIV by 0
> 
> BootMenuSelectItem() contains code to DIV BootMenuData->ItemCount.
> When BootMenuData->ItemCount can be 0, the DIV operation may
> trigger CPU exception.
> But in logic, this case won't happen. So add assertion to indicate
> it.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> ---
>  MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu.c | 3
> ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git
> a/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu.c
> b/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu.c
> index 6d493e1..a25f2ca 100644
> --- a/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu.c
> +++
> b/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu.c
> @@ -1,7 +1,7 @@
>  /** @file
>    The application to show the Boot Manager Menu.
> 
> -Copyright (c) 2011 - 2016, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2011 - 2017, Intel Corporation. All rights reserved.<BR>
>  This program and the accompanying materials
>  are licensed and made available under the terms and conditions of the BSD
> License
>  which accompanies this distribution.  The full text of the license may be found
> at
> @@ -374,6 +374,7 @@ BootMenuSelectItem (
>    if (BootMenuData == NULL || WantSelectItem >= BootMenuData->ItemCount)
> {
>      return EFI_INVALID_PARAMETER;
>    }
> +  ASSERT (BootMenuData->ItemCount != 0);
>    SavedAttribute = gST->ConOut->Mode->Attribute;
>    RePaintItems = FALSE;
>    StartCol = BootMenuData->MenuScreen.StartCol;
> --
> 2.9.0.windows.1