From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Bi, Dandan" <dandan.bi@intel.com>
Subject: Re: [PATCH] ShellPkg/pci: Fix VS2012 build failure
Date: Thu, 20 Apr 2017 02:57:00 +0000 [thread overview]
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A0931C9A328@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20170420025043.66620-2-ruiyu.ni@intel.com>
Reviewed-by: Hao Wu <hao.a.wu@intel.com>
Best Regards,
Hao Wu
> -----Original Message-----
> From: Ni, Ruiyu
> Sent: Thursday, April 20, 2017 10:51 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A; Bi, Dandan
> Subject: [PATCH] ShellPkg/pci: Fix VS2012 build failure
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> ---
> ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c
> index 99335f05c5..38559571c2 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c
> +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c
> @@ -2885,6 +2885,7 @@ ShellCommandRunPci (
> );
>
> ExtendedConfigSpace = NULL;
> + ExtendedConfigSize = 0;
> PcieCapabilityPtr = LocatePciCapability (&ConfigSpace,
> EFI_PCI_CAPABILITY_ID_PCIEXP);
> if (PcieCapabilityPtr != 0) {
> ExtendedConfigSize = 0x1000 - EFI_PCIE_CAPABILITY_BASE_OFFSET;
> @@ -2922,7 +2923,7 @@ ShellCommandRunPci (
> //
> if (ExplainData) {
> PciExplainPci (&ConfigSpace, Address, IoDev);
> - if ((PcieCapabilityPtr != 0) && !ShellGetExecutionBreakFlag ()) {
> + if ((ExtendedConfigSpace != NULL) && !ShellGetExecutionBreakFlag ()) {
> PciExplainPciExpress (
> (PCI_CAPABILITY_PCIEXP *) ((UINT8 *) &ConfigSpace +
> PcieCapabilityPtr),
> ExtendedConfigSpace,
> --
> 2.12.2.windows.2
next prev parent reply other threads:[~2017-04-20 2:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 2:50 [PATCH] ShellPkg/comp: Fix file tag name Ruiyu Ni
2017-04-20 2:50 ` [PATCH] ShellPkg/pci: Fix VS2012 build failure Ruiyu Ni
2017-04-20 2:57 ` Wu, Hao A [this message]
2017-04-20 20:20 ` [PATCH] ShellPkg/comp: Fix file tag name Carsey, Jaben
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B80AF82E9BFB8E4FBD8C89DA810C6A0931C9A328@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox