From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C384921A0483B for ; Wed, 19 Apr 2017 19:57:04 -0700 (PDT) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Apr 2017 19:57:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,223,1488873600"; d="scan'208";a="76546118" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga002.jf.intel.com with ESMTP; 19 Apr 2017 19:57:03 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 19 Apr 2017 19:57:03 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 19 Apr 2017 19:57:03 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.178]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.193]) with mapi id 14.03.0319.002; Thu, 20 Apr 2017 10:57:00 +0800 From: "Wu, Hao A" To: "Ni, Ruiyu" , "edk2-devel@lists.01.org" CC: "Bi, Dandan" Thread-Topic: [PATCH] ShellPkg/pci: Fix VS2012 build failure Thread-Index: AQHSuYDuBYeMer0jc0eJXZZ+vOwKBaHNkHmw Date: Thu, 20 Apr 2017 02:57:00 +0000 Message-ID: References: <20170420025043.66620-1-ruiyu.ni@intel.com> <20170420025043.66620-2-ruiyu.ni@intel.com> In-Reply-To: <20170420025043.66620-2-ruiyu.ni@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg/pci: Fix VS2012 build failure X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Apr 2017 02:57:05 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Hao Wu Best Regards, Hao Wu > -----Original Message----- > From: Ni, Ruiyu > Sent: Thursday, April 20, 2017 10:51 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A; Bi, Dandan > Subject: [PATCH] ShellPkg/pci: Fix VS2012 build failure >=20 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni > Cc: Hao A Wu > Cc: Dandan Bi > --- > ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c > b/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c > index 99335f05c5..38559571c2 100644 > --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c > +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c > @@ -2885,6 +2885,7 @@ ShellCommandRunPci ( > ); >=20 > ExtendedConfigSpace =3D NULL; > + ExtendedConfigSize =3D 0; > PcieCapabilityPtr =3D LocatePciCapability (&ConfigSpace, > EFI_PCI_CAPABILITY_ID_PCIEXP); > if (PcieCapabilityPtr !=3D 0) { > ExtendedConfigSize =3D 0x1000 - EFI_PCIE_CAPABILITY_BASE_OFFSET; > @@ -2922,7 +2923,7 @@ ShellCommandRunPci ( > // > if (ExplainData) { > PciExplainPci (&ConfigSpace, Address, IoDev); > - if ((PcieCapabilityPtr !=3D 0) && !ShellGetExecutionBreakFlag ()) = { > + if ((ExtendedConfigSpace !=3D NULL) && !ShellGetExecutionBreakFlag= ()) { > PciExplainPciExpress ( > (PCI_CAPABILITY_PCIEXP *) ((UINT8 *) &ConfigSpace + > PcieCapabilityPtr), > ExtendedConfigSpace, > -- > 2.12.2.windows.2