From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7CCA221A143C1 for ; Thu, 6 Jul 2017 22:38:50 -0700 (PDT) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP; 06 Jul 2017 22:40:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,320,1496127600"; d="scan'208";a="1192441845" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga002.fm.intel.com with ESMTP; 06 Jul 2017 22:40:31 -0700 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 6 Jul 2017 22:40:31 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 6 Jul 2017 22:40:30 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.151]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.122]) with mapi id 14.03.0319.002; Fri, 7 Jul 2017 13:40:29 +0800 From: "Wu, Hao A" To: "Ni, Ruiyu" CC: "Kinney, Michael D" , "Gao, Liming" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH 1/2] MdePkg: Add EFI Partition Information Protocol definitions Thread-Index: AQHS6zParaReOu6b8EWfprVFdvQ4u6JHNHmAgAC8B8A= Date: Fri, 7 Jul 2017 05:40:28 +0000 Message-ID: References: <20170622084440.7696-1-hao.a.wu@intel.com> <20170622084440.7696-2-hao.a.wu@intel.com> <734D49CCEBEEF84792F5B80ED585239D5B9B1A32@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5B9B1A32@SHSMSX104.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 1/2] MdePkg: Add EFI Partition Information Protocol definitions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Jul 2017 05:38:50 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Ni, Ruiyu > Sent: Friday, July 07, 2017 10:27 AM > To: Wu, Hao A > Cc: Ni, Ruiyu; Kinney, Michael D; Gao, Liming; edk2-devel@lists.01.org > Subject: RE: [PATCH 1/2] MdePkg: Add EFI Partition Information Protocol > definitions >=20 > Minor comment: > Why uses forward reference for structure EFI_PARTITION_INFO_PROTOCOL? > The forward reference is because some protocol interfaces need the pointe= r of > protocol structure as This parameter. > I think you can directly use typedef struct {...} EFI_PARTITION_INFO_PROT= OCOL. >=20 Got it. Sent a V2 patch according to the comment. Best Regards, Hao Wu > Thanks/Ray >=20 > > -----Original Message----- > > From: Wu, Hao A > > Sent: Thursday, June 22, 2017 4:45 PM > > To: edk2-devel@lists.01.org > > Cc: Wu, Hao A ; Ni, Ruiyu ; > > Kinney, Michael D ; Gao, Liming > > > > Subject: [PATCH 1/2] MdePkg: Add EFI Partition Information Protocol > > definitions > > > > Cc: Ruiyu Ni > > Cc: Michael D Kinney > > Cc: Liming Gao > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Hao Wu > > --- > > MdePkg/Include/Protocol/PartitionInfo.h | 78 ++++++++++++++++++++ > > MdePkg/MdePkg.dec | 3 + > > 2 files changed, 81 insertions(+) > > > > diff --git a/MdePkg/Include/Protocol/PartitionInfo.h > > b/MdePkg/Include/Protocol/PartitionInfo.h > > new file mode 100644 > > index 0000000000..60e46456c6 > > --- /dev/null > > +++ b/MdePkg/Include/Protocol/PartitionInfo.h > > @@ -0,0 +1,78 @@ > > +/** @file > > + This file defines the EFI Partition Information Protocol. > > + > > + Copyright (c) 2017, Intel Corporation. All rights reserved.
Thi= s > > + program and the accompanying materials are licensed and made > > + available under the terms and conditions of the BSD License which > > + accompanies this distribution. The full text of the license may be > > + found at http://opensource.org/licenses/bsd-license.php > > + > > + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > > BASIS, > > + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > > EXPRESS OR IMPLIED. > > + > > + @par Revision Reference: > > + This Protocol is introduced in UEFI Specification 2.7 > > + > > +**/ > > + > > +#ifndef __PARTITION_INFO_PROTOCOL_H__ > > +#define __PARTITION_INFO_PROTOCOL_H__ > > + > > +#include > > +#include > > + > > +// > > +// EFI Partition Information Protocol GUID value // #define > > +EFI_PARTITION_INFO_PROTOCOL_GUID \ > > + { 0x8cf2f62c, 0xbc9b, 0x4821, { 0x80, 0x8d, 0xec, 0x9e, 0xc4, 0x21, > > +0xa1, 0xa0 }}; > > + > > +// > > +// Forward reference for pure ANSI compatability // typedef struct > > +_EFI_PARTITION_INFO_PROTOCOL EFI_PARTITION_INFO_PROTOCOL; > > + > > +#define EFI_PARTITION_INFO_PROTOCOL_REVISION 0x0001000 > > +#define PARTITION_TYPE_OTHER 0x00 > > +#define PARTITION_TYPE_MBR 0x01 > > +#define PARTITION_TYPE_GPT 0x02 > > + > > +#pragma pack(1) > > + > > +/// > > +/// Partition Information Protocol structure. > > +/// > > +struct _EFI_PARTITION_INFO_PROTOCOL { > > + // > > + // Set to EFI_PARTITION_INFO_PROTOCOL_REVISION. > > + // > > + UINT32 Revision; > > + // > > + // Partition info type (PARTITION_TYPE_MBR, PARTITION_TYPE_GPT, or > > PARTITION_TYPE_OTHER). > > + // > > + UINT32 Type; > > + // > > + // If 1, partition describes an EFI System Partition. > > + // > > + UINT8 System; > > + UINT8 Reserved[7]; > > + union { > > + /// > > + /// MBR data > > + /// > > + MBR_PARTITION_RECORD Mbr; > > + /// > > + /// GPT data > > + /// > > + EFI_PARTITION_ENTRY Gpt; > > + } Info; > > +}; > > + > > +#pragma pack() > > + > > +/// > > +/// Partition Information Protocol GUID variable. > > +/// > > +extern EFI_GUID gEfiPartitionInfoProtocolGuid; > > + > > +#endif > > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index > > 7a7504b7a3..c48f248526 100644 > > --- a/MdePkg/MdePkg.dec > > +++ b/MdePkg/MdePkg.dec > > @@ -1671,6 +1671,9 @@ > > ## Include/Protocol/BluetoothLeConfig.h > > gEfiBluetoothLeConfigProtocolGuid =3D { 0x8f76da58, 0x1f99, = 0x4275, > > { 0xa4, 0xec, 0x47, 0x56, 0x51, 0x5b, 0x1c, 0xe8 } } > > > > + ## Include/Protocol/PartitionInfo.h > > + gEfiPartitionInfoProtocolGuid =3D { 0x8cf2f62c, 0xbc9b, = 0x4821, { 0x80, > > 0x8d, 0xec, 0x9e, 0xc4, 0x21, 0xa1, 0xa0 }} > > + > > # > > # Protocols defined in Shell2.0 > > # > > -- > > 2.12.0.windows.1