From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 42E392095DB87 for ; Thu, 3 Aug 2017 18:24:14 -0700 (PDT) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Aug 2017 18:26:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,318,1498546800"; d="scan'208";a="135925021" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga006.fm.intel.com with ESMTP; 03 Aug 2017 18:26:25 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 3 Aug 2017 18:26:25 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 3 Aug 2017 18:26:25 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.151]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.197]) with mapi id 14.03.0319.002; Fri, 4 Aug 2017 09:26:23 +0800 From: "Wu, Hao A" To: "Zhu, Yonghong" , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" , Andrew Fish Thread-Topic: [Patch V2 2/4] DuetPkg: Fix Xcode 9 Beta treating 32-bit left shift as undefined Thread-Index: AQHTDDbwW5XP3g+OUkiPDgExx7J29aJzaNMA Date: Fri, 4 Aug 2017 01:26:23 +0000 Message-ID: References: <1501750792-31020-1-git-send-email-yonghong.zhu@intel.com> <1501750792-31020-3-git-send-email-yonghong.zhu@intel.com> In-Reply-To: <1501750792-31020-3-git-send-email-yonghong.zhu@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch V2 2/4] DuetPkg: Fix Xcode 9 Beta treating 32-bit left shift as undefined X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2017 01:24:14 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Hao Wu Best Regards, Hao Wu > -----Original Message----- > From: Zhu, Yonghong > Sent: Thursday, August 03, 2017 5:00 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu; Wu, Hao A; Andrew Fish > Subject: [Patch V2 2/4] DuetPkg: Fix Xcode 9 Beta treating 32-bit left sh= ift as > undefined >=20 > Bug: https://bugzilla.tianocore.org/show_bug.cgi?id=3D635 >=20 > Cc: Ruiyu Ni > Cc: Hao Wu > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Andrew Fish > --- > DuetPkg/EfiLdr/TianoDecompress.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/DuetPkg/EfiLdr/TianoDecompress.c > b/DuetPkg/EfiLdr/TianoDecompress.c > index b504e8e..695f516 100644 > --- a/DuetPkg/EfiLdr/TianoDecompress.c > +++ b/DuetPkg/EfiLdr/TianoDecompress.c > @@ -91,15 +91,15 @@ Arguments: >=20 > Returns: (VOID) >=20 > --*/ > { > - Sd->mBitBuf =3D (UINT32) (Sd->mBitBuf << NumOfBits); > + Sd->mBitBuf =3D (UINT32) LShiftU64 (((UINT64)Sd->mBitBuf), NumOfBits); >=20 > while (NumOfBits > Sd->mBitCount) { > - > - Sd->mBitBuf |=3D (UINT32) (Sd->mSubBitBuf << (NumOfBits =3D (UINT16) > (NumOfBits - Sd->mBitCount))); > + NumOfBits =3D (UINT16) (NumOfBits - Sd->mBitCount); > + Sd->mBitBuf |=3D (UINT32) LShiftU64 (((UINT64)Sd->mSubBitBuf), NumOf= Bits); >=20 > if (Sd->mCompSize > 0) { > // > // Get 1 byte into SubBitBuf > // > -- > 2.6.1.windows.1