Re: [PATCH] SourceLevelDebugPkg/DebugCommLibUsb3: Remove IntelFrameworkPkg.dec

["Wu, Hao A" <hao.a.wu@intel.com>]

Reviewed-by: Hao Wu <hao.a.wu@intel.com>


Best Regards,
Hao Wu


> -----Original Message-----
> From: Zeng, Star
> Sent: Friday, September 01, 2017 10:36 AM
> To: Ni, Ruiyu; edk2-devel@lists.01.org
> Cc: Wu, Hao A; Zeng, Star
> Subject: RE: [edk2] [PATCH] SourceLevelDebugPkg/DebugCommLibUsb3:
> Remove IntelFrameworkPkg.dec
> 
> I checked package build and platform build with the patch.
> I checked the functionality is same before and after the patch.
> 
> 
> Thanks,
> Star
> -----Original Message-----
> From: Ni, Ruiyu
> Sent: Thursday, August 31, 2017 8:09 PM
> To: Zeng, Star <star.zeng@intel.com>; edk2-devel@lists.01.org
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: RE: [edk2] [PATCH] SourceLevelDebugPkg/DebugCommLibUsb3:
> Remove IntelFrameworkPkg.dec
> 
> Star,
> Did you test the UDK Debugger functionality with this change?
> 
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Star
> Zeng
> Sent: Thursday, August 31, 2017 6:00 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Zeng,
> Star <star.zeng@intel.com>
> Subject: [edk2] [PATCH] SourceLevelDebugPkg/DebugCommLibUsb3: Remove
> IntelFrameworkPkg.dec
> 
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Hao Wu <hao.a.wu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
>  .../Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Dxe.inf
> | 3 +--
>   .../Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Pei.inf
> | 1 -
>  2 files changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git
> a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
> icationLibUsb3Dxe.inf
> b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
> icationLibUsb3Dxe.inf
> index c029219aef27..08b9ec12d298 100644
> ---
> a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
> icationLibUsb3Dxe.inf
> +++
> b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
> i
> +++ cationLibUsb3Dxe.inf
> @@ -1,7 +1,7 @@
>  ## @file
>  #  Debug Communication Library instance based on usb3 debug port.
>  #
> -#  Copyright (c) 2014 - 2015, Intel Corporation. All rights reserved.<BR>
> +#  Copyright (c) 2014 - 2017, Intel Corporation. All rights
> +reserved.<BR>
>  #
>  #  This program and the accompanying materials  #  are licensed and made
> available under the terms and conditions of the BSD License @@ -37,7 +37,6
> @@ [Sources]  [Packages]
>    MdePkg/MdePkg.dec
>    MdeModulePkg/MdeModulePkg.dec
> -  IntelFrameworkPkg/IntelFrameworkPkg.dec
>    SourceLevelDebugPkg/SourceLevelDebugPkg.dec
> 
>  [Pcd]
> diff --git
> a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
> icationLibUsb3Pei.inf
> b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
> icationLibUsb3Pei.inf
> index 6cd5e1068333..2108face50d2 100644
> ---
> a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
> icationLibUsb3Pei.inf
> +++
> b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
> i
> +++ cationLibUsb3Pei.inf
> @@ -37,7 +37,6 @@ [Sources]
>  [Packages]
>    MdePkg/MdePkg.dec
>    MdeModulePkg/MdeModulePkg.dec
> -  IntelFrameworkPkg/IntelFrameworkPkg.dec
>    SourceLevelDebugPkg/SourceLevelDebugPkg.dec
> 
>  [Ppis]
> --
> 2.7.0.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel