* [PATCH] UefiCpuPkg/CpuDxe: Fix GCC build error on commit c1cab54ce57c2608b8b3ea051c7041f036f21153 [not found] <UefiCpuPkg/CpuDxe: Fix GCC build error> @ 2017-09-22 2:15 ` Jian J Wang 2017-09-22 3:20 ` Wu, Hao A 0 siblings, 1 reply; 4+ messages in thread From: Jian J Wang @ 2017-09-22 2:15 UTC (permalink / raw) To: edk2-devel; +Cc: Hao Wu, Anthony PERARD Cc: Hao Wu <hao.a.wu@intel.com> Cc: Anthony PERARD <anthony.perard@citrix.com> Suggested-by: Jiewen Yao <jiewen.yao@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jian J Wang <jian.j.wang@intel.com> --- UefiCpuPkg/CpuDxe/CpuPageTable.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/UefiCpuPkg/CpuDxe/CpuPageTable.c b/UefiCpuPkg/CpuDxe/CpuPageTable.c index ae93f3f553..d312eb66f8 100644 --- a/UefiCpuPkg/CpuDxe/CpuPageTable.c +++ b/UefiCpuPkg/CpuDxe/CpuPageTable.c @@ -802,8 +802,12 @@ RefreshGcdMemoryAttributesFromPaging ( GetCurrentPagingContext (&PagingContext); - BaseAddress = 0; - PageLength = 0; + DoUpdate = FALSE; + Capabilities = 0; + Attributes = 0; + BaseAddress = 0; + PageLength = 0; + for (Index = 0; Index < NumberOfDescriptors; Index++) { if (MemorySpaceMap[Index].GcdMemoryType == EfiGcdMemoryTypeNonExistent) { continue; -- 2.14.1.windows.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] UefiCpuPkg/CpuDxe: Fix GCC build error on commit c1cab54ce57c2608b8b3ea051c7041f036f21153 2017-09-22 2:15 ` [PATCH] UefiCpuPkg/CpuDxe: Fix GCC build error on commit c1cab54ce57c2608b8b3ea051c7041f036f21153 Jian J Wang @ 2017-09-22 3:20 ` Wu, Hao A 2017-09-22 3:33 ` Wang, Jian J 0 siblings, 1 reply; 4+ messages in thread From: Wu, Hao A @ 2017-09-22 3:20 UTC (permalink / raw) To: Wang, Jian J, edk2-devel@lists.01.org; +Cc: Anthony PERARD One minor comment, please shorten the subject of the patch. Maybe like: UefiCpuPkg/CpuDxe: Fix GCC build error on commit c1cab54 With that change, Reviewed-by: Hao Wu <hao.a.wu@intel.com> Best Regards, Hao Wu > -----Original Message----- > From: Wang, Jian J > Sent: Friday, September 22, 2017 10:15 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A; Anthony PERARD > Subject: [PATCH] UefiCpuPkg/CpuDxe: Fix GCC build error on commit > c1cab54ce57c2608b8b3ea051c7041f036f21153 > > Cc: Hao Wu <hao.a.wu@intel.com> > Cc: Anthony PERARD <anthony.perard@citrix.com> > Suggested-by: Jiewen Yao <jiewen.yao@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Jian J Wang <jian.j.wang@intel.com> > --- > UefiCpuPkg/CpuDxe/CpuPageTable.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/UefiCpuPkg/CpuDxe/CpuPageTable.c > b/UefiCpuPkg/CpuDxe/CpuPageTable.c > index ae93f3f553..d312eb66f8 100644 > --- a/UefiCpuPkg/CpuDxe/CpuPageTable.c > +++ b/UefiCpuPkg/CpuDxe/CpuPageTable.c > @@ -802,8 +802,12 @@ RefreshGcdMemoryAttributesFromPaging ( > > GetCurrentPagingContext (&PagingContext); > > - BaseAddress = 0; > - PageLength = 0; > + DoUpdate = FALSE; > + Capabilities = 0; > + Attributes = 0; > + BaseAddress = 0; > + PageLength = 0; > + > for (Index = 0; Index < NumberOfDescriptors; Index++) { > if (MemorySpaceMap[Index].GcdMemoryType == > EfiGcdMemoryTypeNonExistent) { > continue; > -- > 2.14.1.windows.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] UefiCpuPkg/CpuDxe: Fix GCC build error on commit c1cab54ce57c2608b8b3ea051c7041f036f21153 2017-09-22 3:20 ` Wu, Hao A @ 2017-09-22 3:33 ` Wang, Jian J 2017-09-22 3:52 ` Wu, Hao A 0 siblings, 1 reply; 4+ messages in thread From: Wang, Jian J @ 2017-09-22 3:33 UTC (permalink / raw) To: Wu, Hao A, edk2-devel@lists.01.org; +Cc: Anthony PERARD Ok, thanks for the review. -----Original Message----- From: Wu, Hao A Sent: Friday, September 22, 2017 11:21 AM To: Wang, Jian J <jian.j.wang@intel.com>; edk2-devel@lists.01.org Cc: Anthony PERARD <anthony.perard@citrix.com> Subject: RE: [PATCH] UefiCpuPkg/CpuDxe: Fix GCC build error on commit c1cab54ce57c2608b8b3ea051c7041f036f21153 One minor comment, please shorten the subject of the patch. Maybe like: UefiCpuPkg/CpuDxe: Fix GCC build error on commit c1cab54 With that change, Reviewed-by: Hao Wu <hao.a.wu@intel.com> Best Regards, Hao Wu > -----Original Message----- > From: Wang, Jian J > Sent: Friday, September 22, 2017 10:15 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A; Anthony PERARD > Subject: [PATCH] UefiCpuPkg/CpuDxe: Fix GCC build error on commit > c1cab54ce57c2608b8b3ea051c7041f036f21153 > > Cc: Hao Wu <hao.a.wu@intel.com> > Cc: Anthony PERARD <anthony.perard@citrix.com> > Suggested-by: Jiewen Yao <jiewen.yao@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Jian J Wang <jian.j.wang@intel.com> > --- > UefiCpuPkg/CpuDxe/CpuPageTable.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/UefiCpuPkg/CpuDxe/CpuPageTable.c > b/UefiCpuPkg/CpuDxe/CpuPageTable.c > index ae93f3f553..d312eb66f8 100644 > --- a/UefiCpuPkg/CpuDxe/CpuPageTable.c > +++ b/UefiCpuPkg/CpuDxe/CpuPageTable.c > @@ -802,8 +802,12 @@ RefreshGcdMemoryAttributesFromPaging ( > > GetCurrentPagingContext (&PagingContext); > > - BaseAddress = 0; > - PageLength = 0; > + DoUpdate = FALSE; > + Capabilities = 0; > + Attributes = 0; > + BaseAddress = 0; > + PageLength = 0; > + > for (Index = 0; Index < NumberOfDescriptors; Index++) { > if (MemorySpaceMap[Index].GcdMemoryType == > EfiGcdMemoryTypeNonExistent) { > continue; > -- > 2.14.1.windows.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] UefiCpuPkg/CpuDxe: Fix GCC build error on commit c1cab54ce57c2608b8b3ea051c7041f036f21153 2017-09-22 3:33 ` Wang, Jian J @ 2017-09-22 3:52 ` Wu, Hao A 0 siblings, 0 replies; 4+ messages in thread From: Wu, Hao A @ 2017-09-22 3:52 UTC (permalink / raw) To: Wang, Jian J, edk2-devel@lists.01.org; +Cc: Anthony PERARD After altering the commit logs, push at: 96207191fd715e268c6ba6d6ac8650ef914e1686 Best Regards, Hao Wu > -----Original Message----- > From: Wang, Jian J > Sent: Friday, September 22, 2017 11:34 AM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Anthony PERARD > Subject: RE: [PATCH] UefiCpuPkg/CpuDxe: Fix GCC build error on commit > c1cab54ce57c2608b8b3ea051c7041f036f21153 > > Ok, thanks for the review. > > -----Original Message----- > From: Wu, Hao A > Sent: Friday, September 22, 2017 11:21 AM > To: Wang, Jian J <jian.j.wang@intel.com>; edk2-devel@lists.01.org > Cc: Anthony PERARD <anthony.perard@citrix.com> > Subject: RE: [PATCH] UefiCpuPkg/CpuDxe: Fix GCC build error on commit > c1cab54ce57c2608b8b3ea051c7041f036f21153 > > One minor comment, please shorten the subject of the patch. > > Maybe like: > UefiCpuPkg/CpuDxe: Fix GCC build error on commit c1cab54 > > With that change, > Reviewed-by: Hao Wu <hao.a.wu@intel.com> > > > Best Regards, > Hao Wu > > > -----Original Message----- > > From: Wang, Jian J > > Sent: Friday, September 22, 2017 10:15 AM > > To: edk2-devel@lists.01.org > > Cc: Wu, Hao A; Anthony PERARD > > Subject: [PATCH] UefiCpuPkg/CpuDxe: Fix GCC build error on commit > > c1cab54ce57c2608b8b3ea051c7041f036f21153 > > > > Cc: Hao Wu <hao.a.wu@intel.com> > > Cc: Anthony PERARD <anthony.perard@citrix.com> > > Suggested-by: Jiewen Yao <jiewen.yao@intel.com> > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Jian J Wang <jian.j.wang@intel.com> > > --- > > UefiCpuPkg/CpuDxe/CpuPageTable.c | 8 ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/UefiCpuPkg/CpuDxe/CpuPageTable.c > > b/UefiCpuPkg/CpuDxe/CpuPageTable.c > > index ae93f3f553..d312eb66f8 100644 > > --- a/UefiCpuPkg/CpuDxe/CpuPageTable.c > > +++ b/UefiCpuPkg/CpuDxe/CpuPageTable.c > > @@ -802,8 +802,12 @@ RefreshGcdMemoryAttributesFromPaging ( > > > > GetCurrentPagingContext (&PagingContext); > > > > - BaseAddress = 0; > > - PageLength = 0; > > + DoUpdate = FALSE; > > + Capabilities = 0; > > + Attributes = 0; > > + BaseAddress = 0; > > + PageLength = 0; > > + > > for (Index = 0; Index < NumberOfDescriptors; Index++) { > > if (MemorySpaceMap[Index].GcdMemoryType == > > EfiGcdMemoryTypeNonExistent) { > > continue; > > -- > > 2.14.1.windows.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-09-22 3:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <UefiCpuPkg/CpuDxe: Fix GCC build error>
2017-09-22 2:15 ` [PATCH] UefiCpuPkg/CpuDxe: Fix GCC build error on commit c1cab54ce57c2608b8b3ea051c7041f036f21153 Jian J Wang
2017-09-22 3:20 ` Wu, Hao A
2017-09-22 3:33 ` Wang, Jian J
2017-09-22 3:52 ` Wu, Hao A
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox