From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 65CC321E1B776 for ; Thu, 21 Sep 2017 20:49:33 -0700 (PDT) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Sep 2017 20:52:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,426,1500966000"; d="scan'208";a="138165242" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga002.jf.intel.com with ESMTP; 21 Sep 2017 20:52:40 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 21 Sep 2017 20:52:40 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 21 Sep 2017 20:52:40 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.159]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.93]) with mapi id 14.03.0319.002; Fri, 22 Sep 2017 11:52:38 +0800 From: "Wu, Hao A" To: "Wang, Jian J" , "edk2-devel@lists.01.org" CC: Anthony PERARD Thread-Topic: [PATCH] UefiCpuPkg/CpuDxe: Fix GCC build error on commit c1cab54ce57c2608b8b3ea051c7041f036f21153 Thread-Index: AQHTM0ihLziL/2jSe0mj2Py2wMHmq6LAPHvwgAAEA6CAAAU2YA== Date: Fri, 22 Sep 2017 03:52:38 +0000 Message-ID: References: <20170922021501.15176-1-jian.j.wang@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] UefiCpuPkg/CpuDxe: Fix GCC build error on commit c1cab54ce57c2608b8b3ea051c7041f036f21153 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Sep 2017 03:49:33 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable After altering the commit logs, push at: 96207191fd715e268c6ba6d6ac8650ef914e1686 Best Regards, Hao Wu > -----Original Message----- > From: Wang, Jian J > Sent: Friday, September 22, 2017 11:34 AM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Anthony PERARD > Subject: RE: [PATCH] UefiCpuPkg/CpuDxe: Fix GCC build error on commit > c1cab54ce57c2608b8b3ea051c7041f036f21153 >=20 > Ok, thanks for the review. >=20 > -----Original Message----- > From: Wu, Hao A > Sent: Friday, September 22, 2017 11:21 AM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Anthony PERARD > Subject: RE: [PATCH] UefiCpuPkg/CpuDxe: Fix GCC build error on commit > c1cab54ce57c2608b8b3ea051c7041f036f21153 >=20 > One minor comment, please shorten the subject of the patch. >=20 > Maybe like: > UefiCpuPkg/CpuDxe: Fix GCC build error on commit c1cab54 >=20 > With that change, > Reviewed-by: Hao Wu >=20 >=20 > Best Regards, > Hao Wu >=20 > > -----Original Message----- > > From: Wang, Jian J > > Sent: Friday, September 22, 2017 10:15 AM > > To: edk2-devel@lists.01.org > > Cc: Wu, Hao A; Anthony PERARD > > Subject: [PATCH] UefiCpuPkg/CpuDxe: Fix GCC build error on commit > > c1cab54ce57c2608b8b3ea051c7041f036f21153 > > > > Cc: Hao Wu > > Cc: Anthony PERARD > > Suggested-by: Jiewen Yao > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Jian J Wang > > --- > > UefiCpuPkg/CpuDxe/CpuPageTable.c | 8 ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/UefiCpuPkg/CpuDxe/CpuPageTable.c > > b/UefiCpuPkg/CpuDxe/CpuPageTable.c > > index ae93f3f553..d312eb66f8 100644 > > --- a/UefiCpuPkg/CpuDxe/CpuPageTable.c > > +++ b/UefiCpuPkg/CpuDxe/CpuPageTable.c > > @@ -802,8 +802,12 @@ RefreshGcdMemoryAttributesFromPaging ( > > > > GetCurrentPagingContext (&PagingContext); > > > > - BaseAddress =3D 0; > > - PageLength =3D 0; > > + DoUpdate =3D FALSE; > > + Capabilities =3D 0; > > + Attributes =3D 0; > > + BaseAddress =3D 0; > > + PageLength =3D 0; > > + > > for (Index =3D 0; Index < NumberOfDescriptors; Index++) { > > if (MemorySpaceMap[Index].GcdMemoryType =3D=3D > > EfiGcdMemoryTypeNonExistent) { > > continue; > > -- > > 2.14.1.windows.1