* [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Fix bitwise size issue (K11)
@ 2017-10-12 5:59 Jian J Wang
2017-10-12 7:56 ` Wu, Hao A
0 siblings, 1 reply; 2+ messages in thread
From: Jian J Wang @ 2017-10-12 5:59 UTC (permalink / raw)
To: edk2-devel; +Cc: Eric Dong, Hao A Wu
Cc: Eric Dong <eric.dong@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
---
UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
index 0d3223d714..17459c790c 100644
--- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
+++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
@@ -891,7 +891,7 @@ Gen4GPageTable (
if ((Pte[0] & IA32_PG_PS) == 0) {
// 4K-page entries are already mapped. Just hide the first one anyway.
Pte = (UINT64*)(UINTN)(Pte[0] & ~mAddressEncMask & ~(EFI_PAGE_SIZE - 1));
- Pte[0] &= ~IA32_PG_P; // Hide page 0
+ Pte[0] &= ~(UINT64)IA32_PG_P; // Hide page 0
} else {
// Create 4K-page entries
Pages = (UINTN)AllocatePageTableMemory (1);
--
2.14.1.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Fix bitwise size issue (K11)
2017-10-12 5:59 [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Fix bitwise size issue (K11) Jian J Wang
@ 2017-10-12 7:56 ` Wu, Hao A
0 siblings, 0 replies; 2+ messages in thread
From: Wu, Hao A @ 2017-10-12 7:56 UTC (permalink / raw)
To: Wang, Jian J, edk2-devel@lists.01.org; +Cc: Dong, Eric
Reviewed-by: Hao Wu <hao.a.wu@intel.com>
Best Regards,
Hao Wu
> -----Original Message-----
> From: Wang, Jian J
> Sent: Thursday, October 12, 2017 2:00 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric; Wu, Hao A
> Subject: [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Fix bitwise size issue (K11)
>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
> ---
> UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> index 0d3223d714..17459c790c 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> @@ -891,7 +891,7 @@ Gen4GPageTable (
> if ((Pte[0] & IA32_PG_PS) == 0) {
> // 4K-page entries are already mapped. Just hide the first one anyway.
> Pte = (UINT64*)(UINTN)(Pte[0] & ~mAddressEncMask & ~(EFI_PAGE_SIZE -
> 1));
> - Pte[0] &= ~IA32_PG_P; // Hide page 0
> + Pte[0] &= ~(UINT64)IA32_PG_P; // Hide page 0
> } else {
> // Create 4K-page entries
> Pages = (UINTN)AllocatePageTableMemory (1);
> --
> 2.14.1.windows.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-12 7:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-12 5:59 [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Fix bitwise size issue (K11) Jian J Wang
2017-10-12 7:56 ` Wu, Hao A
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox