public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "Zeng, Star" <star.zeng@intel.com>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	"leif.lindholm@linaro.org" <leif.lindholm@linaro.org>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "Gao, Liming" <liming.gao@intel.com>,
	"Tian, Feng" <feng.tian@intel.com>,
	 "Dong, Eric" <eric.dong@intel.com>
Subject: Re: [RFC PATCH 0/2] quirks handling for SDHCI controllers
Date: Mon, 13 Nov 2017 03:37:48 +0000	[thread overview]
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A0931D1BDD1@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103B9B461F@shsmsx102.ccr.corp.intel.com>

> -----Original Message-----
> From: Zeng, Star
> Sent: Monday, November 13, 2017 11:32 AM
> To: Wu, Hao A; Ard Biesheuvel; edk2-devel@lists.01.org;
> leif.lindholm@linaro.org; Kinney, Michael D
> Cc: Gao, Liming; Tian, Feng; Dong, Eric; Zeng, Star
> Subject: RE: [RFC PATCH 0/2] quirks handling for SDHCI controllers
> 
> Hao,
> 
> Could you help do the evaluation on this RFC?

Sure, I will take a look on this.

Best Regards,
Hao Wu

> 
> 
> Thanks,
> Star
> -----Original Message-----
> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
> Sent: Friday, November 10, 2017 9:59 PM
> To: edk2-devel@lists.01.org; leif.lindholm@linaro.org; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Cc: Gao, Liming <liming.gao@intel.com>; Zeng, Star <star.zeng@intel.com>;
> Tian, Feng <feng.tian@intel.com>; Dong, Eric <eric.dong@intel.com>; Ard
> Biesheuvel <ard.biesheuvel@linaro.org>
> Subject: [RFC PATCH 0/2] quirks handling for SDHCI controllers
> 
> Many SDHCI implementations exist that are almost spec complicant, and could
> be driver by the generic SD/MMC host controller driver except for some
> minimal necessary init time tweaks.
> 
> Adding such tweaks to the generic driver is undesirable. On the other hand,
> forking the driver for every platform that has such a SDHCI controller is
> problematic when it comes to upstreaming and ongoing maintenance (which is
> arguably the point of upstreaming in the first place).
> 
> So these patches propose a workaround that is minimally invasive on the
> EDK2 side, but gives platforms a lot of leeway when it comes to applying SDHCI
> quirks.
> 
> Ard Biesheuvel (2):
>   MdeModulePkg: introduce SD/MMC override protocol
>   MdeModulePkg/SdMmcPciHcDxe: allow HC capabilities to be overridden
> 
>  MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c   | 111
> +++++++++++++++++++-
>  MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h   |   6 ++
>  MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf |   2 +
>  MdeModulePkg/Include/Protocol/SdMmcOverride.h        |  95
> +++++++++++++++++
>  MdeModulePkg/MdeModulePkg.dec                        |   3 +
>  5 files changed, 212 insertions(+), 5 deletions(-)  create mode 100644
> MdeModulePkg/Include/Protocol/SdMmcOverride.h
> 
> --
> 2.11.0



  reply	other threads:[~2017-11-13  3:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-10 13:58 [RFC PATCH 0/2] quirks handling for SDHCI controllers Ard Biesheuvel
2017-11-10 13:58 ` [RFC PATCH 1/2] MdeModulePkg: introduce SD/MMC override protocol Ard Biesheuvel
2017-11-10 13:58 ` [RFC PATCH 2/2] MdeModulePkg/SdMmcPciHcDxe: allow HC capabilities to be overridden Ard Biesheuvel
2017-11-13  3:31 ` [RFC PATCH 0/2] quirks handling for SDHCI controllers Zeng, Star
2017-11-13  3:37   ` Wu, Hao A [this message]
2017-11-23 10:10     ` Ard Biesheuvel
2017-11-23 12:55       ` Wu, Hao A
2017-11-23 12:56         ` Ard Biesheuvel
2017-11-30  2:10           ` Wu, Hao A
2017-11-30  2:14             ` Wu, Hao A
2017-11-30  2:15             ` Zeng, Star
2017-11-30  2:16               ` Wu, Hao A
2017-11-30  6:45                 ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B80AF82E9BFB8E4FBD8C89DA810C6A0931D1BDD1@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox