public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "Wu, Hao A" <hao.a.wu@intel.com>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: "Tian, Feng" <feng.tian@intel.com>,
	"Dong, Eric" <eric.dong@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	"Gao, Liming" <liming.gao@intel.com>,
	"leif.lindholm@linaro.org" <leif.lindholm@linaro.org>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	 "Zeng, Star" <star.zeng@intel.com>
Subject: Re: [RFC PATCH 0/2] quirks handling for SDHCI controllers
Date: Thu, 30 Nov 2017 02:14:35 +0000	[thread overview]
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A0931D25D96@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <B80AF82E9BFB8E4FBD8C89DA810C6A0931D25D5A@SHSMSX104.ccr.corp.intel.com>

Fix one typo in previous reply.

Best Regards,
Hao Wu

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Wu,
> Hao A
> Sent: Thursday, November 30, 2017 10:11 AM
> To: Ard Biesheuvel
> Cc: Tian, Feng; Dong, Eric; edk2-devel@lists.01.org; Gao, Liming;
> leif.lindholm@linaro.org; Kinney, Michael D; Zeng, Star
> Subject: Re: [edk2] [RFC PATCH 0/2] quirks handling for SDHCI controllers
> 
> > -----Original Message-----
> > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
> > Sent: Thursday, November 23, 2017 8:57 PM
> > To: Wu, Hao A
> > Cc: Zeng, Star; edk2-devel@lists.01.org; leif.lindholm@linaro.org; Kinney,
> > Michael D; Gao, Liming; Tian, Feng; Dong, Eric
> > Subject: Re: [RFC PATCH 0/2] quirks handling for SDHCI controllers
> >
> > On 23 November 2017 at 12:55, Wu, Hao A <hao.a.wu@intel.com> wrote:
> > >> -----Original Message-----
> > >> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
> > >> Sent: Thursday, November 23, 2017 6:11 PM
> > >> To: Wu, Hao A
> > >> Cc: Zeng, Star; edk2-devel@lists.01.org; leif.lindholm@linaro.org; Kinney,
> > >> Michael D; Gao, Liming; Tian, Feng; Dong, Eric
> > >> Subject: Re: [RFC PATCH 0/2] quirks handling for SDHCI controllers
> > >>
> > >> On 13 November 2017 at 03:37, Wu, Hao A <hao.a.wu@intel.com> wrote:
> > >> >> -----Original Message-----
> > >> >> From: Zeng, Star
> > >> >> Sent: Monday, November 13, 2017 11:32 AM
> > >> >> To: Wu, Hao A; Ard Biesheuvel; edk2-devel@lists.01.org;
> > >> >> leif.lindholm@linaro.org; Kinney, Michael D
> > >> >> Cc: Gao, Liming; Tian, Feng; Dong, Eric; Zeng, Star
> > >> >> Subject: RE: [RFC PATCH 0/2] quirks handling for SDHCI controllers
> > >> >>
> > >> >> Hao,
> > >> >>
> > >> >> Could you help do the evaluation on this RFC?
> > >> >
> > >> > Sure, I will take a look on this.
> > >> >
> > >>
> > >> Any feedback?
> > >>
> > >
> > > Hi Ard,
> > >
> > > Sorry for the delayed response.
> > >
> > > I am still collecting feedbacks internally to see if there are additional hook
> > > points needed or other features/services that can be added to the SD/MMC
> > > override protocol.
> > >
> > > I think it would be better for this protocol to be general when it is
> > > introduced, which might avoid changing the protocol frequently later.
> > >
> > > What is your thought on this?
> >
> > Thank you for bringing this up internally. I agree that we should
> > carefully consider potential use cases now and not later.
> 
> Hi Ard,
> 
> Could you help to share an code example of the consumer of this protocol

Producer (not consumer) of the protocol actually.

> for reference?
> 
> Also, we think that it might be helpful to pass the pointer of the
> EFI_SD_MMC_PASS_THRU_PROTOCOL to the
> SD_MMC_OVERRIDE_INVOKE_HOOK service
> as an additional input parameter:
> 
> typedef
> EFI_STATUS
> (EFIAPI * SD_MMC_OVERRIDE_INVOKE_HOOK) (
>   IN      EFI_HANDLE                       ControllerHandle,
>   IN      UINT8                            Slot,
>   IN      SD_MMC_OVERRIDE_HOOK             HookType,
>   IN      EFI_SD_MMC_PASS_THRU_PROTOCOL    PassThru
>   );
> 
> The implementation of the service can decide whether to use the PassThru
> protocol.
> 
> If more hook points will be later added to the SDHCI override protocol,
> they may use the EFI_SD_MMC_PASS_THRU_PROTOCOL to send additional
> commands
> to the host controller during initialization.
> 
> Best Regards,
> Hao Wu
> 
> >
> > Thanks,
> > Ard.
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


  reply	other threads:[~2017-11-30  2:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-10 13:58 [RFC PATCH 0/2] quirks handling for SDHCI controllers Ard Biesheuvel
2017-11-10 13:58 ` [RFC PATCH 1/2] MdeModulePkg: introduce SD/MMC override protocol Ard Biesheuvel
2017-11-10 13:58 ` [RFC PATCH 2/2] MdeModulePkg/SdMmcPciHcDxe: allow HC capabilities to be overridden Ard Biesheuvel
2017-11-13  3:31 ` [RFC PATCH 0/2] quirks handling for SDHCI controllers Zeng, Star
2017-11-13  3:37   ` Wu, Hao A
2017-11-23 10:10     ` Ard Biesheuvel
2017-11-23 12:55       ` Wu, Hao A
2017-11-23 12:56         ` Ard Biesheuvel
2017-11-30  2:10           ` Wu, Hao A
2017-11-30  2:14             ` Wu, Hao A [this message]
2017-11-30  2:15             ` Zeng, Star
2017-11-30  2:16               ` Wu, Hao A
2017-11-30  6:45                 ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B80AF82E9BFB8E4FBD8C89DA810C6A0931D25D96@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox