From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=hao.a.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 279C721A10960 for ; Wed, 29 Nov 2017 18:10:14 -0800 (PST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Nov 2017 18:14:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,339,1508828400"; d="scan'208";a="7829839" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga003.jf.intel.com with ESMTP; 29 Nov 2017 18:14:38 -0800 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 29 Nov 2017 18:14:38 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 29 Nov 2017 18:14:37 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.152]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0319.002; Thu, 30 Nov 2017 10:14:36 +0800 From: "Wu, Hao A" To: "Wu, Hao A" , Ard Biesheuvel CC: "Tian, Feng" , "Dong, Eric" , "edk2-devel@lists.01.org" , "Gao, Liming" , "leif.lindholm@linaro.org" , "Kinney, Michael D" , "Zeng, Star" Thread-Topic: [RFC PATCH 0/2] quirks handling for SDHCI controllers Thread-Index: AQHTXC/z/mVpjWhcIki3XkFnSsUyraMRqQqggA+fJYCAALEPMP//fT2AgArJ2jCAAAjzsA== Date: Thu, 30 Nov 2017 02:14:35 +0000 Message-ID: References: <20171110135847.361-1-ard.biesheuvel@linaro.org> <0C09AFA07DD0434D9E2A0C6AEB0483103B9B461F@shsmsx102.ccr.corp.intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [RFC PATCH 0/2] quirks handling for SDHCI controllers X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Nov 2017 02:10:14 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Fix one typo in previous reply. Best Regards, Hao Wu > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Wu= , > Hao A > Sent: Thursday, November 30, 2017 10:11 AM > To: Ard Biesheuvel > Cc: Tian, Feng; Dong, Eric; edk2-devel@lists.01.org; Gao, Liming; > leif.lindholm@linaro.org; Kinney, Michael D; Zeng, Star > Subject: Re: [edk2] [RFC PATCH 0/2] quirks handling for SDHCI controllers >=20 > > -----Original Message----- > > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > > Sent: Thursday, November 23, 2017 8:57 PM > > To: Wu, Hao A > > Cc: Zeng, Star; edk2-devel@lists.01.org; leif.lindholm@linaro.org; Kinn= ey, > > Michael D; Gao, Liming; Tian, Feng; Dong, Eric > > Subject: Re: [RFC PATCH 0/2] quirks handling for SDHCI controllers > > > > On 23 November 2017 at 12:55, Wu, Hao A wrote: > > >> -----Original Message----- > > >> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > > >> Sent: Thursday, November 23, 2017 6:11 PM > > >> To: Wu, Hao A > > >> Cc: Zeng, Star; edk2-devel@lists.01.org; leif.lindholm@linaro.org; K= inney, > > >> Michael D; Gao, Liming; Tian, Feng; Dong, Eric > > >> Subject: Re: [RFC PATCH 0/2] quirks handling for SDHCI controllers > > >> > > >> On 13 November 2017 at 03:37, Wu, Hao A wrote: > > >> >> -----Original Message----- > > >> >> From: Zeng, Star > > >> >> Sent: Monday, November 13, 2017 11:32 AM > > >> >> To: Wu, Hao A; Ard Biesheuvel; edk2-devel@lists.01.org; > > >> >> leif.lindholm@linaro.org; Kinney, Michael D > > >> >> Cc: Gao, Liming; Tian, Feng; Dong, Eric; Zeng, Star > > >> >> Subject: RE: [RFC PATCH 0/2] quirks handling for SDHCI controller= s > > >> >> > > >> >> Hao, > > >> >> > > >> >> Could you help do the evaluation on this RFC? > > >> > > > >> > Sure, I will take a look on this. > > >> > > > >> > > >> Any feedback? > > >> > > > > > > Hi Ard, > > > > > > Sorry for the delayed response. > > > > > > I am still collecting feedbacks internally to see if there are additi= onal hook > > > points needed or other features/services that can be added to the SD/= MMC > > > override protocol. > > > > > > I think it would be better for this protocol to be general when it is > > > introduced, which might avoid changing the protocol frequently later. > > > > > > What is your thought on this? > > > > Thank you for bringing this up internally. I agree that we should > > carefully consider potential use cases now and not later. >=20 > Hi Ard, >=20 > Could you help to share an code example of the consumer of this protocol Producer (not consumer) of the protocol actually. > for reference? >=20 > Also, we think that it might be helpful to pass the pointer of the > EFI_SD_MMC_PASS_THRU_PROTOCOL to the > SD_MMC_OVERRIDE_INVOKE_HOOK service > as an additional input parameter: >=20 > typedef > EFI_STATUS > (EFIAPI * SD_MMC_OVERRIDE_INVOKE_HOOK) ( > IN EFI_HANDLE ControllerHandle, > IN UINT8 Slot, > IN SD_MMC_OVERRIDE_HOOK HookType, > IN EFI_SD_MMC_PASS_THRU_PROTOCOL PassThru > ); >=20 > The implementation of the service can decide whether to use the PassThru > protocol. >=20 > If more hook points will be later added to the SDHCI override protocol, > they may use the EFI_SD_MMC_PASS_THRU_PROTOCOL to send additional > commands > to the host controller during initialization. >=20 > Best Regards, > Hao Wu >=20 > > > > Thanks, > > Ard. > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel