Re: [PATCH] MdePkg/DMAR: Add the definition for DMA_CTRL_PLATFORM_OPT_IN_FLAG bit

["Wu, Hao A" <hao.a.wu@intel.com>]

> -----Original Message-----
> From: Zeng, Star
> Sent: Thursday, January 18, 2018 10:36 AM
> To: Wu, Hao A; edk2-devel@lists.01.org
> Cc: Yao, Jiewen; Kinney, Michael D; Gao, Liming; Zeng, Star
> Subject: RE: [PATCH] MdePkg/DMAR: Add the definition for
> DMA_CTRL_PLATFORM_OPT_IN_FLAG bit
> 
> Please also update the information according to 2.5 spec.
> 
>     - Intel(R) Virtualization Technology for Directed I/O (VT-D) Architecture
>       Specification v2.4, Dated June 2016.
> 

Yes, I will update the comments when pushing the commit.

Best Regards,
Hao Wu

> Reviewed-by: Star Zeng <star.zeng@intel.com>
> 
> Thanks,
> Star
> -----Original Message-----
> From: Wu, Hao A
> Sent: Thursday, January 18, 2018 10:03 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Zeng, Star <star.zeng@intel.com>; Yao,
> Jiewen <jiewen.yao@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH] MdePkg/DMAR: Add the definition for
> DMA_CTRL_PLATFORM_OPT_IN_FLAG bit
> 
> For the support of VTd 2.5, add the BIT definition of
> DMA_CTRL_PLATFORM_OPT_IN_FLAG
> 
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Hao Wu <hao.a.wu@intel.com>
> ---
>  .../IndustryStandard/DmaRemappingReportingTable.h        | 16 +++++++++++--
> ---
>  1 file changed, 11 insertions(+), 5 deletions(-)
> 
> diff --git a/MdePkg/Include/IndustryStandard/DmaRemappingReportingTable.h
> b/MdePkg/Include/IndustryStandard/DmaRemappingReportingTable.h
> index c09ef76e40..fced884c02 100644
> --- a/MdePkg/Include/IndustryStandard/DmaRemappingReportingTable.h
> +++ b/MdePkg/Include/IndustryStandard/DmaRemappingReportingTable.h
> @@ -2,7 +2,7 @@
>    DMA Remapping Reporting (DMAR) ACPI table definition from Intel(R)
>    Virtualization Technology for Directed I/O (VT-D) Architecture Specification.
> 
> -  Copyright (c) 2016, Intel Corporation. All rights reserved.<BR>
> +  Copyright (c) 2016 - 2018, Intel Corporation. All rights
> + reserved.<BR>
>    This program and the accompanying materials
>    are licensed and made available under the terms and conditions of the BSD
> License
>    which accompanies this distribution.  The full text of the license may be found
> at @@ -30,10 +30,11 @@  ///  /// DMA-Remapping Reporting Structure
> definitions from section 8.1  ///@{
> -#define EFI_ACPI_DMAR_REVISION                    0x01
> +#define EFI_ACPI_DMAR_REVISION                             0x01
> 
> -#define EFI_ACPI_DMAR_FLAGS_INTR_REMAP            BIT0
> -#define EFI_ACPI_DMAR_FLAGS_X2APIC_OPT_OUT        BIT1
> +#define EFI_ACPI_DMAR_FLAGS_INTR_REMAP                     BIT0
> +#define EFI_ACPI_DMAR_FLAGS_X2APIC_OPT_OUT                 BIT1
> +#define EFI_ACPI_DMAR_FLAGS_DMA_CTRL_PLATFORM_OPT_IN_FLAG  BIT2
>  ///@}
> 
>  ///
> @@ -252,7 +253,12 @@ typedef struct {
>                  firmware may Set this field to request system software to opt
>                  out of enabling Extended xAPIC (X2APIC) mode. This field is
>                  valid only when the INTR_REMAP field (bit 0) is Set.
> -    - Bits[7:2] Reserved.
> +    - Bit[2]:   DMA_CTRL_PLATFORM_OPT_IN_FLAG - Platform firmware is
> +                recommended to Set this field to report any platform initiated
> +                DMA is restricted to only reserved memory regions (reported in
> +                RMRR structures) when transferring control to system software
> +                such as on ExitBootServices().
> +    - Bits[7:3] Reserved.
>    **/
>    UINT8                           Flags;
>    UINT8                           Reserved[10];
> --
> 2.12.0.windows.1