From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=hao.a.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 998C8223972BF for ; Tue, 6 Feb 2018 04:45:32 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Feb 2018 04:51:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,468,1511856000"; d="scan'208";a="27708035" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 06 Feb 2018 04:51:14 -0800 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 6 Feb 2018 04:51:14 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 6 Feb 2018 04:51:14 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.125]) by shsmsx102.ccr.corp.intel.com ([169.254.2.124]) with mapi id 14.03.0319.002; Tue, 6 Feb 2018 20:51:12 +0800 From: "Wu, Hao A" To: "Zeng, Star" , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" Thread-Topic: [PATCH] SourceLevelDebugPkg DebugAgentLib: Rename IsBsp to DebugAgentIsBsp Thread-Index: AQHTn0T4epblD7RSlUGMQlZJD9flmaOXU5Yw Date: Tue, 6 Feb 2018 12:51:11 +0000 Message-ID: References: <1517919657-9016-1-git-send-email-star.zeng@intel.com> In-Reply-To: <1517919657-9016-1-git-send-email-star.zeng@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] SourceLevelDebugPkg DebugAgentLib: Rename IsBsp to DebugAgentIsBsp X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Feb 2018 12:45:33 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Hao Wu Best Regards, Hao Wu > -----Original Message----- > From: Zeng, Star > Sent: Tuesday, February 06, 2018 8:21 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star; Ni, Ruiyu; Wu, Hao A > Subject: [PATCH] SourceLevelDebugPkg DebugAgentLib: Rename IsBsp to > DebugAgentIsBsp >=20 > For avoiding function name confliction, > rename IsBsp to DebugAgentIsBsp. >=20 > Cc: Ruiyu Ni > Cc: Hao Wu > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Star Zeng > --- >=20 > SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c > | 4 ++-- > SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.c > | 4 ++-- > SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h > | 2 +- > 3 files changed, 5 insertions(+), 5 deletions(-) >=20 > diff --git > a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgen > t.c > b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgen > t.c > index 36b1ef924cd2..7c05ce2f2806 100644 > --- > a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgen > t.c > +++ > b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgen > t.c > @@ -2485,7 +2485,7 @@ InterruptProcess ( > AcquireMpSpinLock (&mDebugMpContext.DebugPortSpinLock); >=20 > if (MultiProcessorDebugSupport()) { > - if (IsBsp (ProcessorIndex)) { > + if (DebugAgentIsBsp (ProcessorIndex)) { > // > // If current processor is BSP, check Apic timer's init count if= changed, > // it may be re-written when switching BSP. > @@ -2498,7 +2498,7 @@ InterruptProcess ( > } > } >=20 > - if (!IsBsp (ProcessorIndex) || mDebugMpContext.IpiSentByAp) { > + if (!DebugAgentIsBsp (ProcessorIndex) || mDebugMpContext.IpiSentBy= Ap) > { > ReleaseMpSpinLock (&mDebugMpContext.DebugPortSpinLock); > // > // If current processor is not BSP or this is one IPI sent by AP > diff --git > a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.c > b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.c > index d49d4ee32347..51f40cb56b77 100644 > --- > a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.c > +++ > b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.c > @@ -75,7 +75,7 @@ HaltOtherProcessors ( > ) > { > DebugAgentMsgPrint (DEBUG_AGENT_INFO, "processor[%x]:Try to halt other > processors.\n", CurrentProcessorIndex); > - if (!IsBsp (CurrentProcessorIndex)) { > + if (!DebugAgentIsBsp (CurrentProcessorIndex)) { > SetIpiSentByApFlag (TRUE);; > } >=20 > @@ -137,7 +137,7 @@ GetProcessorIndex ( >=20 > **/ > BOOLEAN > -IsBsp ( > +DebugAgentIsBsp ( > IN UINT32 ProcessorIndex > ) > { > diff --git > a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h > b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h > index 5bb50960ca72..d9c21efdaad1 100644 > --- > a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h > +++ > b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h > @@ -96,7 +96,7 @@ ReleaseMpSpinLock ( >=20 > **/ > BOOLEAN > -IsBsp ( > +DebugAgentIsBsp ( > IN UINT32 ProcessorIndex > ); >=20 > -- > 2.7.0.windows.1