From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=hao.a.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CC2E0223972AB for ; Tue, 6 Feb 2018 04:50:06 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Feb 2018 04:55:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,468,1511856000"; d="scan'208";a="172076168" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga004.jf.intel.com with ESMTP; 06 Feb 2018 04:55:48 -0800 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 6 Feb 2018 04:55:48 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 6 Feb 2018 04:55:48 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.125]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.130]) with mapi id 14.03.0319.002; Tue, 6 Feb 2018 20:55:46 +0800 From: "Wu, Hao A" To: "Zeng, Star" , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" Thread-Topic: [PATCH] SourceLevelDebugPkg DebugUsb3: Fix some typos Thread-Index: AQHTn0UVztLUSunDqUC5UjuUqWy2pKOXVQng Date: Tue, 6 Feb 2018 12:55:45 +0000 Message-ID: References: <1517919715-14520-1-git-send-email-star.zeng@intel.com> In-Reply-To: <1517919715-14520-1-git-send-email-star.zeng@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] SourceLevelDebugPkg DebugUsb3: Fix some typos X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Feb 2018 12:50:07 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Hao Wu Best Regards, Hao Wu > -----Original Message----- > From: Zeng, Star > Sent: Tuesday, February 06, 2018 8:22 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star; Ni, Ruiyu; Wu, Hao A > Subject: [PATCH] SourceLevelDebugPkg DebugUsb3: Fix some typos >=20 > Cc: Ruiyu Ni > Cc: Hao Wu > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Star Zeng > --- > SourceLevelDebugPkg/Include/Library/DebugCommunicationLib.h | 8 ++= ++- > --- > .../DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Common.c | 8 > ++++---- > SourceLevelDebugPkg/SourceLevelDebugPkg.dec | 4 ++= -- > SourceLevelDebugPkg/SourceLevelDebugPkg.uni | 4 ++= -- > 4 files changed, 12 insertions(+), 12 deletions(-) >=20 > diff --git a/SourceLevelDebugPkg/Include/Library/DebugCommunicationLib.h > b/SourceLevelDebugPkg/Include/Library/DebugCommunicationLib.h > index b2042841d28e..b37e032db09b 100644 > --- a/SourceLevelDebugPkg/Include/Library/DebugCommunicationLib.h > +++ b/SourceLevelDebugPkg/Include/Library/DebugCommunicationLib.h > @@ -1,7 +1,7 @@ > /** @file > Debug Communication Library definitions. >=20 > - Copyright (c) 2010 - 2014, Intel Corporation. All rights reserved.
> + Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved.
> This program and the accompanying materials > are licensed and made available under the terms and conditions of the = BSD > License > which accompanies this distribution. The full text of the license may= be found > at > @@ -88,7 +88,7 @@ DebugPortInitialize ( > @param Handle Debug port handle. > @param Buffer Pointer to the data buffer to store the data = read from > the debug device. > @param NumberOfBytes Number of bytes which will be read. > - @param Timeout Timeout value for reading from debug device. = It unit > is Microsecond. > + @param Timeout Timeout value for reading from debug device. = Its unit > is Microsecond. >=20 > @retval 0 Read data failed, no data is to be read. > @retval >0 Actual number of bytes read from debug device= . > @@ -118,7 +118,7 @@ DebugPortReadBuffer ( >=20 > @retval 0 NumberOfBytes is 0. > @retval >0 The number of bytes written to the debug devi= ce. > - If this value is less than NumberOfBytes, the= n the read > operation failed. > + If this value is less than NumberOfBytes, the= n the write > operation failed. >=20 > **/ > UINTN > @@ -139,7 +139,7 @@ DebugPortWriteBuffer ( > @param Handle Debug port handle. >=20 > @retval TRUE Data is waiting to be read from the debug dev= ice. > - @retval FALSE There is no data waiting to be read from the = serial > device. > + @retval FALSE There is no data waiting to be read from the = debug > device. >=20 > **/ > BOOLEAN > diff --git > a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommuni > cationLibUsb3Common.c > b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommuni > cationLibUsb3Common.c > index 04e25e3ec2cf..49bad6b5864d 100644 > --- > a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommuni > cationLibUsb3Common.c > +++ > b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommuni > cationLibUsb3Common.c > @@ -1,7 +1,7 @@ > /** @file > Debug Port Library implementation based on usb3 debug port. >=20 > - Copyright (c) 2014 - 2015, Intel Corporation. All rights reserved.
> + Copyright (c) 2014 - 2018, Intel Corporation. All rights reserved.
> This program and the accompanying materials > are licensed and made available under the terms and conditions of the = BSD > License > which accompanies this distribution. The full text of the license may= be found > at > @@ -756,7 +756,7 @@ Enable: > @param Handle Debug port handle. > @param Buffer Pointer to the data buffer to store the data = read from > the debug device. > @param NumberOfBytes Number of bytes which will be read. > - @param Timeout Timeout value for reading from debug device. = It unit > is Microsecond. > + @param Timeout Timeout value for reading from debug device. = Its unit > is Microsecond. >=20 > @retval 0 Read data failed, no data is to be read. > @retval >0 Actual number of bytes read from debug device= . > @@ -836,7 +836,7 @@ DebugPortReadBuffer ( >=20 > @retval 0 NumberOfBytes is 0. > @retval >0 The number of bytes written to the debug devi= ce. > - If this value is less than NumberOfBytes, the= n the read > operation failed. > + If this value is less than NumberOfBytes, the= n the write > operation failed. >=20 > **/ > UINTN > @@ -919,7 +919,7 @@ DebugPortWriteBuffer ( > @param Handle Debug port handle. >=20 > @retval TRUE Data is waiting to be read from the debug dev= ice. > - @retval FALSE There is no data waiting to be read from the = serial > device. > + @retval FALSE There is no data waiting to be read from the = debug > device. >=20 > **/ > BOOLEAN > diff --git a/SourceLevelDebugPkg/SourceLevelDebugPkg.dec > b/SourceLevelDebugPkg/SourceLevelDebugPkg.dec > index c9a47f625526..b89e9c6ad601 100644 > --- a/SourceLevelDebugPkg/SourceLevelDebugPkg.dec > +++ b/SourceLevelDebugPkg/SourceLevelDebugPkg.dec > @@ -6,7 +6,7 @@ > # and host, PeCoffExtraActionLib instance to report symbol path informat= ion, > # etc. > # > -# Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved.
> +# Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved.
> # This program and the accompanying materials are licensed and made > available under > # the terms and conditions of the BSD License that accompanies this > distribution. > # The full text of the license may be found at > @@ -92,7 +92,7 @@ [PcdsFixedAtBuild, PcdsPatchableInModule] >=20 > ## The memory BAR of xhci host controller, in which usb debug feature = is > enabled. > ## Note that the memory BAR address is only used before Pci bus resour= ce > allocation. > - # @Prompt Configure ehci host controller memory BAR. > + # @Prompt Configure xhci host controller memory BAR. >=20 > gEfiSourceLevelDebugPkgTokenSpaceGuid.PcdUsbXhciMemorySpaceBase|0xD0 > 000000|UINT64|0x00000007 >=20 > ## The pci address of xhci host controller, in which usb debug feature= is > enabled. > diff --git a/SourceLevelDebugPkg/SourceLevelDebugPkg.uni > b/SourceLevelDebugPkg/SourceLevelDebugPkg.uni > index 781b717e4e24..8a201652274b 100644 > --- a/SourceLevelDebugPkg/SourceLevelDebugPkg.uni > +++ b/SourceLevelDebugPkg/SourceLevelDebugPkg.uni > @@ -8,7 +8,7 @@ > // and host, PeCoffExtraActionLib instance to report symbol path informa= tion, > // etc. > // > -// Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved. > +// Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved. > // > // This program and the accompanying materials are licensed and made > available under > // the terms and conditions of the BSD License that accompanies this > distribution. > @@ -70,7 +70,7 @@ > #string > STR_gEfiSourceLevelDebugPkgTokenSpaceGuid_PcdDebugPortHandleBufferSize > _HELP #language en-US "The data buffer size used by debug port in debug > communication library instances.\n" > = "Its value is not > suggested to be changed in platform DSC file." >=20 > -#string > STR_gEfiSourceLevelDebugPkgTokenSpaceGuid_PcdUsbXhciMemorySpaceBase > _PROMPT #language en-US "Configure ehci host controller memory BAR." > +#string > STR_gEfiSourceLevelDebugPkgTokenSpaceGuid_PcdUsbXhciMemorySpaceBase > _PROMPT #language en-US "Configure xhci host controller memory BAR." >=20 > #string > STR_gEfiSourceLevelDebugPkgTokenSpaceGuid_PcdUsbXhciMemorySpaceBase > _HELP #language en-US "The memory BAR of xhci host controller, in which = usb > debug feature is enabled.\n" > = "Note that the > memory BAR address is only used before Pci bus resource allocation." > -- > 2.7.0.windows.1