* [PATCH] MdePkg/IndustryStandard: Add header file for SPMI ACPI table
@ 2018-03-22 8:37 Hao Wu
2018-03-22 9:08 ` Yao, Jiewen
0 siblings, 1 reply; 3+ messages in thread
From: Hao Wu @ 2018-03-22 8:37 UTC (permalink / raw)
To: edk2-devel; +Cc: Hao Wu, Younas Khan, Michael Kinney, Liming Gao, Jiewen Yao
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=840
Add the header file for Service Processor Management Interface ACPI table
definition.
Cc: Younas Khan <pmdyounaskhan786@gmail.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
---
.../ServiceProcessorManagementInterfaceTable.h | 97 ++++++++++++++++++++++
1 file changed, 97 insertions(+)
create mode 100644 MdePkg/Include/IndustryStandard/ServiceProcessorManagementInterfaceTable.h
diff --git a/MdePkg/Include/IndustryStandard/ServiceProcessorManagementInterfaceTable.h b/MdePkg/Include/IndustryStandard/ServiceProcessorManagementInterfaceTable.h
new file mode 100644
index 0000000000..1294c67bf9
--- /dev/null
+++ b/MdePkg/Include/IndustryStandard/ServiceProcessorManagementInterfaceTable.h
@@ -0,0 +1,97 @@
+/** @file
+ Service Processor Management Interface (SPMI) ACPI table definition from
+ Intelligent Platform Management Interface Specification Second Generation.
+
+ Copyright (c) 2018, Intel Corporation. All rights reserved.<BR>
+ This program and the accompanying materials
+ are licensed and made available under the terms and conditions of the BSD License
+ which accompanies this distribution. The full text of the license may be found at
+ http://opensource.org/licenses/bsd-license.php
+
+ THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+
+ @par Revision Reference:
+ - Intelligent Platform Management Interface Specification Second Generation
+ v2.0 Revision 1.1, Dated October 2013.
+ https://www.intel.com/content/dam/www/public/us/en/documents/specification-updates/ipmi-intelligent-platform-mgt-interface-spec-2nd-gen-v2-0-spec-update.pdf
+**/
+#ifndef _SERVICE_PROCESSOR_MANAGEMENT_INTERFACE_TABLE_H_
+#define _SERVICE_PROCESSOR_MANAGEMENT_INTERFACE_TABLE_H_
+
+#include <IndustryStandard/Acpi.h>
+
+#pragma pack(1)
+
+///
+/// Definition for Service Processor Management Interface Description Table
+///
+typedef struct {
+ EFI_ACPI_DESCRIPTION_HEADER Header;
+ ///
+ /// Indicates the type of IPMI interface.
+ ///
+ UINT8 InterfaceType;
+ ///
+ /// This field must always be 01h to be compatible with any software that
+ /// implements previous versions of this spec.
+ ///
+ UINT8 Reserved1;
+ ///
+ /// Identifies the IPMI specification revision, in BCD format.
+ ///
+ UINT16 SpecificationRevision;
+ ///
+ /// Interrupt type(s) used by the interface.
+ ///
+ UINT8 InterruptType;
+ ///
+ /// The bit assignment of the SCI interrupt within the GPEx_STS register of a
+ /// GPE described if the FADT that the interface triggers.
+ ///
+ UINT8 Gpe;
+ ///
+ /// Reserved, must be 00h.
+ ///
+ UINT8 Reserved2;
+ ///
+ /// PCI Device Flag.
+ ///
+ UINT8 PciDeviceFlag;
+ ///
+ /// The I/O APIC or I/O SAPIC Global System Interrupt used by the interface.
+ ///
+ UINT32 GlobalSystemInterrupt;
+ ///
+ /// The base address of the interface register set described using the
+ /// Generic Address Structure (GAS, See [ACPI 2.0] for the definition).
+ ///
+ EFI_ACPI_2_0_GENERIC_ADDRESS_STRUCTURE BaseAddress;
+ ///
+ /// PCI Segment Group Number, if the IPMI device is a PCI device.
+ /// Otherwise, this field is byte 1 of a UID.
+ ///
+ UINT8 PciSegGroupOrUID1;
+ ///
+ /// PCI Bus Number, if the IPMI device is a PCI device.
+ /// Otherwise, this field is byte 2 of a UID.
+ ///
+ UINT8 PciBusOrUID2;
+ ///
+ /// PCI Device fields or byte 3 of a UID.
+ ///
+ UINT8 PciDeviceOrUID3;
+ ///
+ /// PCI Function fields or byte 4 of a UID.
+ ///
+ UINT8 PciFunctionOrUID4;
+ ///
+ /// This field must always be null (0x00) to be compatible with any software
+ /// that implements previous versions of this spec.
+ ///
+ UINT8 Reserved3;
+} EFI_ACPI_SERVICE_PROCESSOR_MANAGEMENT_INTERFACE_TABLE;
+
+#pragma pack()
+
+#endif
--
2.12.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] MdePkg/IndustryStandard: Add header file for SPMI ACPI table
2018-03-22 8:37 [PATCH] MdePkg/IndustryStandard: Add header file for SPMI ACPI table Hao Wu
@ 2018-03-22 9:08 ` Yao, Jiewen
2018-03-23 1:21 ` Wu, Hao A
0 siblings, 1 reply; 3+ messages in thread
From: Yao, Jiewen @ 2018-03-22 9:08 UTC (permalink / raw)
To: Wu, Hao A
Cc: edk2-devel@lists.01.org, Kinney, Michael D, Younas Khan,
Gao, Liming
Can we use union for pci or uid?
thank you!
Yao, Jiewen
> 在 2018年3月22日，下午4:38，Hao Wu <hao.a.wu@intel.com> 写道：
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=840
>
> Add the header file for Service Processor Management Interface ACPI table
> definition.
>
> Cc: Younas Khan <pmdyounaskhan786@gmail.com>
> Cc: Michael Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Hao Wu <hao.a.wu@intel.com>
> ---
> .../ServiceProcessorManagementInterfaceTable.h | 97 ++++++++++++++++++++++
> 1 file changed, 97 insertions(+)
> create mode 100644 MdePkg/Include/IndustryStandard/ServiceProcessorManagementInterfaceTable.h
>
> diff --git a/MdePkg/Include/IndustryStandard/ServiceProcessorManagementInterfaceTable.h b/MdePkg/Include/IndustryStandard/ServiceProcessorManagementInterfaceTable.h
> new file mode 100644
> index 0000000000..1294c67bf9
> --- /dev/null
> +++ b/MdePkg/Include/IndustryStandard/ServiceProcessorManagementInterfaceTable.h
> @@ -0,0 +1,97 @@
> +/** @file
> + Service Processor Management Interface (SPMI) ACPI table definition from
> + Intelligent Platform Management Interface Specification Second Generation.
> +
> + Copyright (c) 2018, Intel Corporation. All rights reserved.<BR>
> + This program and the accompanying materials
> + are licensed and made available under the terms and conditions of the BSD License
> + which accompanies this distribution. The full text of the license may be found at
> + http://opensource.org/licenses/bsd-license.php
> +
> + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> +
> + @par Revision Reference:
> + - Intelligent Platform Management Interface Specification Second Generation
> + v2.0 Revision 1.1, Dated October 2013.
> + https://www.intel.com/content/dam/www/public/us/en/documents/specification-updates/ipmi-intelligent-platform-mgt-interface-spec-2nd-gen-v2-0-spec-update.pdf
> +**/
> +#ifndef _SERVICE_PROCESSOR_MANAGEMENT_INTERFACE_TABLE_H_
> +#define _SERVICE_PROCESSOR_MANAGEMENT_INTERFACE_TABLE_H_
> +
> +#include <IndustryStandard/Acpi.h>
> +
> +#pragma pack(1)
> +
> +///
> +/// Definition for Service Processor Management Interface Description Table
> +///
> +typedef struct {
> + EFI_ACPI_DESCRIPTION_HEADER Header;
> + ///
> + /// Indicates the type of IPMI interface.
> + ///
> + UINT8 InterfaceType;
> + ///
> + /// This field must always be 01h to be compatible with any software that
> + /// implements previous versions of this spec.
> + ///
> + UINT8 Reserved1;
> + ///
> + /// Identifies the IPMI specification revision, in BCD format.
> + ///
> + UINT16 SpecificationRevision;
> + ///
> + /// Interrupt type(s) used by the interface.
> + ///
> + UINT8 InterruptType;
> + ///
> + /// The bit assignment of the SCI interrupt within the GPEx_STS register of a
> + /// GPE described if the FADT that the interface triggers.
> + ///
> + UINT8 Gpe;
> + ///
> + /// Reserved, must be 00h.
> + ///
> + UINT8 Reserved2;
> + ///
> + /// PCI Device Flag.
> + ///
> + UINT8 PciDeviceFlag;
> + ///
> + /// The I/O APIC or I/O SAPIC Global System Interrupt used by the interface.
> + ///
> + UINT32 GlobalSystemInterrupt;
> + ///
> + /// The base address of the interface register set described using the
> + /// Generic Address Structure (GAS, See [ACPI 2.0] for the definition).
> + ///
> + EFI_ACPI_2_0_GENERIC_ADDRESS_STRUCTURE BaseAddress;
> + ///
> + /// PCI Segment Group Number, if the IPMI device is a PCI device.
> + /// Otherwise, this field is byte 1 of a UID.
> + ///
> + UINT8 PciSegGroupOrUID1;
> + ///
> + /// PCI Bus Number, if the IPMI device is a PCI device.
> + /// Otherwise, this field is byte 2 of a UID.
> + ///
> + UINT8 PciBusOrUID2;
> + ///
> + /// PCI Device fields or byte 3 of a UID.
> + ///
> + UINT8 PciDeviceOrUID3;
> + ///
> + /// PCI Function fields or byte 4 of a UID.
> + ///
> + UINT8 PciFunctionOrUID4;
> + ///
> + /// This field must always be null (0x00) to be compatible with any software
> + /// that implements previous versions of this spec.
> + ///
> + UINT8 Reserved3;
> +} EFI_ACPI_SERVICE_PROCESSOR_MANAGEMENT_INTERFACE_TABLE;
> +
> +#pragma pack()
> +
> +#endif
> --
> 2.12.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MdePkg/IndustryStandard: Add header file for SPMI ACPI table
2018-03-22 9:08 ` Yao, Jiewen
@ 2018-03-23 1:21 ` Wu, Hao A
0 siblings, 0 replies; 3+ messages in thread
From: Wu, Hao A @ 2018-03-23 1:21 UTC (permalink / raw)
To: Yao, Jiewen
Cc: edk2-devel@lists.01.org, Kinney, Michael D, Younas Khan,
Gao, Liming
Yes, V2 patch has been sent out according to the feedback.
Best Regards,
Hao Wu
> -----Original Message-----
> From: Yao, Jiewen
> Sent: Thursday, March 22, 2018 5:09 PM
> To: Wu, Hao A
> Cc: edk2-devel@lists.01.org; Kinney, Michael D; Younas Khan; Gao, Liming
> Subject: Re: [edk2] [PATCH] MdePkg/IndustryStandard: Add header file for
> SPMI ACPI table
>
> Can we use union for pci or uid?
>
> thank you!
> Yao, Jiewen
>
>
> > 在 2018年3月22日，下午4:38，Hao Wu <hao.a.wu@intel.com> 写道：
> >
> > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=840
> >
> > Add the header file for Service Processor Management Interface ACPI table
> > definition.
> >
> > Cc: Younas Khan <pmdyounaskhan786@gmail.com>
> > Cc: Michael Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Hao Wu <hao.a.wu@intel.com>
> > ---
> > .../ServiceProcessorManagementInterfaceTable.h | 97
> ++++++++++++++++++++++
> > 1 file changed, 97 insertions(+)
> > create mode 100644
> MdePkg/Include/IndustryStandard/ServiceProcessorManagementInterfaceTabl
> e.h
> >
> > diff --git
> a/MdePkg/Include/IndustryStandard/ServiceProcessorManagementInterfaceTa
> ble.h
> b/MdePkg/Include/IndustryStandard/ServiceProcessorManagementInterfaceTa
> ble.h
> > new file mode 100644
> > index 0000000000..1294c67bf9
> > --- /dev/null
> > +++
> b/MdePkg/Include/IndustryStandard/ServiceProcessorManagementInterfaceTa
> ble.h
> > @@ -0,0 +1,97 @@
> > +/** @file
> > + Service Processor Management Interface (SPMI) ACPI table definition from
> > + Intelligent Platform Management Interface Specification Second
> Generation.
> > +
> > + Copyright (c) 2018, Intel Corporation. All rights reserved.<BR>
> > + This program and the accompanying materials
> > + are licensed and made available under the terms and conditions of the BSD
> License
> > + which accompanies this distribution. The full text of the license may be
> found at
> > + http://opensource.org/licenses/bsd-license.php
> > +
> > + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS"
> BASIS,
> > + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER
> EXPRESS OR IMPLIED.
> > +
> > + @par Revision Reference:
> > + - Intelligent Platform Management Interface Specification Second
> Generation
> > + v2.0 Revision 1.1, Dated October 2013.
> > +
> https://www.intel.com/content/dam/www/public/us/en/documents/specificatio
> n-updates/ipmi-intelligent-platform-mgt-interface-spec-2nd-gen-v2-0-spec-
> update.pdf
> > +**/
> > +#ifndef _SERVICE_PROCESSOR_MANAGEMENT_INTERFACE_TABLE_H_
> > +#define _SERVICE_PROCESSOR_MANAGEMENT_INTERFACE_TABLE_H_
> > +
> > +#include <IndustryStandard/Acpi.h>
> > +
> > +#pragma pack(1)
> > +
> > +///
> > +/// Definition for Service Processor Management Interface Description
> Table
> > +///
> > +typedef struct {
> > + EFI_ACPI_DESCRIPTION_HEADER Header;
> > + ///
> > + /// Indicates the type of IPMI interface.
> > + ///
> > + UINT8 InterfaceType;
> > + ///
> > + /// This field must always be 01h to be compatible with any software that
> > + /// implements previous versions of this spec.
> > + ///
> > + UINT8 Reserved1;
> > + ///
> > + /// Identifies the IPMI specification revision, in BCD format.
> > + ///
> > + UINT16 SpecificationRevision;
> > + ///
> > + /// Interrupt type(s) used by the interface.
> > + ///
> > + UINT8 InterruptType;
> > + ///
> > + /// The bit assignment of the SCI interrupt within the GPEx_STS register of
> a
> > + /// GPE described if the FADT that the interface triggers.
> > + ///
> > + UINT8 Gpe;
> > + ///
> > + /// Reserved, must be 00h.
> > + ///
> > + UINT8 Reserved2;
> > + ///
> > + /// PCI Device Flag.
> > + ///
> > + UINT8 PciDeviceFlag;
> > + ///
> > + /// The I/O APIC or I/O SAPIC Global System Interrupt used by the interface.
> > + ///
> > + UINT32 GlobalSystemInterrupt;
> > + ///
> > + /// The base address of the interface register set described using the
> > + /// Generic Address Structure (GAS, See [ACPI 2.0] for the definition).
> > + ///
> > + EFI_ACPI_2_0_GENERIC_ADDRESS_STRUCTURE BaseAddress;
> > + ///
> > + /// PCI Segment Group Number, if the IPMI device is a PCI device.
> > + /// Otherwise, this field is byte 1 of a UID.
> > + ///
> > + UINT8 PciSegGroupOrUID1;
> > + ///
> > + /// PCI Bus Number, if the IPMI device is a PCI device.
> > + /// Otherwise, this field is byte 2 of a UID.
> > + ///
> > + UINT8 PciBusOrUID2;
> > + ///
> > + /// PCI Device fields or byte 3 of a UID.
> > + ///
> > + UINT8 PciDeviceOrUID3;
> > + ///
> > + /// PCI Function fields or byte 4 of a UID.
> > + ///
> > + UINT8 PciFunctionOrUID4;
> > + ///
> > + /// This field must always be null (0x00) to be compatible with any
> software
> > + /// that implements previous versions of this spec.
> > + ///
> > + UINT8 Reserved3;
> > +} EFI_ACPI_SERVICE_PROCESSOR_MANAGEMENT_INTERFACE_TABLE;
> > +
> > +#pragma pack()
> > +
> > +#endif
> > --
> > 2.12.0.windows.1
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-23 1:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-22 8:37 [PATCH] MdePkg/IndustryStandard: Add header file for SPMI ACPI table Hao Wu
2018-03-22 9:08 ` Yao, Jiewen
2018-03-23 1:21 ` Wu, Hao A
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox