From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=hao.a.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F31B5220C2A79 for ; Thu, 22 Mar 2018 18:14:37 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Mar 2018 18:21:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,347,1517904000"; d="scan'208";a="27299508" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga007.jf.intel.com with ESMTP; 22 Mar 2018 18:21:10 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 22 Mar 2018 18:21:09 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 22 Mar 2018 18:21:09 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.226]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.166]) with mapi id 14.03.0319.002; Fri, 23 Mar 2018 09:21:07 +0800 From: "Wu, Hao A" To: "Yao, Jiewen" CC: "edk2-devel@lists.01.org" , "Kinney, Michael D" , Younas Khan , "Gao, Liming" Thread-Topic: [edk2] [PATCH] MdePkg/IndustryStandard: Add header file for SPMI ACPI table Thread-Index: AQHTwbkq3OrBVZOa+kmRxUg11uVhY6PbcSOAgAGVvXA= Date: Fri, 23 Mar 2018 01:21:07 +0000 Message-ID: References: <20180322083754.8788-1-hao.a.wu@intel.com> <168B06C3-B402-42F3-91B7-683377F1D2F7@intel.com> In-Reply-To: <168B06C3-B402-42F3-91B7-683377F1D2F7@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] MdePkg/IndustryStandard: Add header file for SPMI ACPI table X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Mar 2018 01:14:38 -0000 Content-Language: en-US Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable Yes, V2 patch has been sent out according to the feedback. Best Regards, Hao Wu > -----Original Message----- > From: Yao, Jiewen > Sent: Thursday, March 22, 2018 5:09 PM > To: Wu, Hao A > Cc: edk2-devel@lists.01.org; Kinney, Michael D; Younas Khan; Gao, Liming > Subject: Re: [edk2] [PATCH] MdePkg/IndustryStandard: Add header file for > SPMI ACPI table >=20 > Can we use union for pci or uid? >=20 > thank you! > Yao, Jiewen >=20 >=20 > > =1B$B:_=1B(B 2018=1B$BG/=1B(B3=1B$B7n=1B(B22=1B$BF|!$2<8a=1B(B4:38=1B$B= !$=1B(BHao Wu =1B$B > > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D840 > > > > Add the header file for Service Processor Management Interface ACPI tab= le > > definition. > > > > Cc: Younas Khan > > Cc: Michael Kinney > > Cc: Liming Gao > > Cc: Jiewen Yao > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Hao Wu > > --- > > .../ServiceProcessorManagementInterfaceTable.h | 97 > ++++++++++++++++++++++ > > 1 file changed, 97 insertions(+) > > create mode 100644 > MdePkg/Include/IndustryStandard/ServiceProcessorManagementInterfaceTabl > e.h > > > > diff --git > a/MdePkg/Include/IndustryStandard/ServiceProcessorManagementInterfaceTa > ble.h > b/MdePkg/Include/IndustryStandard/ServiceProcessorManagementInterfaceTa > ble.h > > new file mode 100644 > > index 0000000000..1294c67bf9 > > --- /dev/null > > +++ > b/MdePkg/Include/IndustryStandard/ServiceProcessorManagementInterfaceTa > ble.h > > @@ -0,0 +1,97 @@ > > +/** @file > > + Service Processor Management Interface (SPMI) ACPI table definition = from > > + Intelligent Platform Management Interface Specification Second > Generation. > > + > > + Copyright (c) 2018, Intel Corporation. All rights reserved.
> > + This program and the accompanying materials > > + are licensed and made available under the terms and conditions of th= e BSD > License > > + which accompanies this distribution. The full text of the license m= ay be > found at > > + http://opensource.org/licenses/bsd-license.php > > + > > + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > BASIS, > > + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS OR IMPLIED. > > + > > + @par Revision Reference: > > + - Intelligent Platform Management Interface Specification Second > Generation > > + v2.0 Revision 1.1, Dated October 2013. > > + > https://www.intel.com/content/dam/www/public/us/en/documents/specificatio > n-updates/ipmi-intelligent-platform-mgt-interface-spec-2nd-gen-v2-0-spec- > update.pdf > > +**/ > > +#ifndef _SERVICE_PROCESSOR_MANAGEMENT_INTERFACE_TABLE_H_ > > +#define _SERVICE_PROCESSOR_MANAGEMENT_INTERFACE_TABLE_H_ > > + > > +#include > > + > > +#pragma pack(1) > > + > > +/// > > +/// Definition for Service Processor Management Interface Description > Table > > +/// > > +typedef struct { > > + EFI_ACPI_DESCRIPTION_HEADER Header; > > + /// > > + /// Indicates the type of IPMI interface. > > + /// > > + UINT8 InterfaceType; > > + /// > > + /// This field must always be 01h to be compatible with any software= that > > + /// implements previous versions of this spec. > > + /// > > + UINT8 Reserved1; > > + /// > > + /// Identifies the IPMI specification revision, in BCD format. > > + /// > > + UINT16 SpecificationRevision; > > + /// > > + /// Interrupt type(s) used by the interface. > > + /// > > + UINT8 InterruptType; > > + /// > > + /// The bit assignment of the SCI interrupt within the GPEx_STS regi= ster of > a > > + /// GPE described if the FADT that the interface triggers. > > + /// > > + UINT8 Gpe; > > + /// > > + /// Reserved, must be 00h. > > + /// > > + UINT8 Reserved2; > > + /// > > + /// PCI Device Flag. > > + /// > > + UINT8 PciDeviceFlag; > > + /// > > + /// The I/O APIC or I/O SAPIC Global System Interrupt used by the in= terface. > > + /// > > + UINT32 GlobalSystemInterrupt; > > + /// > > + /// The base address of the interface register set described using t= he > > + /// Generic Address Structure (GAS, See [ACPI 2.0] for the definitio= n). > > + /// > > + EFI_ACPI_2_0_GENERIC_ADDRESS_STRUCTURE BaseAddress; > > + /// > > + /// PCI Segment Group Number, if the IPMI device is a PCI device. > > + /// Otherwise, this field is byte 1 of a UID. > > + /// > > + UINT8 PciSegGroupOrUID1; > > + /// > > + /// PCI Bus Number, if the IPMI device is a PCI device. > > + /// Otherwise, this field is byte 2 of a UID. > > + /// > > + UINT8 PciBusOrUID2; > > + /// > > + /// PCI Device fields or byte 3 of a UID. > > + /// > > + UINT8 PciDeviceOrUID3; > > + /// > > + /// PCI Function fields or byte 4 of a UID. > > + /// > > + UINT8 PciFunctionOrUID4; > > + /// > > + /// This field must always be null (0x00) to be compatible with any > software > > + /// that implements previous versions of this spec. > > + /// > > + UINT8 Reserved3; > > +} EFI_ACPI_SERVICE_PROCESSOR_MANAGEMENT_INTERFACE_TABLE; > > + > > +#pragma pack() > > + > > +#endif > > -- > > 2.12.0.windows.1 > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel