From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=hao.a.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A5B4722146744 for ; Thu, 22 Mar 2018 19:06:18 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Mar 2018 19:12:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,347,1517904000"; d="scan'208";a="41441316" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga001.jf.intel.com with ESMTP; 22 Mar 2018 19:12:50 -0700 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 22 Mar 2018 19:12:50 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 22 Mar 2018 19:12:49 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.226]) by shsmsx102.ccr.corp.intel.com ([169.254.2.80]) with mapi id 14.03.0319.002; Fri, 23 Mar 2018 10:12:41 +0800 From: "Wu, Hao A" To: "Yao, Jiewen" , "edk2-devel@lists.01.org" CC: Younas Khan , "Kinney, Michael D" , "Gao, Liming" Thread-Topic: [PATCH v2] MdePkg/IndustryStandard: Add header file for SPMI ACPI table Thread-Index: AQHTwkUoLiqu3cjvk0WvHEGjRLLFiaPcg0YAgACQ2HA= Date: Fri, 23 Mar 2018 02:12:41 +0000 Message-ID: References: <20180323012026.10076-1-hao.a.wu@intel.com> <74D8A39837DF1E4DA445A8C0B3885C503AB0D8EC@shsmsx102.ccr.corp.intel.com> In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503AB0D8EC@shsmsx102.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2] MdePkg/IndustryStandard: Add header file for SPMI ACPI table X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Mar 2018 02:06:19 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Got it. A new version will be sent out to address this. Best Regards, Hao Wu > -----Original Message----- > From: Yao, Jiewen > Sent: Friday, March 23, 2018 9:34 AM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Younas Khan; Kinney, Michael D; Gao, Liming > Subject: RE: [PATCH v2] MdePkg/IndustryStandard: Add header file for SPMI > ACPI table >=20 > Sorry, I did not express my thought clearly. >=20 > I mean union like below: >=20 > union { > struct { > UINT8 SegmentGroup; > UINT8 Bus; > UINT8 Device; > UINT8 Function; > } Pci; > UINT32 Uid; > } DeviceId; >=20 >=20 > > -----Original Message----- > > From: Wu, Hao A > > Sent: Friday, March 23, 2018 9:20 AM > > To: edk2-devel@lists.01.org > > Cc: Wu, Hao A ; Younas Khan > > ; Kinney, Michael D > > ; Gao, Liming ; Yao, > > Jiewen > > Subject: [PATCH v2] MdePkg/IndustryStandard: Add header file for SPMI A= CPI > > table > > > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D840 > > > > Add the header file for Service Processor Management Interface ACPI tab= le > > definition. > > > > Cc: Younas Khan > > Cc: Michael Kinney > > Cc: Liming Gao > > Cc: Jiewen Yao > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Hao Wu > > --- > > .../ServiceProcessorManagementInterfaceTable.h | 109 > > +++++++++++++++++++++ > > 1 file changed, 109 insertions(+) > > create mode 100644 > > > MdePkg/Include/IndustryStandard/ServiceProcessorManagementInterfaceTabl > e > > .h > > > > diff --git > > > a/MdePkg/Include/IndustryStandard/ServiceProcessorManagementInterfaceTa > > ble.h > > > b/MdePkg/Include/IndustryStandard/ServiceProcessorManagementInterfaceTa > > ble.h > > new file mode 100644 > > index 0000000000..bda32c8c94 > > --- /dev/null > > +++ > > > b/MdePkg/Include/IndustryStandard/ServiceProcessorManagementInterfaceTa > > ble.h > > @@ -0,0 +1,109 @@ > > +/** @file > > + Service Processor Management Interface (SPMI) ACPI table definition = from > > + Intelligent Platform Management Interface Specification Second > Generation. > > + > > + Copyright (c) 2018, Intel Corporation. All rights reserved.
> > + This program and the accompanying materials > > + are licensed and made available under the terms and conditions of th= e BSD > > License > > + which accompanies this distribution. The full text of the license m= ay be > > found at > > + http://opensource.org/licenses/bsd-license.php > > + > > + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > > BASIS, > > + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > > EXPRESS OR IMPLIED. > > + > > + @par Revision Reference: > > + - Intelligent Platform Management Interface Specification Second > > Generation > > + v2.0 Revision 1.1, Dated October 2013. > > + > > > https://www.intel.com/content/dam/www/public/us/en/documents/specificati > > on-updates/ipmi-intelligent-platform-mgt-interface-spec-2nd-gen-v2-0-sp= ec- > up > > date.pdf > > +**/ > > +#ifndef _SERVICE_PROCESSOR_MANAGEMENT_INTERFACE_TABLE_H_ > > +#define _SERVICE_PROCESSOR_MANAGEMENT_INTERFACE_TABLE_H_ > > + > > +#include > > + > > +#pragma pack(1) > > + > > +/// > > +/// Definition for Service Processor Management Interface Description > Table > > +/// > > +typedef struct { > > + EFI_ACPI_DESCRIPTION_HEADER Header; > > + /// > > + /// Indicates the type of IPMI interface. > > + /// > > + UINT8 InterfaceType; > > + /// > > + /// This field must always be 01h to be compatible with any software= that > > + /// implements previous versions of this spec. > > + /// > > + UINT8 Reserved1; > > + /// > > + /// Identifies the IPMI specification revision, in BCD format. > > + /// > > + UINT16 SpecificationRevision; > > + /// > > + /// Interrupt type(s) used by the interface. > > + /// > > + UINT8 InterruptType; > > + /// > > + /// The bit assignment of the SCI interrupt within the GPEx_STS regi= ster of > a > > + /// GPE described if the FADT that the interface triggers. > > + /// > > + UINT8 Gpe; > > + /// > > + /// Reserved, must be 00h. > > + /// > > + UINT8 Reserved2; > > + /// > > + /// PCI Device Flag. > > + /// > > + UINT8 PciDeviceFlag; > > + /// > > + /// The I/O APIC or I/O SAPIC Global System Interrupt used by the in= terface. > > + /// > > + UINT32 GlobalSystemInterrupt; > > + /// > > + /// The base address of the interface register set described using t= he > > + /// Generic Address Structure (GAS, See [ACPI 2.0] for the definitio= n). > > + /// > > + EFI_ACPI_2_0_GENERIC_ADDRESS_STRUCTURE BaseAddress; > > + /// > > + /// PCI Segment Group Number, if the IPMI device is a PCI device. > > + /// Otherwise, this field is byte 1 of a UID. > > + /// > > + union { > > + UINT8 PciSegmentGroup; > > + UINT8 Uid1; > > + } Byte60; > > + /// > > + /// PCI Bus Number, if the IPMI device is a PCI device. > > + /// Otherwise, this field is byte 2 of a UID. > > + /// > > + union { > > + UINT8 PciBus; > > + UINT8 Uid2; > > + } Byte61; > > + /// > > + /// PCI Device fields or byte 3 of a UID. > > + /// > > + union { > > + UINT8 PciDevice; > > + UINT8 Uid3; > > + } Byte62; > > + /// > > + /// PCI Function fields or byte 4 of a UID. > > + /// > > + union { > > + UINT8 PciFunction; > > + UINT8 Uid4; > > + } Byte63; > > + /// > > + /// This field must always be null (0x00) to be compatible with any > software > > + /// that implements previous versions of this spec. > > + /// > > + UINT8 Reserved3; > > +} EFI_ACPI_SERVICE_PROCESSOR_MANAGEMENT_INTERFACE_TABLE; > > + > > +#pragma pack() > > + > > +#endif > > -- > > 2.12.0.windows.1