From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "Zeng, Star" <star.zeng@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
"Dong, Eric" <eric.dong@intel.com>
Subject: Re: [PATCH 2/2] MdeModulePkg/SdDxe: Demote DEBUG print to DEBUG_BLKIO
Date: Tue, 12 Jun 2018 05:57:14 +0000 [thread overview]
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A0931E07FFD@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103BB55C19@shsmsx102.ccr.corp.intel.com>
Thanks for the catch. I will update the commit log when pushing this change.
Best Regards,
Hao Wu
> -----Original Message-----
> From: Zeng, Star
> Sent: Tuesday, June 12, 2018 1:07 PM
> To: Wu, Hao A; edk2-devel@lists.01.org
> Cc: Ard Biesheuvel; Dong, Eric; Zeng, Star
> Subject: RE: [PATCH 2/2] MdeModulePkg/SdDxe: Demote DEBUG print to
> DEBUG_BLKIO
>
> "to DEBUG_INFO" should be "DEBUG_BLKIO".
>
> With that updated, Reviewed-by: Star Zeng <star.zeng@intel.com>
>
> -----Original Message-----
> From: Wu, Hao A
> Sent: Tuesday, June 12, 2018 11:37 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Ard Biesheuvel
> <ard.biesheuvel@linaro.org>; Zeng, Star <star.zeng@intel.com>; Dong, Eric
> <eric.dong@intel.com>
> Subject: [PATCH 2/2] MdeModulePkg/SdDxe: Demote DEBUG print to
> DEBUG_BLKIO
>
> Similar to commit 9dca2105ad960c9946d7cc2ece40f65e1999dac7, lower the
> priority of the DEBUG print in SDReadWrite() to DEBUG_INFO.
>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Hao Wu <hao.a.wu@intel.com>
> ---
> MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c
> b/MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c
> index 516c3e7042..b8d115abac 100644
> --- a/MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c
> +++ b/MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c
> @@ -1,7 +1,7 @@
> /** @file
> The helper functions for BlockIo and BlockIo2 protocol.
>
> - Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.<BR>
> + Copyright (c) 2015 - 2018, Intel Corporation. All rights
> + reserved.<BR>
> This program and the accompanying materials
> are licensed and made available under the terms and conditions of the BSD
> License
> which accompanies this distribution. The full text of the license may be found
> at @@ -670,7 +670,7 @@ SdReadWrite (
> if (EFI_ERROR (Status)) {
> return Status;
> }
> - DEBUG ((EFI_D_INFO, "Sd%a(): Lba 0x%x BlkNo 0x%x Event %p with %r\n",
> IsRead ? "Read" : "Write", Lba, BlockNum, Token->Event, Status));
> + DEBUG ((DEBUG_BLKIO, "Sd%a(): Lba 0x%x BlkNo 0x%x Event %p with
> + %r\n", IsRead ? "Read" : "Write", Lba, BlockNum, Token->Event,
> + Status));
>
> Lba += BlockNum;
> Buffer = (UINT8*)Buffer + BufferSize;
> --
> 2.12.0.windows.1
prev parent reply other threads:[~2018-06-12 5:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 3:36 [PATCH 0/2] Adjust DEBUG prints level for SD/NVMe BlockIo services Hao Wu
2018-06-12 3:36 ` [PATCH 1/2] MdeModulePkg/NvmExpressDxe: Adjust R/W DEBUG prints to BLKIO level Hao Wu
2018-06-12 5:05 ` Zeng, Star
2018-06-12 3:36 ` [PATCH 2/2] MdeModulePkg/SdDxe: Demote DEBUG print to DEBUG_BLKIO Hao Wu
2018-06-12 5:06 ` Zeng, Star
2018-06-12 5:57 ` Wu, Hao A [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B80AF82E9BFB8E4FBD8C89DA810C6A0931E07FFD@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox