From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=hao.a.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D8010211E370E for ; Mon, 11 Jun 2018 22:57:17 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jun 2018 22:57:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,213,1526367600"; d="scan'208";a="46431508" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga007.fm.intel.com with ESMTP; 11 Jun 2018 22:57:17 -0700 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 11 Jun 2018 22:57:17 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 11 Jun 2018 22:57:17 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.87]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.116]) with mapi id 14.03.0319.002; Tue, 12 Jun 2018 13:57:14 +0800 From: "Wu, Hao A" To: "Zeng, Star" , "edk2-devel@lists.01.org" CC: Ard Biesheuvel , "Dong, Eric" Thread-Topic: [PATCH 2/2] MdeModulePkg/SdDxe: Demote DEBUG print to DEBUG_BLKIO Thread-Index: AQHUAf6WAx/3oYvZZU2prU1srxgeJaRbjEOAgACUFhA= Date: Tue, 12 Jun 2018 05:57:14 +0000 Message-ID: References: <20180612033634.35404-1-hao.a.wu@intel.com> <20180612033634.35404-3-hao.a.wu@intel.com> <0C09AFA07DD0434D9E2A0C6AEB0483103BB55C19@shsmsx102.ccr.corp.intel.com> In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103BB55C19@shsmsx102.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 2/2] MdeModulePkg/SdDxe: Demote DEBUG print to DEBUG_BLKIO X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jun 2018 05:57:18 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for the catch. I will update the commit log when pushing this change= . Best Regards, Hao Wu > -----Original Message----- > From: Zeng, Star > Sent: Tuesday, June 12, 2018 1:07 PM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Ard Biesheuvel; Dong, Eric; Zeng, Star > Subject: RE: [PATCH 2/2] MdeModulePkg/SdDxe: Demote DEBUG print to > DEBUG_BLKIO >=20 > "to DEBUG_INFO" should be "DEBUG_BLKIO". >=20 > With that updated, Reviewed-by: Star Zeng >=20 > -----Original Message----- > From: Wu, Hao A > Sent: Tuesday, June 12, 2018 11:37 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Ard Biesheuvel > ; Zeng, Star ; Dong, Eric > > Subject: [PATCH 2/2] MdeModulePkg/SdDxe: Demote DEBUG print to > DEBUG_BLKIO >=20 > Similar to commit 9dca2105ad960c9946d7cc2ece40f65e1999dac7, lower the > priority of the DEBUG print in SDReadWrite() to DEBUG_INFO. >=20 > Cc: Ard Biesheuvel > Cc: Star Zeng > Cc: Eric Dong > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Hao Wu > --- > MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c > b/MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c > index 516c3e7042..b8d115abac 100644 > --- a/MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c > +++ b/MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c > @@ -1,7 +1,7 @@ > /** @file > The helper functions for BlockIo and BlockIo2 protocol. >=20 > - Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.
> + Copyright (c) 2015 - 2018, Intel Corporation. All rights > + reserved.
> This program and the accompanying materials > are licensed and made available under the terms and conditions of the = BSD > License > which accompanies this distribution. The full text of the license may= be found > at @@ -670,7 +670,7 @@ SdReadWrite ( > if (EFI_ERROR (Status)) { > return Status; > } > - DEBUG ((EFI_D_INFO, "Sd%a(): Lba 0x%x BlkNo 0x%x Event %p with %r\n"= , > IsRead ? "Read" : "Write", Lba, BlockNum, Token->Event, Status)); > + DEBUG ((DEBUG_BLKIO, "Sd%a(): Lba 0x%x BlkNo 0x%x Event %p with > + %r\n", IsRead ? "Read" : "Write", Lba, BlockNum, Token->Event, > + Status)); >=20 > Lba +=3D BlockNum; > Buffer =3D (UINT8*)Buffer + BufferSize; > -- > 2.12.0.windows.1