From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=hao.a.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5FDB3211D9419 for ; Thu, 21 Jun 2018 01:31:08 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Jun 2018 01:31:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,251,1526367600"; d="scan'208";a="209920990" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga004.jf.intel.com with ESMTP; 21 Jun 2018 01:31:07 -0700 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 21 Jun 2018 01:31:07 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 21 Jun 2018 01:31:07 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.87]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.51]) with mapi id 14.03.0319.002; Thu, 21 Jun 2018 16:31:05 +0800 From: "Wu, Hao A" To: "Ni, Ruiyu" , "edk2-devel@lists.01.org" CC: "Zeng, Star" , "Dong, Eric" , "Yao, Jiewen" Thread-Topic: [PATCH 1/4] MdeModulePkg: Add definitions for EDKII PEI NVME host controller PPI Thread-Index: AQHUBHcBNIF5AOuOu0W04D30QEYBPaRp1dyAgACUDEA= Date: Thu, 21 Jun 2018 08:31:04 +0000 Message-ID: References: <20180615070342.13388-1-hao.a.wu@intel.com> <20180615070342.13388-2-hao.a.wu@intel.com> <734D49CCEBEEF84792F5B80ED585239D5BD40BEC@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5BD40BEC@SHSMSX104.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 1/4] MdeModulePkg: Add definitions for EDKII PEI NVME host controller PPI X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jun 2018 08:31:08 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Ray, Thanks for the feedbacks. I will propose a V2 version of the series according to your comments. Best Regards, Hao Wu > -----Original Message----- > From: Ni, Ruiyu > Sent: Thursday, June 21, 2018 3:36 PM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Zeng, Star; Dong, Eric; Yao, Jiewen > Subject: RE: [PATCH 1/4] MdeModulePkg: Add definitions for EDKII PEI NVME > host controller PPI >=20 >=20 >=20 > Thanks/Ray >=20 > > -----Original Message----- > > From: Wu, Hao A > > Sent: Friday, June 15, 2018 3:04 PM > > To: edk2-devel@lists.01.org > > Cc: Wu, Hao A ; Zeng, Star ; > > Dong, Eric ; Ni, Ruiyu ; Yao, > > Jiewen > > Subject: [PATCH 1/4] MdeModulePkg: Add definitions for EDKII PEI NVME > > host controller PPI > > > > Introduces the below PPI: > > > > struct EDKII_NVM_EXPRESS_HOST_CONTROLLER_PPI { > > EDKII_NVM_EXPRESS_HC_GET_MMIO_BAR GetNvmeHcMmioBar; > > EDKII_NVM_EXPRESS_HC_GET_DEVICE_PATH GetNvmeHcDevicePath; > > }; > > > > The GetNvmeHcMmioBar service will provide the caller with the MMIO BAR > > address of each NVMe HC within the system; > > > > The GetNvmeHcDevicePath service will provide the caller with the device > > path information of each NVMe HC. > > > > Cc: Star Zeng > > Cc: Eric Dong > > Cc: Ruiyu Ni > > Cc: Jiewen Yao > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Hao Wu > > --- > > MdeModulePkg/Include/Ppi/NvmExpressHostController.h | 97 > > ++++++++++++++++++++ > > MdeModulePkg/MdeModulePkg.dec | 3 + > > 2 files changed, 100 insertions(+) > > > > diff --git a/MdeModulePkg/Include/Ppi/NvmExpressHostController.h > > b/MdeModulePkg/Include/Ppi/NvmExpressHostController.h > > new file mode 100644 > > index 0000000000..de9ae4a59c > > --- /dev/null > > +++ b/MdeModulePkg/Include/Ppi/NvmExpressHostController.h > > @@ -0,0 +1,97 @@ > > +/** @file > > + > > + Copyright (c) 2018, Intel Corporation. All rights reserved.
Thi= s > > + program and the accompanying materials are licensed and made > > + available under the terms and conditions of the BSD License which > > + accompanies this distribution. The full text of the license may be > > + found at http://opensource.org/licenses/bsd-license.php > > + > > + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > > BASIS, > > + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > > EXPRESS OR IMPLIED. > > + > > +**/ > > + > > +#ifndef _EDKII_NVM_EXPRESS_HOST_CONTROLLER_PPI_H_ > > +#define _EDKII_NVM_EXPRESS_HOST_CONTROLLER_PPI_H_ > > + > > +#include > > + > > +/// > > +/// Global ID for the EDKII_NVM_EXPRESS_HOST_CONTROLLER_PPI. > > +/// > > +#define EDKII_NVME_EXPRESS_HOST_CONTROLLER_PPI_GUID \ > > + { \ > > + 0xcae3aa63, 0x676f, 0x4da3, { 0xbd, 0x50, 0x6c, 0xc5, 0xed, 0xde, > > +0x9a, 0xad } \ > > + } > > + > > +// > > +// Forward declaration for the > > EDKII_NVM_EXPRESS_HOST_CONTROLLER_PPI. > > +// > > +typedef struct _EDKII_NVM_EXPRESS_HOST_CONTROLLER_PPI > > +EDKII_NVM_EXPRESS_HOST_CONTROLLER_PPI; > > + > > +/** > > + Get the MMIO base address of NVM Express host controller. > > + > > + @param[in] PeiServices Describes the list of possible PEI = Services. > > + @param[in] This The PPI instance pointer. > > + @param[in] ControllerId The ID of the NVM Express host cont= roller. > > + @param[out] MmioBar The MMIO base address of the contro= ller. > > + > > + @retval EFI_SUCCESS The operation succeeds. > > + @retval EFI_INVALID_PARAMETER The parameters are invalid. > > + @retval EFI_NOT_FOUND The specified NVM Express host cont= roller > > not > > + found. > > + > > +**/ > > +typedef > > +EFI_STATUS > > +(EFIAPI *EDKII_NVM_EXPRESS_HC_GET_MMIO_BAR) ( > > + IN EFI_PEI_SERVICES **PeiServices, >=20 > 1. PeiServices is not needed. >=20 > > + IN EDKII_NVM_EXPRESS_HOST_CONTROLLER_PPI *This, > > + IN UINT8 ControllerId, > > + OUT UINTN *MmioBar > > + ); > > + > > +/** > > + Get the device path of NVM Express host controller. > > + > > + @param[in] PeiServices Describes the list of possible PEI = Services. > > + @param[in] This The PPI instance pointer. > > + @param[in] ControllerId The ID of the NVM Express host cont= roller. > > + @param[out] DevicePathLenth The length of the device path in by= tes > > specified > > + by DevicePath. > > + @param[out] DevicePath The device path of NVM Express host > > controller. > > + The caller is responsible for freei= ng it. > > + This field re-uses EFI Device Path = Protocol as > > + defined by Section 10.2 EFI Device = Path Protocol > > + of UEFI 2.7 Specification. > > + > > + @retval EFI_SUCCESS The operation succeeds. > > + @retval EFI_INVALID_PARAMETER The parameters are invalid. > > + @retval EFI_NOT_FOUND The specified NVM Express host cont= roller > > not > > + found. > > + @retval EFI_OUT_OF_RESOURCES The operation fails due to lack of > > resources. > > + > > +**/ > > +typedef > > +EFI_STATUS > > +(EFIAPI *EDKII_NVM_EXPRESS_HC_GET_DEVICE_PATH) ( > > + IN EFI_PEI_SERVICES **PeiServices, > > + IN EDKII_NVM_EXPRESS_HOST_CONTROLLER_PPI *This, > > + IN UINT8 ControllerId, > > + OUT UINTN *DevicePathLenth, > > + OUT EFI_DEVICE_PATH_PROTOCOL **DevicePath >=20 > 2. Firstly, FreePool() is not supported in PEI phase so requiring caller = to free is > confusing. > Secondly, can the device path be determined at build time? If yes, then a > pointer to global variable can be returned so no need for caller to free. >=20 > > + ); > > + > > +// > > +// This PPI contains a set of services to interact with the NVM Expres= s > > +host // controller. > > +// > > +struct _EDKII_NVM_EXPRESS_HOST_CONTROLLER_PPI { > > + EDKII_NVM_EXPRESS_HC_GET_MMIO_BAR GetNvmeHcMmioBar; > > + EDKII_NVM_EXPRESS_HC_GET_DEVICE_PATH GetNvmeHcDevicePath; > > +}; > > + > > +extern EFI_GUID gEdkiiPeiNvmExpressHostControllerPpiGuid; > > + > > +#endif > > diff --git a/MdeModulePkg/MdeModulePkg.dec > > b/MdeModulePkg/MdeModulePkg.dec index 3802b6e0b8..8d7c97ee91 > > 100644 > > --- a/MdeModulePkg/MdeModulePkg.dec > > +++ b/MdeModulePkg/MdeModulePkg.dec > > @@ -471,6 +471,9 @@ > > ## Include/Ppi/PlatformSpecificResetHandler.h > > gEdkiiPlatformSpecificResetHandlerPpiGuid =3D { 0x75cf14ae, 0x3441, = 0x49dc, > > { 0xaa, 0x10, 0xbb, 0x35, 0xa7, 0xba, 0x8b, 0xab } } > > > > + ## Include/Ppi/NvmExpressHostController.h > > + gEdkiiPeiNvmExpressHostControllerPpiGuid =3D { 0xcae3aa63, 0x676f, > > + 0x4da3, { 0xbd, 0x50, 0x6c, 0xc5, 0xed, 0xde, 0x9a, 0xad } } > > + > > [Protocols] > > ## Load File protocol provides capability to load and unload EFI ima= ge into > > memory and execute it. > > # Include/Protocol/LoadPe32Image.h > > -- > > 2.12.0.windows.1