From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=hao.a.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AB066202E5483 for ; Tue, 10 Jul 2018 00:22:43 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jul 2018 00:22:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,333,1526367600"; d="scan'208";a="55341394" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga007.jf.intel.com with ESMTP; 10 Jul 2018 00:21:13 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 10 Jul 2018 00:21:13 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 10 Jul 2018 00:21:12 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.81]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.17]) with mapi id 14.03.0319.002; Tue, 10 Jul 2018 15:21:10 +0800 From: "Wu, Hao A" To: "Dong, Eric" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [Patch 0/2] Fixed correct password not works issue Thread-Index: AQHUGALKpbhEE/Uh4UK31GwFLseEP6SIDGww Date: Tue, 10 Jul 2018 07:21:10 +0000 Message-ID: References: <20180710040152.5812-1-eric.dong@intel.com> In-Reply-To: <20180710040152.5812-1-eric.dong@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch 0/2] Fixed correct password not works issue X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jul 2018 07:22:43 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The series looks good to me. Reviewed-by: Hao Wu Best Regards, Hao Wu > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Er= ic > Dong > Sent: Tuesday, July 10, 2018 12:02 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch 0/2] Fixed correct password not works issue >=20 > Opal device may have an count in firmware to decide whether to resistent > user input password. If yes, even correct password will be reject by devi= ce > firmware. This count will be reset only after an cold reboot or user inpu= t > correct password. >=20 > Opal driver also has an internal count to decide whether allowed user to = input > password. A reboot (code or hot) action will reset this count. >=20 > Current implementation just base on the count in opal driver to decide wh= ether > allow user to input password again. In this case, if the count in opal de= vice > already exceeded, even an correct password will be rejected. >=20 > New solution will check both count, either cout exceed will cause opal dr= iver > report count exceed and a shutdown required. >=20 > Eric Dong (2): > SecurityPkg/TcgStorageOpalLib: Return AUTHORITY_LOCKED_OUT error. > SecurityPkg/OpalPassword: Fixed input correct password not works issue >=20 > SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalUtil.c | 10 ++++++++= +- > SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c | 9 ++++++++= + > 2 files changed, 18 insertions(+), 1 deletion(-) >=20 > -- > 2.15.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel