From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=hao.a.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F22D9210C4DC9 for ; Mon, 30 Jul 2018 00:25:49 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jul 2018 00:25:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,422,1526367600"; d="scan'208";a="58200877" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga007.fm.intel.com with ESMTP; 30 Jul 2018 00:25:49 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 30 Jul 2018 00:25:48 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 30 Jul 2018 00:25:48 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.81]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.57]) with mapi id 14.03.0319.002; Mon, 30 Jul 2018 15:25:46 +0800 From: "Wu, Hao A" To: "Yao, Jiewen" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH 0/2] Avoid possible NULL ptr dereference Thread-Index: AQHUJ8dkc625xSV/8UmSm/o3Kg85B6Sm1zGAgACGKGA= Date: Mon, 30 Jul 2018 07:25:46 +0000 Message-ID: References: <20180730053709.5128-1-hao.a.wu@intel.com> <74D8A39837DF1E4DA445A8C0B3885C503ACD55CD@shsmsx102.ccr.corp.intel.com> In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503ACD55CD@shsmsx102.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 0/2] Avoid possible NULL ptr dereference X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jul 2018 07:25:50 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Yao, Jiewen > Sent: Monday, July 30, 2018 3:25 PM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Yao, Jiewen > Subject: RE: [PATCH 0/2] Avoid possible NULL ptr dereference >=20 > Seems good. >=20 > It might be better to use "if (!EFI_ERROR (Status) && > (MemoryAttributesTable !=3D NULL)) {" Yes. I will update the it when pushing the patch. Best Regards, Hao Wu >=20 > Reviewed-by: Jiewen.yao@intel.com >=20 >=20 > > -----Original Message----- > > From: Wu, Hao A > > Sent: Monday, July 30, 2018 1:37 PM > > To: edk2-devel@lists.01.org > > Cc: Wu, Hao A ; Yao, Jiewen > > Subject: [PATCH 0/2] Avoid possible NULL ptr dereference > > > > Cc: Jiewen Yao > > > > Hao Wu (2): > > MdePkg/SmmMemLib: Avoid possible NULL ptr dereference > > UefiCpuPkg/PiSmmCpuDxeSmm: Avoid possible NULL ptr dereference > > > > MdePkg/Library/SmmMemLib/SmmMemLib.c | 2 +- > > UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > -- > > 2.12.0.windows.1