From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.126; helo=mga18.intel.com; envelope-from=hao.a.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AEA41210C4DB1 for ; Thu, 9 Aug 2018 17:33:15 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Aug 2018 17:33:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,217,1531810800"; d="scan'208";a="247628484" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga005.jf.intel.com with ESMTP; 09 Aug 2018 17:33:04 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 9 Aug 2018 17:33:03 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 9 Aug 2018 17:33:03 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.143]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.150]) with mapi id 14.03.0319.002; Fri, 10 Aug 2018 08:33:01 +0800 From: "Wu, Hao A" To: "Dong, Eric" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [Patch] SecurityPkg/TcgStorageCoreLib.h: Use ascii instead of unicode. Thread-Index: AQHUL5/Wqbe4/yuPrEOJSbvTNax8+qS4JA7w Date: Fri, 10 Aug 2018 00:33:00 +0000 Message-ID: References: <20180809051349.21120-1-eric.dong@intel.com> In-Reply-To: <20180809051349.21120-1-eric.dong@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] SecurityPkg/TcgStorageCoreLib.h: Use ascii instead of unicode. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Aug 2018 00:33:16 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Hao Wu Best Regards, Hao Wu > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Er= ic > Dong > Sent: Thursday, August 09, 2018 1:14 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A > Subject: [edk2] [Patch] SecurityPkg/TcgStorageCoreLib.h: Use ascii instea= d of > unicode. >=20 > _FILE_ parameter is an ASCII string. Current implementation used > as unicode string instead of ascii string. This patch fixed this > issue. >=20 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1081 >=20 > Cc: Hao Wu > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed_off_by: Eric Dong >=20 > --- > SecurityPkg/Include/Library/TcgStorageCoreLib.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/SecurityPkg/Include/Library/TcgStorageCoreLib.h > b/SecurityPkg/Include/Library/TcgStorageCoreLib.h > index b2a0ef8f0c..213140de32 100644 > --- a/SecurityPkg/Include/Library/TcgStorageCoreLib.h > +++ b/SecurityPkg/Include/Library/TcgStorageCoreLib.h > @@ -26,21 +26,21 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY > KIND, EITHER EXPRESS OR IMPLIED. > { = \ > TCG_RESULT ret =3D (arg); = \ > if (ret !=3D TcgResultSuccess) { = \ > - DEBUG ((DEBUG_INFO, "ERROR_CHECK failed at %s:%u\n", __FILE__, > __LINE__)); \ > + DEBUG ((DEBUG_INFO, "ERROR_CHECK failed at %a:%u\n", __FILE__, > __LINE__)); \ > return ret; = \ > } = \ > } >=20 > #define METHOD_STATUS_ERROR_CHECK(arg, failRet) > \ > if ((arg) !=3D TCG_METHOD_STATUS_CODE_SUCCESS) > { \ > - DEBUG ((DEBUG_INFO, "Method Status error: 0x%02X (%s)\n", arg, > TcgMethodStatusString(arg))); \ > + DEBUG ((DEBUG_INFO, "Method Status error: 0x%02X (%a)\n", arg, > TcgMethodStatusString(arg))); \ > return (failRet); = \ > } >=20 > #define NULL_CHECK(arg) = \ > do { = \ > if ((arg) =3D=3D NULL) { = \ > - DEBUG ((DEBUG_INFO, "NULL_CHECK(%s) failed at %s:%u\n", #arg, > __FILE__, __LINE__)); \ > + DEBUG ((DEBUG_INFO, "NULL_CHECK(%a) failed at %a:%u\n", #arg, > __FILE__, __LINE__)); \ > return TcgResultFailureNullPointer; = \ > } = \ > } while (0) > -- > 2.15.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel