From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=hao.a.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9B76D210E8D6D for ; Thu, 9 Aug 2018 19:45:30 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Aug 2018 19:45:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,217,1531810800"; d="scan'208";a="62046676" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga008.fm.intel.com with ESMTP; 09 Aug 2018 19:45:20 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 9 Aug 2018 19:45:20 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 9 Aug 2018 19:45:19 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.143]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.240]) with mapi id 14.03.0319.002; Fri, 10 Aug 2018 10:45:18 +0800 From: "Wu, Hao A" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Dong, Eric" , "Zeng, Star" Thread-Topic: [edk2] [PATCH 05/26] MdeModulePkg NvmExpressDxe: Remove redundant functions Thread-Index: AQHULvSYe86LgpAy0kGc+yQ/w7t9H6S4Qj/Q Date: Fri, 10 Aug 2018 02:45:18 +0000 Message-ID: References: <20180808084712.34696-1-shenglei.zhang@intel.com> <20180808084712.34696-6-shenglei.zhang@intel.com> In-Reply-To: <20180808084712.34696-6-shenglei.zhang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 05/26] MdeModulePkg NvmExpressDxe: Remove redundant functions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Aug 2018 02:45:30 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Hao Wu Best Regards, Hao Wu > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > shenglei > Sent: Wednesday, August 08, 2018 4:47 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric; Zeng, Star > Subject: [edk2] [PATCH 05/26] MdeModulePkg NvmExpressDxe: Remove > redundant functions >=20 > The functions that are never called have been removed. > They are ReadNvmeAdminSubmissionQueueBaseAddress, > ReadNvmeAdminCompletionQueueBaseAddress and > ReadNvmeAdminQueueAttributes > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1062 >=20 > Cc: Star Zeng > Cc: Eric Dong > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: shenglei > --- > .../Bus/Pci/NvmExpressDxe/NvmExpressHci.c | 110 ------------------ > 1 file changed, 110 deletions(-) >=20 > diff --git a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c > b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c > index 30ade3a589..421561f16d 100644 > --- a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c > +++ b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c > @@ -183,43 +183,7 @@ ReadNvmeControllerStatus ( > return EFI_SUCCESS; > } >=20 > -/** > - Read Nvm Express admin queue attributes register. > - > - @param Private The pointer to the > NVME_CONTROLLER_PRIVATE_DATA data structure. > - @param Aqa The buffer used to store admin queue attribut= es > register content. > - > - @return EFI_SUCCESS Successfully read the admin queue attributes > register content. > - @return EFI_DEVICE_ERROR Fail to read the admin queue attributes regis= ter. > - > -**/ > -EFI_STATUS > -ReadNvmeAdminQueueAttributes ( > - IN NVME_CONTROLLER_PRIVATE_DATA *Private, > - IN NVME_AQA *Aqa > - ) > -{ > - EFI_PCI_IO_PROTOCOL *PciIo; > - EFI_STATUS Status; > - UINT32 Data; > - > - PciIo =3D Private->PciIo; > - Status =3D PciIo->Mem.Read ( > - PciIo, > - EfiPciIoWidthUint32, > - NVME_BAR, > - NVME_AQA_OFFSET, > - 1, > - &Data > - ); > - > - if (EFI_ERROR(Status)) { > - return Status; > - } >=20 > - WriteUnaligned32 ((UINT32*)Aqa, Data); > - return EFI_SUCCESS; > -} >=20 > /** > Write Nvm Express admin queue attributes register. > @@ -262,43 +226,6 @@ WriteNvmeAdminQueueAttributes ( > return EFI_SUCCESS; > } >=20 > -/** > - Read Nvm Express admin submission queue base address register. > - > - @param Private The pointer to the > NVME_CONTROLLER_PRIVATE_DATA data structure. > - @param Asq The buffer used to store admin submission que= ue base > address register content. > - > - @return EFI_SUCCESS Successfully read the admin submission queue = base > address register content. > - @return EFI_DEVICE_ERROR Fail to read the admin submission queue base > address register. > - > -**/ > -EFI_STATUS > -ReadNvmeAdminSubmissionQueueBaseAddress ( > - IN NVME_CONTROLLER_PRIVATE_DATA *Private, > - IN NVME_ASQ *Asq > - ) > -{ > - EFI_PCI_IO_PROTOCOL *PciIo; > - EFI_STATUS Status; > - UINT64 Data; > - > - PciIo =3D Private->PciIo; > - Status =3D PciIo->Mem.Read ( > - PciIo, > - EfiPciIoWidthUint32, > - NVME_BAR, > - NVME_ASQ_OFFSET, > - 2, > - &Data > - ); > - > - if (EFI_ERROR(Status)) { > - return Status; > - } > - > - WriteUnaligned64 ((UINT64*)Asq, Data); > - return EFI_SUCCESS; > -} >=20 > /** > Write Nvm Express admin submission queue base address register. > @@ -341,44 +268,7 @@ WriteNvmeAdminSubmissionQueueBaseAddress ( > return EFI_SUCCESS; > } >=20 > -/** > - Read Nvm Express admin completion queue base address register. > - > - @param Private The pointer to the > NVME_CONTROLLER_PRIVATE_DATA data structure. > - @param Acq The buffer used to store admin completion que= ue base > address register content. > - > - @return EFI_SUCCESS Successfully read the admin completion queue = base > address register content. > - @return EFI_DEVICE_ERROR Fail to read the admin completion queue base > address register. > - > -**/ > -EFI_STATUS > -ReadNvmeAdminCompletionQueueBaseAddress ( > - IN NVME_CONTROLLER_PRIVATE_DATA *Private, > - IN NVME_ACQ *Acq > - ) > -{ > - EFI_PCI_IO_PROTOCOL *PciIo; > - EFI_STATUS Status; > - UINT64 Data; > - > - PciIo =3D Private->PciIo; >=20 > - Status =3D PciIo->Mem.Read ( > - PciIo, > - EfiPciIoWidthUint32, > - NVME_BAR, > - NVME_ACQ_OFFSET, > - 2, > - &Data > - ); > - > - if (EFI_ERROR(Status)) { > - return Status; > - } > - > - WriteUnaligned64 ((UINT64*)Acq, Data); > - return EFI_SUCCESS; > -} >=20 > /** > Write Nvm Express admin completion queue base address register. > -- > 2.18.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel