From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=hao.a.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D02ED210D5154 for ; Thu, 9 Aug 2018 19:45:24 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Aug 2018 19:45:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,217,1531810800"; d="scan'208";a="252883403" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga005.fm.intel.com with ESMTP; 09 Aug 2018 19:45:23 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 9 Aug 2018 19:45:23 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 9 Aug 2018 19:45:23 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.143]) by shsmsx102.ccr.corp.intel.com ([169.254.2.226]) with mapi id 14.03.0319.002; Fri, 10 Aug 2018 10:45:21 +0800 From: "Wu, Hao A" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Dong, Eric" , "Zeng, Star" Thread-Topic: [edk2] [PATCH 12/26] MdeModulePkg UfsPassThruDxe: Remove redundant functions Thread-Index: AQHULvSMd2gDXWqZ3Eafu053pSV9EaS4Sesw Date: Fri, 10 Aug 2018 02:45:20 +0000 Message-ID: References: <20180808084712.34696-1-shenglei.zhang@intel.com> <20180808084712.34696-13-shenglei.zhang@intel.com> In-Reply-To: <20180808084712.34696-13-shenglei.zhang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 12/26] MdeModulePkg UfsPassThruDxe: Remove redundant functions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Aug 2018 02:45:25 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Hao Wu Best Regards, Hao Wu > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > shenglei > Sent: Wednesday, August 08, 2018 4:47 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric; Zeng, Star > Subject: [edk2] [PATCH 12/26] MdeModulePkg UfsPassThruDxe: Remove > redundant functions >=20 > The functions that are never called have been removed. > They are UfsClearFlag and UfsFindAvailableSlotInTmrl. > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1062 >=20 > Cc: Star Zeng > Cc: Eric Dong > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: shenglei > --- > .../Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c | 49 ------------------- > 1 file changed, 49 deletions(-) >=20 > diff --git a/MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c > b/MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c > index e868c8c07e..5756f637fd 100644 > --- a/MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c > +++ b/MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c > @@ -753,31 +753,6 @@ UfsFindAvailableSlotInTrl ( > return EFI_NOT_READY; > } >=20 > -/** > - Find out available slot in task management transfer list of a UFS devi= ce. > - > - @param[in] Private The pointer to the UFS_PASS_THRU_PRIVATE_DAT= A > data structure. > - @param[out] Slot The available slot. > - > - @retval EFI_SUCCESS The available slot was found successfully. > - > -**/ > -EFI_STATUS > -UfsFindAvailableSlotInTmrl ( > - IN UFS_PASS_THRU_PRIVATE_DATA *Private, > - OUT UINT8 *Slot > - ) > -{ > - ASSERT ((Private !=3D NULL) && (Slot !=3D NULL)); > - > - // > - // The simplest algo to always use slot 0. > - // TODO: enhance it to support async transfer with multiple slot. > - // > - *Slot =3D 0; > - > - return EFI_SUCCESS; > -} >=20 > /** > Start specified slot in transfer list of a UFS device. > @@ -1229,31 +1204,7 @@ UfsSetFlag ( > return Status; > } >=20 > -/** > - Clear specified flag to 0 on a UFS device. > - > - @param[in] Private The pointer to the > UFS_PASS_THRU_PRIVATE_DATA data structure. > - @param[in] FlagId The ID of flag to be cleared. > - > - @retval EFI_SUCCESS The flag was cleared successfully. > - @retval EFI_DEVICE_ERROR A device error occurred while attempting= to > clear the flag. > - @retval EFI_TIMEOUT A timeout occurred while waiting for the > completion of clearing the flag. > - > -**/ > -EFI_STATUS > -UfsClearFlag ( > - IN UFS_PASS_THRU_PRIVATE_DATA *Private, > - IN UINT8 FlagId > - ) > -{ > - EFI_STATUS Status; > - UINT8 Value; > - > - Value =3D 0; > - Status =3D UfsRwFlags (Private, FALSE, FlagId, &Value); >=20 > - return Status; > -} >=20 > /** > Read specified flag from a UFS device. > -- > 2.18.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel