From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH v2 00/12] Add WinHost support in EmulatorPkg
Date: Mon, 27 Aug 2018 06:43:10 +0000 [thread overview]
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A0931E3C63C@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20180823095620.280996-1-ruiyu.ni@intel.com>
Hi Ray,
One small comment, below files:
\EmulatorPkg\Win\Host\WinGop.h
\EmulatorPkg\Win\Host\WinGopInput.c
have an CR line ending (rather than CRLF) at the last line.
Please help to correct the format.
With the changes, the series is good to me:
Reviewed-by: Hao Wu <hao.a.wu@intel.com>
Best Regards,
Hao Wu
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ruiyu
> Ni
> Sent: Thursday, August 23, 2018 5:56 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH v2 00/12] Add WinHost support in EmulatorPkg
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1112
>
> The patch sets add WinHost support (Nt32) in EmulatorPkg.
> 3 EmulatorPkg common issues were found and fixed.
> Other 9 patches are to step-by-step enable the WinHost.
>
> v2 sends to correct mail address.
>
> Ruiyu Ni (12):
> EmulatorPkg/ThunkProtocolList: Fix VS build failure
> EmulatorPkg/Win: Add Windows host support
> EmulatorPkg/Win: Enable source level debugging
> EmulatorPkg/Win: Enable native OS console as firmware console
> EmulatorPkg/Win: Add input/output support
> EmulatorPkg/Win: Add timer and interrupt support
> EmulatorPkg/Win: Add RTC support
> EmulatorPkg/Win: Add SimpleFileSystem support
> EmulatorPkg/Win: Add BlockIo support
> EmulatorPkg/PlatformBds: Signal EndOfDxe in platform BDS
> EmulatorPkg/EmuFileSystem: Fix a bug that causes Close() assertion
> EmulatorPkg/DSC: Remove FS mapping to EDK Shell bin directory
>
> .../EmuSimpleFileSystemDxe/EmuSimpleFileSystem.c | 33 +-
> EmulatorPkg/EmulatorPkg.dsc | 17 +-
> EmulatorPkg/Library/EmuBdsLib/BdsPlatform.c | 4 +-
> EmulatorPkg/Library/EmuBdsLib/BdsPlatform.h | 4 +-
> EmulatorPkg/Library/EmuBdsLib/EmuBdsLib.inf | 5 +-
> .../Library/ThunkProtocolList/ThunkProtocolList.c | 4 +-
> EmulatorPkg/Win/Host/WinBlockIo.c | 563 +++++
> EmulatorPkg/Win/Host/WinFileSystem.c | 2409
> ++++++++++++++++++++
> EmulatorPkg/Win/Host/WinGop.h | 204 ++
> EmulatorPkg/Win/Host/WinGopInput.c | 417 ++++
> EmulatorPkg/Win/Host/WinGopScreen.c | 872 +++++++
> EmulatorPkg/Win/Host/WinHost.c | 947 ++++++++
> EmulatorPkg/Win/Host/WinHost.h | 209 ++
> EmulatorPkg/Win/Host/WinHost.inf | 107 +
> EmulatorPkg/Win/Host/WinInclude.h | 75 +
> EmulatorPkg/Win/Host/WinMemoryAllocationLib.c | 178 ++
> EmulatorPkg/Win/Host/WinThunk.c | 577 +++++
> 17 files changed, 6614 insertions(+), 11 deletions(-)
> create mode 100644 EmulatorPkg/Win/Host/WinBlockIo.c
> create mode 100644 EmulatorPkg/Win/Host/WinFileSystem.c
> create mode 100644 EmulatorPkg/Win/Host/WinGop.h
> create mode 100644 EmulatorPkg/Win/Host/WinGopInput.c
> create mode 100644 EmulatorPkg/Win/Host/WinGopScreen.c
> create mode 100644 EmulatorPkg/Win/Host/WinHost.c
> create mode 100644 EmulatorPkg/Win/Host/WinHost.h
> create mode 100644 EmulatorPkg/Win/Host/WinHost.inf
> create mode 100644 EmulatorPkg/Win/Host/WinInclude.h
> create mode 100644 EmulatorPkg/Win/Host/WinMemoryAllocationLib.c
> create mode 100644 EmulatorPkg/Win/Host/WinThunk.c
>
> --
> 2.16.1.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2018-08-27 6:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 9:56 [PATCH v2 00/12] Add WinHost support in EmulatorPkg Ruiyu Ni
2018-08-23 9:56 ` [PATCH v2 01/12] EmulatorPkg/ThunkProtocolList: Fix VS build failure Ruiyu Ni
2018-08-23 9:56 ` [PATCH v2 02/12] EmulatorPkg/Win: Add Windows host support Ruiyu Ni
2018-08-23 9:56 ` [PATCH v2 03/12] EmulatorPkg/Win: Enable source level debugging Ruiyu Ni
2018-08-23 9:56 ` [PATCH v2 04/12] EmulatorPkg/Win: Enable native OS console as firmware console Ruiyu Ni
2018-08-23 9:56 ` [PATCH v2 05/12] EmulatorPkg/Win: Add input/output support Ruiyu Ni
2018-08-23 9:56 ` [PATCH v2 06/12] EmulatorPkg/Win: Add timer and interrupt support Ruiyu Ni
2018-08-23 9:56 ` [PATCH v2 07/12] EmulatorPkg/Win: Add RTC support Ruiyu Ni
2018-08-23 9:56 ` [PATCH v2 08/12] EmulatorPkg/Win: Add SimpleFileSystem support Ruiyu Ni
2018-08-23 9:56 ` [PATCH v2 09/12] EmulatorPkg/Win: Add BlockIo support Ruiyu Ni
2018-08-23 9:56 ` [PATCH v2 10/12] EmulatorPkg/PlatformBds: Signal EndOfDxe in platform BDS Ruiyu Ni
2018-08-23 9:56 ` [PATCH v2 11/12] EmulatorPkg/EmuFileSystem: Fix a bug that causes Close() assertion Ruiyu Ni
2018-08-23 9:56 ` [PATCH v2 12/12] EmulatorPkg/DSC: Remove FS mapping to EDK Shell bin directory Ruiyu Ni
2018-08-23 15:24 ` [PATCH v2 00/12] Add WinHost support in EmulatorPkg Kinney, Michael D
2018-08-23 16:27 ` Ni, Ruiyu
2018-08-27 6:43 ` Wu, Hao A [this message]
2018-08-30 1:57 ` Shia, Cinnamon
2018-09-04 2:32 ` Ni, Ruiyu
2018-09-04 3:12 ` krishnaLee
2018-09-04 15:12 ` Kinney, Michael D
2018-09-04 6:17 ` Shia, Cinnamon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B80AF82E9BFB8E4FBD8C89DA810C6A0931E3C63C@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox