From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH 00/10] Quality improvement for EmulatorPkg Win Host
Date: Wed, 29 Aug 2018 01:58:14 +0000 [thread overview]
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A0931E3CDC4@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20180827075330.269224-1-ruiyu.ni@intel.com>
Hi Ray,
One general-level comment, I saw some file was originally with Unix line
ending format (LF), but after the series, the line ending is in a mixed
state (both containing Unix LF & Windows CRLF). Can you help to perform
the line ending format cleanup for those files?
Also, please help to run the PatchCheck tool to verify the format of the
commits. Thanks in advance.
Best Regards,
Hao Wu
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ruiyu
> Ni
> Sent: Monday, August 27, 2018 3:53 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH 00/10] Quality improvement for EmulatorPkg Win Host
>
> The patch sets make Win Host boot in 64 bit, fix all SCT issues
> regarding to console input/output, switch to use MdeModulePkg/Bds.
>
> Ruiyu Ni (10):
> EmulatorPkg/EmuGopDxe: Fix TxtInEx.SetState SCT conformance failure
> EmulatorPkg/EmuGopDxe: Clear screen to black in GOP.SetMode
> EmulatorPkg/Win: Use FrameBufferBltLib for BLT operation
> EmulatorPkg/Win: ReadKeyStrokeEx() always returns correct KeyState
> EmulatorPkg/Win: Do not zero out file content
> EmulatorPkg/Win: Enable 64bit (SEC,PEI,DXE all run at 64bit)
> EmulatorPkg/AutoScanPei: Report the correct CPU address size
> EmulatorPkg/Win: Add VS2017 project file
> EmulatorPkg: Use MdeModulePkg/Bds module
> EmulatorPkg: IoThunk->Close() is called too early, may causing hang
>
> EmulatorPkg/AutoScanPei/AutoScanPei.c | 17 +-
> EmulatorPkg/EmuBlockIoDxe/EmuBlockIo.c | 14 +-
> EmulatorPkg/EmuGopDxe/GopInput.c | 11 +-
> EmulatorPkg/EmuGopDxe/GopScreen.c | 8 +-
> .../EmuSimpleFileSystemDxe/EmuSimpleFileSystem.c | 10 +-
> EmulatorPkg/EmuSnpDxe/EmuSnpDxe.c | 32 +-
> EmulatorPkg/EmulatorPkg.dsc | 38 +-
> EmulatorPkg/EmulatorPkg.fdf | 21 +-
> EmulatorPkg/Library/EmuBdsLib/BdsPlatform.c | 559 ---------------------
> EmulatorPkg/Library/PlatformBmLib/PlatformBm.c | 435
> ++++++++++++++++
> .../BdsPlatform.h => PlatformBmLib/PlatformBm.h} | 57 +--
> .../PlatformBmData.c} | 13 +-
> .../PlatformBmLib.inf} | 28 +-
> .../Library/PlatformBmLib/PlatformBmMemoryTest.c | 133 +++++
> EmulatorPkg/Win/Host/WinBlockIo.c | 30 +-
> EmulatorPkg/Win/Host/WinGop.h | 4 +-
> EmulatorPkg/Win/Host/WinGopInput.c | 17 +
> EmulatorPkg/Win/Host/WinGopScreen.c | 218 +++-----
> EmulatorPkg/Win/Host/WinHost.c | 2 +-
> EmulatorPkg/Win/Host/WinHost.inf | 1 +
> EmulatorPkg/Win/VS2017/BuildVS.bat | 3 +
> EmulatorPkg/Win/VS2017/Win.sln | 31 ++
> EmulatorPkg/Win/VS2017/Win.vcxproj | 120 +++++
> EmulatorPkg/Win/VS2017/Win.vcxproj.filters | 50 ++
> EmulatorPkg/Win/VS2017/Win.vcxproj.user | 13 +
> 25 files changed, 1046 insertions(+), 819 deletions(-)
> delete mode 100644 EmulatorPkg/Library/EmuBdsLib/BdsPlatform.c
> create mode 100644 EmulatorPkg/Library/PlatformBmLib/PlatformBm.c
> rename EmulatorPkg/Library/{EmuBdsLib/BdsPlatform.h =>
> PlatformBmLib/PlatformBm.h} (62%)
> rename EmulatorPkg/Library/{EmuBdsLib/PlatformData.c =>
> PlatformBmLib/PlatformBmData.c} (77%)
> rename EmulatorPkg/Library/{EmuBdsLib/EmuBdsLib.inf =>
> PlatformBmLib/PlatformBmLib.inf} (71%)
> create mode 100644
> EmulatorPkg/Library/PlatformBmLib/PlatformBmMemoryTest.c
> create mode 100644 EmulatorPkg/Win/VS2017/BuildVS.bat
> create mode 100644 EmulatorPkg/Win/VS2017/Win.sln
> create mode 100644 EmulatorPkg/Win/VS2017/Win.vcxproj
> create mode 100644 EmulatorPkg/Win/VS2017/Win.vcxproj.filters
> create mode 100644 EmulatorPkg/Win/VS2017/Win.vcxproj.user
>
> --
> 2.16.1.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2018-08-29 1:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-27 7:53 [PATCH 00/10] Quality improvement for EmulatorPkg Win Host Ruiyu Ni
2018-08-27 7:53 ` [PATCH 01/10] EmulatorPkg/EmuGopDxe: Fix TxtInEx.SetState SCT conformance failure Ruiyu Ni
2018-08-27 7:53 ` [PATCH 02/10] EmulatorPkg/EmuGopDxe: Clear screen to black in GOP.SetMode Ruiyu Ni
2018-08-27 7:53 ` [PATCH 03/10] EmulatorPkg/Win: Use FrameBufferBltLib for BLT operation Ruiyu Ni
2018-08-27 7:53 ` [PATCH 04/10] EmulatorPkg/Win: ReadKeyStrokeEx() always returns correct KeyState Ruiyu Ni
2018-08-27 7:53 ` [PATCH 05/10] EmulatorPkg/Win: Do not zero out file content Ruiyu Ni
2018-08-29 1:51 ` Wu, Hao A
2018-08-27 7:53 ` [PATCH 06/10] EmulatorPkg/Win: Enable 64bit (SEC, PEI, DXE all run at 64bit) Ruiyu Ni
2018-08-27 7:53 ` [PATCH 07/10] EmulatorPkg/AutoScanPei: Report the correct CPU address size Ruiyu Ni
2018-08-29 1:54 ` Wu, Hao A
2018-08-29 2:53 ` Ni, Ruiyu
2018-08-27 7:53 ` [PATCH 08/10] EmulatorPkg/Win: Add VS2017 project file Ruiyu Ni
2018-08-27 7:53 ` [PATCH 09/10] EmulatorPkg: Use MdeModulePkg/Bds module Ruiyu Ni
2018-08-27 7:53 ` [PATCH 10/10] EmulatorPkg: IoThunk->Close() is called too early, may causing hang Ruiyu Ni
2018-08-29 1:58 ` Wu, Hao A [this message]
2018-08-29 3:41 ` [PATCH 00/10] Quality improvement for EmulatorPkg Win Host Ni, Ruiyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B80AF82E9BFB8E4FBD8C89DA810C6A0931E3CDC4@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox