From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=hao.a.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EAF3521103DA9 for ; Tue, 28 Aug 2018 18:58:17 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Aug 2018 18:58:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,301,1531810800"; d="scan'208";a="258052040" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga005.fm.intel.com with ESMTP; 28 Aug 2018 18:58:16 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 28 Aug 2018 18:58:16 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 28 Aug 2018 18:58:16 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.143]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.150]) with mapi id 14.03.0319.002; Wed, 29 Aug 2018 09:58:14 +0800 From: "Wu, Hao A" To: "Ni, Ruiyu" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH 00/10] Quality improvement for EmulatorPkg Win Host Thread-Index: AQHUPdr3U5CxQlH5nU+BzbqK9cP8dqTV+6jg Date: Wed, 29 Aug 2018 01:58:14 +0000 Message-ID: References: <20180827075330.269224-1-ruiyu.ni@intel.com> In-Reply-To: <20180827075330.269224-1-ruiyu.ni@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 00/10] Quality improvement for EmulatorPkg Win Host X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Aug 2018 01:58:18 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Ray, One general-level comment, I saw some file was originally with Unix line ending format (LF), but after the series, the line ending is in a mixed state (both containing Unix LF & Windows CRLF). Can you help to perform the line ending format cleanup for those files? Also, please help to run the PatchCheck tool to verify the format of the commits. Thanks in advance. Best Regards, Hao Wu > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ru= iyu > Ni > Sent: Monday, August 27, 2018 3:53 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH 00/10] Quality improvement for EmulatorPkg Win Hos= t >=20 > The patch sets make Win Host boot in 64 bit, fix all SCT issues > regarding to console input/output, switch to use MdeModulePkg/Bds. >=20 > Ruiyu Ni (10): > EmulatorPkg/EmuGopDxe: Fix TxtInEx.SetState SCT conformance failure > EmulatorPkg/EmuGopDxe: Clear screen to black in GOP.SetMode > EmulatorPkg/Win: Use FrameBufferBltLib for BLT operation > EmulatorPkg/Win: ReadKeyStrokeEx() always returns correct KeyState > EmulatorPkg/Win: Do not zero out file content > EmulatorPkg/Win: Enable 64bit (SEC,PEI,DXE all run at 64bit) > EmulatorPkg/AutoScanPei: Report the correct CPU address size > EmulatorPkg/Win: Add VS2017 project file > EmulatorPkg: Use MdeModulePkg/Bds module > EmulatorPkg: IoThunk->Close() is called too early, may causing hang >=20 > EmulatorPkg/AutoScanPei/AutoScanPei.c | 17 +- > EmulatorPkg/EmuBlockIoDxe/EmuBlockIo.c | 14 +- > EmulatorPkg/EmuGopDxe/GopInput.c | 11 +- > EmulatorPkg/EmuGopDxe/GopScreen.c | 8 +- > .../EmuSimpleFileSystemDxe/EmuSimpleFileSystem.c | 10 +- > EmulatorPkg/EmuSnpDxe/EmuSnpDxe.c | 32 +- > EmulatorPkg/EmulatorPkg.dsc | 38 +- > EmulatorPkg/EmulatorPkg.fdf | 21 +- > EmulatorPkg/Library/EmuBdsLib/BdsPlatform.c | 559 ---------------= ------ > EmulatorPkg/Library/PlatformBmLib/PlatformBm.c | 435 > ++++++++++++++++ > .../BdsPlatform.h =3D> PlatformBmLib/PlatformBm.h} | 57 +-- > .../PlatformBmData.c} | 13 +- > .../PlatformBmLib.inf} | 28 +- > .../Library/PlatformBmLib/PlatformBmMemoryTest.c | 133 +++++ > EmulatorPkg/Win/Host/WinBlockIo.c | 30 +- > EmulatorPkg/Win/Host/WinGop.h | 4 +- > EmulatorPkg/Win/Host/WinGopInput.c | 17 + > EmulatorPkg/Win/Host/WinGopScreen.c | 218 +++----- > EmulatorPkg/Win/Host/WinHost.c | 2 +- > EmulatorPkg/Win/Host/WinHost.inf | 1 + > EmulatorPkg/Win/VS2017/BuildVS.bat | 3 + > EmulatorPkg/Win/VS2017/Win.sln | 31 ++ > EmulatorPkg/Win/VS2017/Win.vcxproj | 120 +++++ > EmulatorPkg/Win/VS2017/Win.vcxproj.filters | 50 ++ > EmulatorPkg/Win/VS2017/Win.vcxproj.user | 13 + > 25 files changed, 1046 insertions(+), 819 deletions(-) > delete mode 100644 EmulatorPkg/Library/EmuBdsLib/BdsPlatform.c > create mode 100644 EmulatorPkg/Library/PlatformBmLib/PlatformBm.c > rename EmulatorPkg/Library/{EmuBdsLib/BdsPlatform.h =3D> > PlatformBmLib/PlatformBm.h} (62%) > rename EmulatorPkg/Library/{EmuBdsLib/PlatformData.c =3D> > PlatformBmLib/PlatformBmData.c} (77%) > rename EmulatorPkg/Library/{EmuBdsLib/EmuBdsLib.inf =3D> > PlatformBmLib/PlatformBmLib.inf} (71%) > create mode 100644 > EmulatorPkg/Library/PlatformBmLib/PlatformBmMemoryTest.c > create mode 100644 EmulatorPkg/Win/VS2017/BuildVS.bat > create mode 100644 EmulatorPkg/Win/VS2017/Win.sln > create mode 100644 EmulatorPkg/Win/VS2017/Win.vcxproj > create mode 100644 EmulatorPkg/Win/VS2017/Win.vcxproj.filters > create mode 100644 EmulatorPkg/Win/VS2017/Win.vcxproj.user >=20 > -- > 2.16.1.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel