From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH v2 0/9] Quality improvement for EmulatorPkg Win Host
Date: Thu, 30 Aug 2018 05:22:53 +0000 [thread overview]
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A0931E3D56B@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20180830020213.148968-1-ruiyu.ni@intel.com>
The series is good to me.
Reviewed-by: Hao Wu <hao.a.wu@intel.com>
Best Regards,
Hao Wu
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ruiyu
> Ni
> Sent: Thursday, August 30, 2018 10:02 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH v2 0/9] Quality improvement for EmulatorPkg Win Host
>
> The patch sets make Win Host boot in 64 bit, fix all SCT issues
> regarding to console input/output, switch to use MdeModulePkg/Bds.
>
> v2: 1. Pass PatchChecker.py (VS project files don't pass. I don't want
> to change the default file content because next time when VS
> opens the project again the file content will be restored back)
> 2. Skip the V1 5/10 "Do not zero out file content" because the
> current behavior is already to not zero out file content.
> 3. Always report 57 as CPU address size through CPU HOB.
>
> Ruiyu Ni (9):
> EmulatorPkg/EmuGopDxe: Fix TxtInEx.SetState SCT conformance failure
> EmulatorPkg/EmuGopDxe: Clear screen to black in GOP.SetMode
> EmulatorPkg/Win: Use FrameBufferBltLib for BLT operation
> EmulatorPkg/Win: ReadKeyStrokeEx() always returns correct KeyState
> EmulatorPkg/Win: Enable 64bit (SEC,PEI,DXE all run at 64bit)
> EmulatorPkg/AutoScanPei: Report the correct CPU address size
> EmulatorPkg/Win: Add VS2017 project file
> EmulatorPkg: Use MdeModulePkg/Bds module
> EmulatorPkg: IoThunk->Close() is called too early, may causing hang
>
> EmulatorPkg/AutoScanPei/AutoScanPei.c | 6 +-
> EmulatorPkg/EmuBlockIoDxe/EmuBlockIo.c | 14 +-
> EmulatorPkg/EmuGopDxe/GopInput.c | 11 +-
> EmulatorPkg/EmuGopDxe/GopScreen.c | 8 +-
> .../EmuSimpleFileSystemDxe/EmuSimpleFileSystem.c | 10 +-
> EmulatorPkg/EmuSnpDxe/EmuSnpDxe.c | 32 +-
> EmulatorPkg/EmulatorPkg.dsc | 38 +-
> EmulatorPkg/EmulatorPkg.fdf | 21 +-
> EmulatorPkg/Library/EmuBdsLib/BdsPlatform.c | 559 ---------------------
> EmulatorPkg/Library/PlatformBmLib/PlatformBm.c | 435
> ++++++++++++++++
> .../BdsPlatform.h => PlatformBmLib/PlatformBm.h} | 63 ++-
> .../PlatformBmData.c} | 13 +-
> .../PlatformBmLib.inf} | 28 +-
> .../Library/PlatformBmLib/PlatformBmMemoryTest.c | 133 +++++
> EmulatorPkg/Win/Host/WinBlockIo.c | 2 +-
> EmulatorPkg/Win/Host/WinGop.h | 4 +-
> EmulatorPkg/Win/Host/WinGopInput.c | 17 +
> EmulatorPkg/Win/Host/WinGopScreen.c | 218 +++-----
> EmulatorPkg/Win/Host/WinHost.c | 2 +-
> EmulatorPkg/Win/Host/WinHost.inf | 1 +
> EmulatorPkg/Win/VS2017/BuildVS.bat | 3 +
> EmulatorPkg/Win/VS2017/Win.sln | 25 +
> EmulatorPkg/Win/VS2017/Win.vcxproj | 120 +++++
> EmulatorPkg/Win/VS2017/Win.vcxproj.filters | 50 ++
> EmulatorPkg/Win/VS2017/Win.vcxproj.user | 13 +
> 25 files changed, 1008 insertions(+), 818 deletions(-)
> delete mode 100644 EmulatorPkg/Library/EmuBdsLib/BdsPlatform.c
> create mode 100644 EmulatorPkg/Library/PlatformBmLib/PlatformBm.c
> rename EmulatorPkg/Library/{EmuBdsLib/BdsPlatform.h =>
> PlatformBmLib/PlatformBm.h} (60%)
> rename EmulatorPkg/Library/{EmuBdsLib/PlatformData.c =>
> PlatformBmLib/PlatformBmData.c} (77%)
> rename EmulatorPkg/Library/{EmuBdsLib/EmuBdsLib.inf =>
> PlatformBmLib/PlatformBmLib.inf} (71%)
> create mode 100644
> EmulatorPkg/Library/PlatformBmLib/PlatformBmMemoryTest.c
> create mode 100644 EmulatorPkg/Win/VS2017/BuildVS.bat
> create mode 100644 EmulatorPkg/Win/VS2017/Win.sln
> create mode 100644 EmulatorPkg/Win/VS2017/Win.vcxproj
> create mode 100644 EmulatorPkg/Win/VS2017/Win.vcxproj.filters
> create mode 100644 EmulatorPkg/Win/VS2017/Win.vcxproj.user
>
> --
> 2.16.1.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2018-08-30 5:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 2:02 [PATCH v2 0/9] Quality improvement for EmulatorPkg Win Host Ruiyu Ni
2018-08-30 2:02 ` [PATCH v2 1/9] EmulatorPkg/EmuGopDxe: Fix TxtInEx.SetState SCT conformance failure Ruiyu Ni
2018-08-30 2:02 ` [PATCH v2 2/9] EmulatorPkg/EmuGopDxe: Clear screen to black in GOP.SetMode Ruiyu Ni
2018-08-30 2:02 ` [PATCH v2 3/9] EmulatorPkg/Win: Use FrameBufferBltLib for BLT operation Ruiyu Ni
2018-08-30 2:02 ` [PATCH v2 4/9] EmulatorPkg/Win: ReadKeyStrokeEx() always returns correct KeyState Ruiyu Ni
2018-08-30 2:02 ` [PATCH v2 5/9] EmulatorPkg/Win: Enable 64bit (SEC, PEI, DXE all run at 64bit) Ruiyu Ni
2018-08-30 2:02 ` [PATCH v2 6/9] EmulatorPkg/AutoScanPei: Report the correct CPU address size Ruiyu Ni
2018-08-30 2:02 ` [PATCH v2 7/9] EmulatorPkg/Win: Add VS2017 project file Ruiyu Ni
2018-08-30 2:02 ` [PATCH v2 8/9] EmulatorPkg: Use MdeModulePkg/Bds module Ruiyu Ni
2018-08-30 2:02 ` [PATCH v2 9/9] EmulatorPkg: IoThunk->Close() is called too early, may causing hang Ruiyu Ni
2018-08-30 5:22 ` Wu, Hao A [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B80AF82E9BFB8E4FBD8C89DA810C6A0931E3D56B@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox