From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=hao.a.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DB8F621148440 for ; Wed, 19 Sep 2018 23:50:07 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Sep 2018 23:50:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,397,1531810800"; d="scan'208";a="74745041" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga008.jf.intel.com with ESMTP; 19 Sep 2018 23:49:52 -0700 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 19 Sep 2018 23:49:51 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 19 Sep 2018 23:49:50 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.227]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.226]) with mapi id 14.03.0319.002; Thu, 20 Sep 2018 14:49:49 +0800 From: "Wu, Hao A" To: "Dong, Eric" , "edk2-devel@lists.01.org" CC: "Chu, Maggie" Thread-Topic: [Patch] SecurityPkg/TcgStorageOpalLib: Fixed correct user password not works issue. Thread-Index: AQHUTjQUFjUQID4910eLDiFzMpANAaT4v7cA Date: Thu, 20 Sep 2018 06:49:48 +0000 Message-ID: References: <20180917031054.27428-1-eric.dong@intel.com> In-Reply-To: <20180917031054.27428-1-eric.dong@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] SecurityPkg/TcgStorageOpalLib: Fixed correct user password not works issue. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Sep 2018 06:50:08 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Hao Wu Best Regards, Hao Wu > -----Original Message----- > From: Dong, Eric > Sent: Monday, September 17, 2018 11:11 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A; Chu, Maggie > Subject: [Patch] SecurityPkg/TcgStorageOpalLib: Fixed correct user passwo= rd > not works issue. >=20 > After admin password reach the TryLimit value, code logic will direct ret= urn > error password result no matter which password been inputted. So even cor= rect > user password will return TryLimit error. >=20 > Now update code logic to also check user password. Only when both > user/admin > password reach the TryLimit count, code will return exceed TryLimit error= . >=20 > Cc: Wu Hao > Cc: Chu Maggie > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Eric Dong > --- > SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalUtil.c | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalUtil.c > b/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalUtil.c > index 3c4a8e9001..f2febc0a0c 100644 > --- a/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalUtil.c > +++ b/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalUtil.c > @@ -763,7 +763,6 @@ OpalUtilUpdateGlobalLockingRange( >=20 > if (MethodStatus =3D=3D > TCG_METHOD_STATUS_CODE_AUTHORITY_LOCKED_OUT) { > DEBUG ((DEBUG_INFO, "unlock as admin failed with > AUTHORITY_LOCKED_OUT\n")); > - goto done; > } >=20 > // > -- > 2.15.0.windows.1