public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "Zeng, Star" <star.zeng@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Ni, Ruiyu" <ruiyu.ni@intel.com>
Subject: Re: [PATCH v1 7/7] MdeModulePkg/UdfDxe: Handle dead codes in FileSystemOperations.c
Date: Tue, 16 Oct 2018 07:55:00 +0000	[thread overview]
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A093C82B288@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <f4883ea3-7f57-70cf-89fa-196be9ff1e15@intel.com>

> -----Original Message-----
> From: Zeng, Star
> Sent: Tuesday, October 16, 2018 3:50 PM
> To: Wu, Hao A; edk2-devel@lists.01.org
> Cc: Ni, Ruiyu; Zeng, Star
> Subject: Re: [edk2] [PATCH v1 7/7] MdeModulePkg/UdfDxe: Handle dead
> codes in FileSystemOperations.c
> 
> On 2018/10/16 14:59, Zeng, Star wrote:
> > On 2018/10/15 12:55, Hao Wu wrote:
> >> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1249
> >>
> >> We found potential dead codes within File.c during the code coverage
> >> test.
> >>
> >> After manual review, we think the below ones are positive reports:
> >>
> >> A. For function GetAllocationDescriptor():
> >> Due to the all the calling places for this function, the input parameter
> >> 'RecordingFlags' can only with value 'LongAdsSequence' or
> >> 'ShortAdsSequence'.
> >>
> >> So the below code will never be reached:
> >>
> >>    return EFI_DEVICE_ERROR;
> >>
> >> This commit will add "ASSERT (FALSE);" before the above line to indicate
> >> this.
> >>
> >> B. For function GetAllocationDescriptorLsn():
> >> Due to the all the calling places for this function, the input parameter
> >> 'RecordingFlags' can only with value 'LongAdsSequence' or
> >> 'ShortAdsSequence'.
> >>
> >> So the below code will never be reached:
> >>
> >>    return EFI_UNSUPPORTED;
> >>
> >> This commit will add "ASSERT (FALSE);" before the above line to indicate
> >> this.
> >>
> >> C. For function SetFileInfo():
> >> Due to the all the calling places for this function, the input parameter
> >> 'FileName' will never be a NULL pointer.
> >>
> >> So the below codes will never be reached:
> >>
> >>    } else {
> >>      FileInfo->FileName[0] = '\0';
> >>    }
> >>
> >> This commit will add "ASSERT (FALSE);" before the above lines to indicate
> >> this.
> >
> > Hao,
> >
> > Thanks for the patch.
> >
> > I think we should see what is the expected value for the parameter, but
> > not see how caller uses the parameter.
> >  From this point of view, I think the C case is valid and may be no need
> > to change.
> 
> More information about the C case. There are two places in the function
> to handle FileName == NULL, but this patch only updates one place. If
> the patch wants to forbid the function to accept FileName == NULL, it
> should update those two places and update function description at the
> same time. Otherwise keep the function no change.
> 

Got it. I will update the series accordingly.

Best Regards,
Hao Wu

> Thanks,
> Star
> 
> >
> >
> > Thanks,
> > Star
> >
> >>
> >> Cc: Paulo Alcantara <paulo@paulo.ac>
> >> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> >> Cc: Star Zeng <star.zeng@intel.com>
> >> Contributed-under: TianoCore Contribution Agreement 1.1
> >> Signed-off-by: Hao Wu <hao.a.wu@intel.com>
> >> ---
> >>   MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c | 12
> >> ++++++++++++
> >>   1 file changed, 12 insertions(+)
> >>
> >> diff --git
> a/MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c
> >> b/MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c
> >> index 1400846bf1..19acd0554c 100644
> >> --- a/MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c
> >> +++ b/MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c
> >> @@ -738,6 +738,10 @@ GetAllocationDescriptor (
> >>         );
> >>     }
> >> +  //
> >> +  // Code should never reach here.
> >> +  //
> >> +  ASSERT (FALSE);
> >>     return EFI_DEVICE_ERROR;
> >>   }
> >> @@ -784,6 +788,10 @@ GetAllocationDescriptorLsn (
> >>       return EFI_SUCCESS;
> >>     }
> >> +  //
> >> +  // Code should never reach here.
> >> +  //
> >> +  ASSERT (FALSE);
> >>     return EFI_UNSUPPORTED;
> >>   }
> >> @@ -2413,6 +2421,10 @@ SetFileInfo (
> >>     if (FileName != NULL) {
> >>       StrCpyS (FileInfo->FileName, StrLen (FileName) + 1, FileName);
> >>     } else {
> >> +    //
> >> +    // Code should never reach here.
> >> +    //
> >> +    ASSERT (FALSE);
> >>       FileInfo->FileName[0] = '\0';
> >>     }
> >>


  reply	other threads:[~2018-10-16  7:55 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-15  4:55 [PATCH v1 0/7] Code refinements in UdfDxe Hao Wu
2018-10-15  4:55 ` [PATCH v1 1/7] MdeModulePkg/UdfDxe: Use error handling for memory allocation failure Hao Wu
2018-10-15  4:55 ` [PATCH v1 2/7] MdeModulePkg/UdfDxe: ASSERT for false positives of NULL ptr deref Hao Wu
2018-10-15  4:55 ` [PATCH v1 3/7] MdeModulePkg/UdfDxe: Use error handling when fail to return LSN Hao Wu
2018-10-15  4:55 ` [PATCH v1 4/7] MdeModulePkg/UdfDxe: Use debug msg instead of ASSERT in UdfOpen() Hao Wu
2018-10-15  4:55 ` [PATCH v1 5/7] MdeModulePkg/UdfDxe: Handle dead codes in File.c Hao Wu
2018-10-15  4:55 ` [PATCH v1 6/7] MdeModulePkg/UdfDxe: Remove dead codes in FileName.c Hao Wu
2018-10-16  6:20   ` Leif Lindholm
2018-10-16  6:28     ` Wu, Hao A
2018-10-16  7:46       ` Zeng, Star
2018-10-16  7:55         ` Wu, Hao A
2018-10-15  4:55 ` [PATCH v1 7/7] MdeModulePkg/UdfDxe: Handle dead codes in FileSystemOperations.c Hao Wu
2018-10-16  6:59   ` Zeng, Star
2018-10-16  7:50     ` Zeng, Star
2018-10-16  7:55       ` Wu, Hao A [this message]
2018-10-15 11:39 ` [PATCH v1 0/7] Code refinements in UdfDxe Paulo Alcantara
2018-10-16  6:20 ` Zeng, Star

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B80AF82E9BFB8E4FBD8C89DA810C6A093C82B288@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox