From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "Zeng, Star" <star.zeng@intel.com>,
Paulo Alcantara <paulo@paulo.ac>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Ni, Ruiyu" <ruiyu.ni@intel.com>, "Yao, Jiewen" <jiewen.yao@intel.com>
Subject: Re: [PATCH v1 00/10] UDF: Bugfixes
Date: Tue, 23 Oct 2018 06:10:18 +0000 [thread overview]
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A093C838386@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <95020a46-058c-d19f-9d6b-bdcd8c778065@intel.com>
> -----Original Message-----
> From: Zeng, Star
> Sent: Tuesday, October 23, 2018 1:46 PM
> To: Paulo Alcantara; Wu, Hao A; edk2-devel@lists.01.org
> Cc: Ni, Ruiyu; Yao, Jiewen; Zeng, Star
> Subject: Re: [edk2] [PATCH v1 00/10] UDF: Bugfixes
>
> On 2018/10/22 22:39, Paulo Alcantara wrote:
> > Hao Wu <hao.a.wu@intel.com> writes:
> >
> >> The series will address a couple of bugs within the UDF related codes.
> >>
> >> Please refer to the log message of each commit for more details.
> >>
> >> Cc: Paulo Alcantara <paulo@paulo.ac>
> >> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> >> Cc: Jiewen Yao <jiewen.yao@intel.com>
> >> Cc: Star Zeng <star.zeng@intel.com>
> >>
> >> Hao Wu (10):
> >> MdeModulePkg/PartitionDxe: Add check for underlying device block size
> >> MdeModulePkg/UdfDxe: Refine boundary checks for file/path name
> string
> >> MdeModulePkg/UdfDxe: Add boundary check the read of FE/EFE
> >> MdeModulePkg/UdfDxe: Add boundary check for ComponentIdentifier
> decode
> >> MdeModulePkg/UdfDxe: Add boundary check for getting volume (free)
> size
> >> MdeModulePkg/UdfDxe: Correct behavior for UdfSetPosition()
> >> MdeModulePkg/UdfDxe: Fix a typo within SetFileInfo()
> >> MdeModulePkg/UdfDxe: Update GetInfo() for FS VolumeLabel info
> request
> >> MdeModulePkg/UdfDxe: Add more check when getting PD from LongAd
> >> MdeModulePkg/UdfDxe: Avoid possible use of already-freed data
> >>
> >> MdeModulePkg/Universal/Disk/PartitionDxe/Udf.c | 28 +++
> >> MdeModulePkg/Universal/Disk/UdfDxe/File.c | 96 ++++----
> >> MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c | 253
> ++++++++++++++++++--
> >> MdeModulePkg/Universal/Disk/UdfDxe/Udf.h | 63 ++++-
> >> MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf | 1 +
> >> 5 files changed, 362 insertions(+), 79 deletions(-)
> >
> > For the series:
> >
> > Reviewed-by: Paulo Alcantara <palcantara@suse.de>
>
> I could not review the in detail.
> Thanks Paulo's Reviewed-by.
>
> I have two minor feedback.
> 1. I saw some place using 'basic validations' and some place using
> 'basic validation', should they be aligned?
> 2. I think you can add "Copyright (c) 2018, Intel Corporation. All
> rights reserved.<BR>" for every file you changed.
>
> Acked-by: Star Zeng <star.zeng@intel.com>
Thanks. I will address the above 2 points before push.
Best Regards,
Hao Wu
>
> Thanks,
> Star
>
> >
> > Thanks!
> > Paulo
> >
next prev parent reply other threads:[~2018-10-23 6:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 7:23 [PATCH v1 00/10] UDF: Bugfixes Hao Wu
2018-10-16 7:23 ` [PATCH v1 01/10] MdeModulePkg/PartitionDxe: Add check for underlying device block size Hao Wu
2018-10-16 7:23 ` [PATCH v1 02/10] MdeModulePkg/UdfDxe: Refine boundary checks for file/path name string Hao Wu
2018-10-16 7:23 ` [PATCH v1 03/10] MdeModulePkg/UdfDxe: Add boundary check the read of FE/EFE Hao Wu
2018-10-16 7:23 ` [PATCH v1 04/10] MdeModulePkg/UdfDxe: Add boundary check for ComponentIdentifier decode Hao Wu
2018-10-16 7:23 ` [PATCH v1 05/10] MdeModulePkg/UdfDxe: Add boundary check for getting volume (free) size Hao Wu
2018-10-16 7:23 ` [PATCH v1 06/10] MdeModulePkg/UdfDxe: Correct behavior for UdfSetPosition() Hao Wu
2018-10-16 7:23 ` [PATCH v1 07/10] MdeModulePkg/UdfDxe: Fix a typo within SetFileInfo() Hao Wu
2018-10-16 7:23 ` [PATCH v1 08/10] MdeModulePkg/UdfDxe: Update GetInfo() for FS VolumeLabel info request Hao Wu
2018-10-16 7:23 ` [PATCH v1 09/10] MdeModulePkg/UdfDxe: Add more check when getting PD from LongAd Hao Wu
2018-10-16 7:23 ` [PATCH v1 10/10] MdeModulePkg/UdfDxe: Avoid possible use of already-freed data Hao Wu
2018-10-22 14:39 ` [PATCH v1 00/10] UDF: Bugfixes Paulo Alcantara
2018-10-23 5:45 ` Zeng, Star
2018-10-23 6:10 ` Wu, Hao A [this message]
2018-10-23 12:28 ` Wu, Hao A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B80AF82E9BFB8E4FBD8C89DA810C6A093C838386@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox