From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=hao.a.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 699F82117B555 for ; Tue, 23 Oct 2018 05:28:28 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Oct 2018 05:28:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,416,1534834800"; d="scan'208";a="94303399" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga003.jf.intel.com with ESMTP; 23 Oct 2018 05:28:27 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 23 Oct 2018 05:28:27 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 23 Oct 2018 05:28:26 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.21]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.131]) with mapi id 14.03.0319.002; Tue, 23 Oct 2018 20:28:25 +0800 From: "Wu, Hao A" To: "Zeng, Star" , Paulo Alcantara , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" , "Yao, Jiewen" Thread-Topic: [edk2] [PATCH v1 00/10] UDF: Bugfixes Thread-Index: AQHUZSEt6tosUcWPBkaXP8AABAyLLqUq2daAgAD9DICAAIzWQIAAaVAA Date: Tue, 23 Oct 2018 12:28:24 +0000 Message-ID: References: <20181016072340.22068-1-hao.a.wu@intel.com> <877eia3v0i.fsf@paulo.ac> <95020a46-058c-d19f-9d6b-bdcd8c778065@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v1 00/10] UDF: Bugfixes X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Oct 2018 12:28:28 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Paulo and Star, Thanks a lot for the review. Series pushed at 4df8f5bfa2.. 68099b52b0. Best Regards, Hao Wu > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Wu= , > Hao A > Sent: Tuesday, October 23, 2018 2:10 PM > To: Zeng, Star; Paulo Alcantara; edk2-devel@lists.01.org > Cc: Ni, Ruiyu; Yao, Jiewen > Subject: Re: [edk2] [PATCH v1 00/10] UDF: Bugfixes >=20 > > -----Original Message----- > > From: Zeng, Star > > Sent: Tuesday, October 23, 2018 1:46 PM > > To: Paulo Alcantara; Wu, Hao A; edk2-devel@lists.01.org > > Cc: Ni, Ruiyu; Yao, Jiewen; Zeng, Star > > Subject: Re: [edk2] [PATCH v1 00/10] UDF: Bugfixes > > > > On 2018/10/22 22:39, Paulo Alcantara wrote: > > > Hao Wu writes: > > > > > >> The series will address a couple of bugs within the UDF related code= s. > > >> > > >> Please refer to the log message of each commit for more details. > > >> > > >> Cc: Paulo Alcantara > > >> Cc: Ruiyu Ni > > >> Cc: Jiewen Yao > > >> Cc: Star Zeng > > >> > > >> Hao Wu (10): > > >> MdeModulePkg/PartitionDxe: Add check for underlying device block > size > > >> MdeModulePkg/UdfDxe: Refine boundary checks for file/path name > > string > > >> MdeModulePkg/UdfDxe: Add boundary check the read of FE/EFE > > >> MdeModulePkg/UdfDxe: Add boundary check for ComponentIdentifier > > decode > > >> MdeModulePkg/UdfDxe: Add boundary check for getting volume (free) > > size > > >> MdeModulePkg/UdfDxe: Correct behavior for UdfSetPosition() > > >> MdeModulePkg/UdfDxe: Fix a typo within SetFileInfo() > > >> MdeModulePkg/UdfDxe: Update GetInfo() for FS VolumeLabel info > > request > > >> MdeModulePkg/UdfDxe: Add more check when getting PD from LongAd > > >> MdeModulePkg/UdfDxe: Avoid possible use of already-freed data > > >> > > >> MdeModulePkg/Universal/Disk/PartitionDxe/Udf.c | 28 ++= + > > >> MdeModulePkg/Universal/Disk/UdfDxe/File.c | 96 ++= ++---- > > >> MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c | 253 > > ++++++++++++++++++-- > > >> MdeModulePkg/Universal/Disk/UdfDxe/Udf.h | 63 ++= ++- > > >> MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf | 1 + > > >> 5 files changed, 362 insertions(+), 79 deletions(-) > > > > > > For the series: > > > > > > Reviewed-by: Paulo Alcantara > > > > I could not review the in detail. > > Thanks Paulo's Reviewed-by. > > > > I have two minor feedback. > > 1. I saw some place using 'basic validations' and some place using > > 'basic validation', should they be aligned? > > 2. I think you can add "Copyright (c) 2018, Intel Corporation. All > > rights reserved.
" for every file you changed. > > > > Acked-by: Star Zeng >=20 > Thanks. I will address the above 2 points before push. >=20 > Best Regards, > Hao Wu >=20 > > > > Thanks, > > Star > > > > > > > > Thanks! > > > Paulo > > > >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel