From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=hao.a.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 53D652194D387 for ; Tue, 23 Oct 2018 17:59:06 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Oct 2018 17:59:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,418,1534834800"; d="scan'208";a="100127715" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga004.fm.intel.com with ESMTP; 23 Oct 2018 17:59:05 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 23 Oct 2018 17:59:04 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.117]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.102]) with mapi id 14.03.0415.000; Wed, 24 Oct 2018 08:59:02 +0800 From: "Wu, Hao A" To: "Ni, Ruiyu" , "edk2-devel@lists.01.org" CC: "Yao, Jiewen" , "Zeng, Star" Thread-Topic: [PATCH v1 3/3] MdeModulePkg/NvmExpressDxe: Refine PassThru IO queue creation behavior Thread-Index: AQHUZq26QktUiyANzUG0M10RP7bekaUsCEuAgAGS9tA= Date: Wed, 24 Oct 2018 00:59:02 +0000 Message-ID: References: <20181018064200.2068-1-hao.a.wu@intel.com> <20181018064200.2068-4-hao.a.wu@intel.com> <5774f193-fc94-a08c-9093-932363b648f2@Intel.com> In-Reply-To: <5774f193-fc94-a08c-9093-932363b648f2@Intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v1 3/3] MdeModulePkg/NvmExpressDxe: Refine PassThru IO queue creation behavior X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Oct 2018 00:59:06 -0000 Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBOaSwgUnVpeXUNCj4gU2VudDog VHVlc2RheSwgT2N0b2JlciAyMywgMjAxOCA0OjU0IFBNDQo+IFRvOiBXdSwgSGFvIEE7IGVkazIt ZGV2ZWxAbGlzdHMuMDEub3JnDQo+IENjOiBZYW8sIEppZXdlbjsgWmVuZywgU3Rhcg0KPiBTdWJq ZWN0OiBSZTogW1BBVENIIHYxIDMvM10gTWRlTW9kdWxlUGtnL052bUV4cHJlc3NEeGU6IFJlZmlu ZSBQYXNzVGhydQ0KPiBJTyBxdWV1ZSBjcmVhdGlvbiBiZWhhdmlvcg0KPiANCj4gT24gMTAvMTgv MjAxOCAyOjQyIFBNLCBIYW8gV3Ugd3JvdGU6DQo+ID4gUkVGOmh0dHBzOi8vYnVnemlsbGEudGlh bm9jb3JlLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2MA0KPiA+DQo+ID4gRm9yIHRoZSBQYXNzVGhy dSgpIHNlcnZpY2Ugb2YgTlZNIEV4cHJlc3MgUGFzcyBUaHJvdWdoIFByb3RvY29sLCB0aGUNCj4g PiBjdXJyZW50IGltcGxlbWVudGF0aW9uIChmdW5jdGlvbiBOdm1FeHByZXNzUGFzc1RocnUoKSkg d2lsbCBvbmx5IHVzZSB0aGUNCj4gPiBJTyBDb21wbGV0aW9uL1N1Ym1pc3Npb24gcXVldWVzIGNy ZWF0ZWQgaW50ZXJuYWxseSBieSB0aGlzIGRyaXZlciBkdXJpbmcNCj4gPiB0aGUgY29udHJvbGxl ciBpbml0aWFsaXphdGlvbiBwcm9jZXNzLiBBbnkgb3RoZXIgSU8gcXVldWVzIGNyZWF0ZWQgd2ls bA0KPiA+IG5vdCBiZSBjb25zdW1lZC4NCj4gPg0KPiA+IFNvIHRoZSB2YWx1ZSBpcyBsaXR0bGUg dG8gYWNjZXB0IGV4dGVybmFsIElPIENvbXBsZXRpb24vU3VibWlzc2lvbiBxdWV1ZQ0KPiA+IGNy ZWF0aW9uIHJlcXVlc3QuIFRoaXMgY29tbWl0IHdpbGwgcmVmaW5lIHRoZSBiZWhhdmlvciBvZiBm dW5jdGlvbg0KPiA+IE52bUV4cHJlc3NQYXNzVGhydSgpLCBpdCB3aWxsIG9ubHkgYWNjZXB0IGRy aXZlciBpbnRlcm5hbCBJTyBxdWV1ZQ0KPiA+IGNyZWF0aW9uIGNvbW1hbmRzIGFuZCB3aWxsIHJl dHVybiAiRUZJX1VOU1VQUE9SVEVEIiBmb3IgZXh0ZXJuYWwgb25lcy4NCj4gPg0KPiA+IENjOiBK aWV3ZW4gWWFvIDxKaWV3ZW4ueWFvQGludGVsLmNvbT4NCj4gPiBDYzogUnVpeXUgTmkgPHJ1aXl1 Lm5pQGludGVsLmNvbT4NCj4gPiBDYzogU3RhciBaZW5nIDxzdGFyLnplbmdAaW50ZWwuY29tPg0K PiA+IENvbnRyaWJ1dGVkLXVuZGVyOiBUaWFub0NvcmUgQ29udHJpYnV0aW9uIEFncmVlbWVudCAx LjENCj4gPiBTaWduZWQtb2ZmLWJ5OiBIYW8gV3UgPGhhby5hLnd1QGludGVsLmNvbT4NCj4gPiAt LS0NCj4gPiAgIE1kZU1vZHVsZVBrZy9CdXMvUGNpL052bUV4cHJlc3NEeGUvTnZtRXhwcmVzc1Bh c3N0aHJ1LmMgfCA0Mg0KPiArKysrKysrKysrKysrKysrLS0tLQ0KPiA+ICAgMSBmaWxlIGNoYW5n ZWQsIDM0IGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pDQo+ID4NCj4gPiBkaWZmIC0tZ2l0 IGEvTWRlTW9kdWxlUGtnL0J1cy9QY2kvTnZtRXhwcmVzc0R4ZS9Odm1FeHByZXNzUGFzc3RocnUu Yw0KPiBiL01kZU1vZHVsZVBrZy9CdXMvUGNpL052bUV4cHJlc3NEeGUvTnZtRXhwcmVzc1Bhc3N0 aHJ1LmMNCj4gPiBpbmRleCBjNTJlOTYwNzcxLi4wYzU1MGJkNTJjIDEwMDY0NA0KPiA+IC0tLSBh L01kZU1vZHVsZVBrZy9CdXMvUGNpL052bUV4cHJlc3NEeGUvTnZtRXhwcmVzc1Bhc3N0aHJ1LmMN Cj4gPiArKysgYi9NZGVNb2R1bGVQa2cvQnVzL1BjaS9Odm1FeHByZXNzRHhlL052bUV4cHJlc3NQ YXNzdGhydS5jDQo+ID4gQEAgLTQ3Niw2ICs0NzYsNyBAQCBOdm1FeHByZXNzUGFzc1RocnUgKA0K PiA+ICAgICBVSU5UMzIgICAgICAgICAgICAgICAgICAgICAgICAgRGF0YTsNCj4gPiAgICAgTlZN RV9QQVNTX1RIUlVfQVNZTkNfUkVRICAgICAgICpBc3luY1JlcXVlc3Q7DQo+ID4gICAgIEVGSV9U UEwgICAgICAgICAgICAgICAgICAgICAgICBPbGRUcGw7DQo+ID4gKyAgVUlOVDMyICAgICAgICAg ICAgICAgICAgICAgICAgIENySW9RaWQ7DQo+ID4NCj4gPiAgICAgLy8NCj4gPiAgICAgLy8gY2hl Y2sgdGhlIGRhdGEgZmllbGRzIGluIFBhY2tldCBwYXJhbWV0ZXIuDQo+ID4gQEAgLTU4NywxNCAr NTg4LDM5IEBAIE52bUV4cHJlc3NQYXNzVGhydSAoDQo+ID4gICAgIH0NCj4gPg0KPiA+ICAgICBT cS0+UHJwWzBdID0gKFVJTlQ2NCkoVUlOVE4pUGFja2V0LT5UcmFuc2ZlckJ1ZmZlcjsNCj4gPiAt ICAvLw0KPiA+IC0gIC8vIElmIHRoZSBOVk1lIGNtZCBoYXMgZGF0YSBpbiBvciBvdXQsIHRoZW4g bWFwcGluZyB0aGUgdXNlciBidWZmZXIgdG8NCj4gdGhlIFBDSSBjb250cm9sbGVyIHNwZWNpZmlj IGFkZHJlc3Nlcy4NCj4gPiAtICAvLyBOb3RlIGhlcmUgd2UgZG9uJ3QgaGFuZGxlIGRhdGEgYnVm ZmVyIGZvciBDcmVhdGVJT1N1Ym1pdGlvblF1ZXVlDQo+IGFuZCBDcmVhdGVJT0NvbXBsZXRpb25R dWV1ZSBjbWRzIGJlY2F1c2UNCj4gPiAtICAvLyB0aGVzZSB0d28gY21kcyBhcmUgc3BlY2lhbCB3 aGljaCByZXF1aXJlcyB0aGVpciBkYXRhIGJ1ZmZlciBtdXN0DQo+IHN1cHBvcnQgc2ltdWx0YW5l b3VzIGFjY2VzcyBieSBib3RoIHRoZQ0KPiA+IC0gIC8vIHByb2Nlc3NvciBhbmQgYSBQQ0kgQnVz IE1hc3Rlci4gSXQncyBjYWxsZXIncyByZXNwb25zYmlsaXR5IHRvIGVuc3VyZSB0aGlzLg0KPiA+ IC0gIC8vDQo+ID4gLSAgaWYgKCgoU3EtPk9wYyAmIChCSVQwIHwgQklUMSkpICE9IDApICYmDQo+ ID4gLSAgICAgICEoKFBhY2tldC0+UXVldWVUeXBlID09IE5WTUVfQURNSU5fUVVFVUUpICYmICgo U3EtPk9wYyA9PQ0KPiBOVk1FX0FETUlOX0NSSU9DUV9DTUQpIHx8IChTcS0+T3BjID09IE5WTUVf QURNSU5fQ1JJT1NRX0NNRCkpKSkNCj4gew0KPiA+ICsgIGlmICgoUGFja2V0LT5RdWV1ZVR5cGUg PT0gTlZNRV9BRE1JTl9RVUVVRSkgJiYNCj4gPiArICAgICAgKChTcS0+T3BjID09IE5WTUVfQURN SU5fQ1JJT0NRX0NNRCkgfHwgKFNxLT5PcGMgPT0NCj4gTlZNRV9BRE1JTl9DUklPU1FfQ01EKSkp IHsNCj4gPiArICAgIC8vDQo+ID4gKyAgICAvLyBDb21tYW5kIER3b3JkIDEwIHNob3VsZCBiZSB2 YWxpZCBmb3IgQ3JlYXRlSU9Db21wbGV0aW9uUXVldWUNCj4gYW5kDQo+ID4gKyAgICAvLyBDcmVh dGVJT1N1Ym1pc3Npb25RdWV1ZSBjb21tYW5kcy4NCj4gPiArICAgIC8vDQo+ID4gKyAgICBpZiAo IShQYWNrZXQtPk52bWVDbWQtPkZsYWdzICYgQ0RXMTBfVkFMSUQpKSB7DQo+ID4gKyAgICAgIHJl dHVybiBFRklfSU5WQUxJRF9QQVJBTUVURVI7DQo+ID4gKyAgICB9DQo+ID4gKw0KPiA+ICsgICAg Ly8NCj4gPiArICAgIC8vIEJpdHMgMTU6MCBvZiBDb21tYW5kIER3b3JkIDEwIGlzIHRoZSBRdWV1 ZSBJZGVudGlmaWVyIChRSUQpIGZvcg0KPiA+ICsgICAgLy8gQ3JlYXRlSU9Db21wbGV0aW9uUXVl dWUgYW5kIENyZWF0ZUlPU3VibWlzc2lvblF1ZXVlIGNvbW1hbmRzLg0KPiA+ICsgICAgLy8NCj4g PiArICAgIENySW9RaWQgPSBQYWNrZXQtPk52bWVDbWQtPkNkdzEwICYgMHhGRkZGOw0KPiA+ICsN Cj4gPiArICAgIC8vDQo+ID4gKyAgICAvLyBDdXJyZW50bHksIHdlIG9ubHkgdXNlIHRoZSBJTyBD b21wbGV0aW9uL1N1Ym1pc3Npb24gcXVldWVzIGNyZWF0ZWQNCj4gaW50ZXJuYWxseQ0KPiA+ICsg ICAgLy8gYnkgdGhpcyBkcml2ZXIgZHVyaW5nIGNvbnRyb2xsZXIgaW5pdGlhbGl6YXRpb24uIEFu eSBvdGhlciBJTyBxdWV1ZXMNCj4gY3JlYXRlZA0KPiA+ICsgICAgLy8gd2lsbCBub3QgYmUgY29u c3VtZWQgaGVyZS4gVGhlIHZhbHVlIGlzIGxpdHRsZSB0byBhY2NlcHQgZXh0ZXJuYWwgSU8NCj4g cXVldWUNCj4gPiArICAgIC8vIGNyZWF0aW9uIHJlcXVlc3RzLCBzbyBoZXJlIHdlIHdpbGwgcmV0 dXJuIEVGSV9VTlNVUFBPUlRFRCBmb3INCj4gZXh0ZXJuYWwgSU8NCj4gPiArICAgIC8vIHF1ZXVl IGNyZWF0aW9uIHJlcXVlc3QuDQo+ID4gKyAgICAvLw0KPiA+ICsgICAgaWYgKChDcklvUWlkID49 IE5WTUVfTUFYX1FVRVVFUykgfHwNCj4gPiArICAgICAgICAoKFNxLT5PcGMgPT0gTlZNRV9BRE1J Tl9DUklPQ1FfQ01EKSAmJiAoUGFja2V0LQ0KPiA+VHJhbnNmZXJCdWZmZXIgIT0gUHJpdmF0ZS0+ Q3FCdWZmZXJQY2lBZGRyW0NySW9RaWRdKSkgfHwNCj4gPiArICAgICAgICAoKFNxLT5PcGMgPT0g TlZNRV9BRE1JTl9DUklPU1FfQ01EKSAmJiAoUGFja2V0LQ0KPiA+VHJhbnNmZXJCdWZmZXIgIT0g UHJpdmF0ZS0+U3FCdWZmZXJQY2lBZGRyW0NySW9RaWRdKSkpIHsNCj4gPiArICAgICAgREVCVUcg KChERUJVR19FUlJPUiwgIk52bUV4cHJlc3NQYXNzVGhydTogRG9lcyBub3Qgc3VwcG9ydA0KPiBl eHRlcm5hbCBJTyBxdWV1ZXMgY3JlYXRpb24gcmVxdWVzdC5cbiIpKTsNCj4gPiArICAgICAgcmV0 dXJuIEVGSV9VTlNVUFBPUlRFRDsNCj4gPiArICAgIH0NCj4gDQo+IERvZXMgdGhlIGFib3ZlIGNo ZWNrIGlzIHRvIG1ha2Ugc3VyZSBvbmx5IGFjY2VwdCBJTyBxdWV1ZXMgY3JlYXRpb24NCj4gcmVx dWVzdCBmcm9tIE52bWVDcmVhdGVJb0NvbXBsZXRpb25RdWV1ZSgpIGFuZA0KPiBOdm1lQ3JlYXRl SW9TdWJtaXNzaW9uUXVldWUoKT8NCg0KWWVzLiBBY3R1YWxseSwgdGhlIGFib3ZlIGNvZGVzIChp bmNsdWRpbmcgdGhlICJQYWNrZXQtPk52bWVDbWQtPkZsYWdzIikgYXJlIHRvDQplbnN1cmUgdGhh dCB0aGUgSU8gcXVldWVzIGNyZWF0aW9uIHJlcXVlc3QgaXMgaW50ZXJuYWwuDQoNCj4gDQo+IFRo ZSBjaGVjayBpcyB2ZXJ5IGNvbXBsZXggYW5kIHVubmVjZXNzYXJ5IElNTy4gSWYgd2UgaW50cm9k dWNlIGEgYm9vbGVhbg0KPiBmaWVsZCBsaWtlIENyZWF0ZVF1ZXVlIGluIHRoZSBQcml2YXRlIHN0 cnVjdHVyZSBhbmQgc2V0IGl0IHRvIFRSVUUgd2hlbg0KPiBjYWxsaW5nIFBhc3NUaHJ1KCkgZnJv bSB0aGUgYWJvdmUgdHdvIGludGVybmFsIGZ1bmN0aW9ucywgdGhlIGFib3ZlDQo+IGNoZWNrIGNh biBiZSByZXBsYWNlZCB3aXRoIG9ubHkgb25lIGxpbmUgY2hlY2s6DQo+ICAgIGlmIChQcml2YXRl LT5DcmVhdGVRdWV1ZSkNCj4gDQo+IEl0IGRvZXMgaW50cm9kdWNlIGEgImRpcnR5IiBmbGFnIGlu IFByaXZhdGUgc3RydWN0dXJlLCBidXQgdGhlIGFib3ZlDQo+IGNvbXBsZXggY2hlY2sgY2FuIGJl IGF2b2lkZWQuDQo+IFdoYXQncyB5b3VyIG9waW5pb24/DQoNClllcywgSSB0aGluayBmb3IgdGhp cyB3YXkgdGhlIGNvZGUgaXMgbW9yZSBzaW1wbGUuDQpJIHdpbGwgcHJvcG9zZSBhIFYyIG9mIHRo ZSBzZXJpZXMuDQoNCkJlc3QgUmVnYXJkcywNCkhhbyBXdQ0KDQo+IA0KPiA+ICsgIH0gZWxzZSBp ZiAoKFNxLT5PcGMgJiAoQklUMCB8IEJJVDEpKSAhPSAwKSB7DQo+ID4gKyAgICAvLw0KPiA+ICsg ICAgLy8gSWYgdGhlIE5WTWUgY21kIGhhcyBkYXRhIGluIG9yIG91dCwgdGhlbiBtYXBwaW5nIHRo ZSB1c2VyIGJ1ZmZlciB0bw0KPiB0aGUgUENJIGNvbnRyb2xsZXIgc3BlY2lmaWMgYWRkcmVzc2Vz Lg0KPiA+ICsgICAgLy8NCj4gPiAgICAgICBpZiAoKChQYWNrZXQtPlRyYW5zZmVyTGVuZ3RoICE9 IDApICYmIChQYWNrZXQtPlRyYW5zZmVyQnVmZmVyID09IE5VTEwpKQ0KPiB8fA0KPiA+ICAgICAg ICAgICAoKFBhY2tldC0+VHJhbnNmZXJMZW5ndGggPT0gMCkgJiYgKFBhY2tldC0+VHJhbnNmZXJC dWZmZXIgIT0gTlVMTCkpKSB7DQo+ID4gICAgICAgICByZXR1cm4gRUZJX0lOVkFMSURfUEFSQU1F VEVSOw0KPiA+DQo+IA0KPiANCj4gLS0NCj4gVGhhbmtzLA0KPiBSYXkNCg==