From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "Zhang, Shenglei" <shenglei.zhang@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Ni, Ruiyu" <ruiyu.ni@intel.com>
Subject: Re: [PATCH] Nt32Pkg: Remove PcdShellFile in DSC
Date: Thu, 8 Nov 2018 04:33:28 +0000 [thread overview]
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A093C84B42D@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20181108022822.17812-1-shenglei.zhang@intel.com>
> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Thursday, November 08, 2018 10:28 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu; Wu, Hao A
> Subject: [PATCH] Nt32Pkg: Remove PcdShellFile in DSC
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=1298
> This change is based on the change below:
> https://lists.01.org/pipermail/edk2-devel/2018-November/031875.html
Hi,
The patch is good to me.
Reviewed-by: Hao Wu <hao.a.wu@intel.com>
However, IMO it will be more clear to append this patch and the one for
EmulatorPkg after the patch series you mentioned above:
[PATCH v3 0/5] Remove EdkShellBinPkg in FDF, DSC and DEC
and make a v4 for the series.
Best Regards,
Hao Wu
>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Hao Wu <hao.a.wu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> Nt32Pkg/Nt32Pkg.dsc | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Nt32Pkg/Nt32Pkg.dsc b/Nt32Pkg/Nt32Pkg.dsc
> index bbaa415ee0..4dbde0cc45 100644
> --- a/Nt32Pkg/Nt32Pkg.dsc
> +++ b/Nt32Pkg/Nt32Pkg.dsc
> @@ -280,7 +280,6 @@
> gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE
> !endif
>
> - gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5,
> 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4,
> 0xD1 }
>
> !if $(SECURE_BOOT_ENABLE) == TRUE
> # override the default values from SecurityPkg to ensure images from all
> sources are verified in secure boot
> --
> 2.18.0.windows.1
prev parent reply other threads:[~2018-11-08 4:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 2:28 [PATCH] Nt32Pkg: Remove PcdShellFile in DSC Shenglei Zhang
2018-11-08 2:28 ` [PATCH] EmulatorPkg: " Shenglei Zhang
2018-11-08 5:38 ` Ni, Ruiyu
2018-11-08 4:33 ` Wu, Hao A [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B80AF82E9BFB8E4FBD8C89DA810C6A093C84B42D@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox