From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=hao.a.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 879A12118D950 for ; Wed, 7 Nov 2018 20:33:49 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Nov 2018 20:33:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,478,1534834800"; d="scan'208";a="89468113" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga006.jf.intel.com with ESMTP; 07 Nov 2018 20:33:47 -0800 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 7 Nov 2018 20:33:46 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 7 Nov 2018 20:33:46 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.117]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.214]) with mapi id 14.03.0415.000; Thu, 8 Nov 2018 12:33:28 +0800 From: "Wu, Hao A" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" Thread-Topic: [PATCH] Nt32Pkg: Remove PcdShellFile in DSC Thread-Index: AQHUdwrEjb0mM9sUNEuxyQWMMqJ4SKVFSTUA Date: Thu, 8 Nov 2018 04:33:28 +0000 Message-ID: References: <20181108022822.17812-1-shenglei.zhang@intel.com> In-Reply-To: <20181108022822.17812-1-shenglei.zhang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] Nt32Pkg: Remove PcdShellFile in DSC X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Nov 2018 04:33:49 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Zhang, Shenglei > Sent: Thursday, November 08, 2018 10:28 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu; Wu, Hao A > Subject: [PATCH] Nt32Pkg: Remove PcdShellFile in DSC >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1298 > This change is based on the change below: > https://lists.01.org/pipermail/edk2-devel/2018-November/031875.html Hi, The patch is good to me. Reviewed-by: Hao Wu However, IMO it will be more clear to append this patch and the one for EmulatorPkg after the patch series you mentioned above: [PATCH v3 0/5] Remove EdkShellBinPkg in FDF, DSC and DEC and make a v4 for the series. Best Regards, Hao Wu >=20 > Cc: Ruiyu Ni > Cc: Hao Wu > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Shenglei Zhang > --- > Nt32Pkg/Nt32Pkg.dsc | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/Nt32Pkg/Nt32Pkg.dsc b/Nt32Pkg/Nt32Pkg.dsc > index bbaa415ee0..4dbde0cc45 100644 > --- a/Nt32Pkg/Nt32Pkg.dsc > +++ b/Nt32Pkg/Nt32Pkg.dsc > @@ -280,7 +280,6 @@ > gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE > !endif >=20 > - gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, > 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0= xB4, > 0xD1 } >=20 > !if $(SECURE_BOOT_ENABLE) =3D=3D TRUE > # override the default values from SecurityPkg to ensure images from a= ll > sources are verified in secure boot > -- > 2.18.0.windows.1