Re: [PATCH v2 2/2] IntelFsp2WrapperPkg: Fix constant if statements issue

["Wu, Hao A" <hao.a.wu@intel.com>]

> -----Original Message-----
> From: Chiu, Chasel
> Sent: Thursday, November 22, 2018 11:51 AM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen; Desimone, Nathaniel L; Wu, Hao A; Chiu, Chasel
> Subject: [PATCH v2 2/2] IntelFsp2WrapperPkg: Fix constant if statements
> issue
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1351
> 
> Internal code quality scanning found 2 constant if
> statements related to FixedPcdGet8 () usage.
> Since the PCD can be PatchableInModule too, it should be
> changed to PcdGet8 () to fix this issue.
> 
> Test: Verified on internal platform and booted successfully.

Reviewed-by: Hao Wu <hao.a.wu@intel.com>

Best Regards,
Hao Wu

> 
> Cc: Jiewen Yao <Jiewen.yao@intel.com>
> Cc: Desimone Nathaniel L <nathaniel.l.desimone@intel.com>
> Cc: Wu Hao A <hao.a.wu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
> ---
>  IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c | 2 +-
>  IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c
> b/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c
> index fa0441ce6c..18f04b541a 100644
> --- a/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c
> +++ b/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c
> @@ -157,7 +157,7 @@ FspmWrapperInit (
> 
>    Status = EFI_SUCCESS;
> 
> -  if (FixedPcdGet8 (PcdFspModeSelection) == 1) {
> +  if (PcdGet8 (PcdFspModeSelection) == 1) {
>      Status = PeiFspMemoryInit ();
>      ASSERT_EFI_ERROR (Status);
>    } else {
> diff --git a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> index 87dd61e5c5..d748b21f7c 100644
> --- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> +++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> @@ -349,7 +349,7 @@ FspsWrapperPeimEntryPoint (
>  {
>    DEBUG ((DEBUG_INFO, "FspsWrapperPeimEntryPoint\n"));
> 
> -  if (FixedPcdGet8 (PcdFspModeSelection) == 1) {
> +  if (PcdGet8 (PcdFspModeSelection) == 1) {
>      FspsWrapperInit ();
>    } else {
>      PeiServicesInstallFvInfoPpi (
> --
> 2.13.3.windows.1