From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=hao.a.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5A3772119EBF6 for ; Wed, 19 Dec 2018 05:06:39 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Dec 2018 05:06:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,372,1539673200"; d="scan'208";a="303460691" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga006.fm.intel.com with ESMTP; 19 Dec 2018 05:06:38 -0800 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 19 Dec 2018 05:06:39 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 19 Dec 2018 05:06:38 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.203]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.222]) with mapi id 14.03.0415.000; Wed, 19 Dec 2018 21:06:37 +0800 From: "Wu, Hao A" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Wang, Jian J" , "Zeng, Star" Thread-Topic: [PATCH v3 3/3] MdeModulePkg/EbcDebugger: Remove an internal function AsciiToUpper Thread-Index: AQHUl3b6Mt73EGlmSESMeylUK3uPSqWGBAMQ Date: Wed, 19 Dec 2018 13:06:36 +0000 Message-ID: References: <20181219084318.4024-1-shenglei.zhang@intel.com> <20181219084318.4024-4-shenglei.zhang@intel.com> In-Reply-To: <20181219084318.4024-4-shenglei.zhang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v3 3/3] MdeModulePkg/EbcDebugger: Remove an internal function AsciiToUpper X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Dec 2018 13:06:40 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, I think the patch will bring issue with regard to bisecting. One way to resolve this is to introduce a patch to rename the 'AsciiToUpper= ' within file EdbSupportString.c to something like 'InternalAsciiToUpper'. An= d make the new patch as the 1st one of the series. Then goes the remaining 3 patches of this version of the series. I also have a question that will we perform a cleanup for other 'XXXToUpper= ' functions within the code base? I did a quick search for keyword 'ToUpper', and found some (not all) possib= le candidates that can be replaced with the newly added BaseLib APIs: FatPkg\FatPei\FatLiteLib.c Line 34: ToUpper ( MdeModulePkg\Library\DxeHttpLib\DxeHttpLib.c Line 911: HttpIoCharToUpper ( MdeModulePkg\Universal\EbcDxe\EbcDebugger\EdbSupportString.c Line 319: UnicodeToUpper ( ShellPkg\Library\UefiShellDebug1CommandsLib\UefiShellDebug1CommandsLib.c Line 134: CharToUpper ( ShellPkg\Library\UefiShellLib\UefiShellLib.c Line 3759: InternalShellCharToUpper ( Best Regards, Hao Wu > -----Original Message----- > From: Zhang, Shenglei > Sent: Wednesday, December 19, 2018 4:43 PM > To: edk2-devel@lists.01.org > Cc: Wang, Jian J; Wu, Hao A; Zeng, Star > Subject: [PATCH v3 3/3] MdeModulePkg/EbcDebugger: Remove an internal > function AsciiToUpper >=20 > AsciiToUpper in EdbSupportString.c is an internal function. > And we will introduce a public function which has the same name > and effect. So we remove its implement. Code in EdbSupportString.c > now consumes the public one. > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1369 >=20 > Cc: Jian J Wang > Cc: Hao Wu > Cc: Star Zeng > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Shenglei Zhang > --- > .../EbcDxe/EbcDebugger/EdbSupportString.c | 15 --------------- > 1 file changed, 15 deletions(-) >=20 > diff --git > a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c > b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c > index 78a0559079..0eb894ddfb 100644 > --- a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c > +++ b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c > @@ -323,21 +323,6 @@ UnicodeToUpper ( > return (Chr >=3D L'a' && Chr <=3D L'z') ? Chr - (L'a' - L'A') : Chr; > } >=20 > -/** > - > - Convert the character to upper case. > - > - @param Chr the character to be converted. > - > -**/ > -STATIC > -CHAR8 > -AsciiToUpper ( > - IN CHAR8 Chr > - ) > -{ > - return (Chr >=3D 'a' && Chr <=3D 'z') ? Chr - ('a' - 'A') : Chr; > -} >=20 > /** > Compare the Unicode and Ascii string pointed by String to the string > pointed by String2. > -- > 2.18.0.windows.1